fix: do not remove default config volume when providing additional config (#1480)

fix: do not remove default config volume when providing external config

closes #1479

Signed-off-by: Daniel Goldman <[email protected]>

Author: lilatomic

internal/k8sutils/statefulset.go

@@ -330,7 +330,7 @@ func generateStatefulSetsDef(stsMeta metav1.ObjectMeta, params statefulSetParame
 		statefulset.Spec.VolumeClaimTemplates = append(statefulset.Spec.VolumeClaimTemplates, createPVCTemplate(pvcTplName, stsMeta, params.PersistentVolumeClaim))
 	}
 	if params.ExternalConfig != nil {
-		statefulset.Spec.Template.Spec.Volumes = getExternalConfig(*params.ExternalConfig)
+		statefulset.Spec.Template.Spec.Volumes = append(statefulset.Spec.Template.Spec.Volumes, getExternalConfig(*params.ExternalConfig)...)
 	}
 	if containerParams.AdditionalVolume != nil {
 		statefulset.Spec.Template.Spec.Volumes = append(statefulset.Spec.Template.Spec.Volumes, containerParams.AdditionalVolume...)

internal/k8sutils/statefulset_test.go

@@ -1799,6 +1799,12 @@ func TestGenerateStatefulSetsDef(t *testing.T) {
 								},
 							},
 							Volumes: []corev1.Volume{
+								{
+									Name: "config",
+									VolumeSource: corev1.VolumeSource{
+										EmptyDir: &corev1.EmptyDirVolumeSource{},
+									},
+								},
 								{
 									Name: "external-config",
 									VolumeSource: corev1.VolumeSource{