-
-
Notifications
You must be signed in to change notification settings - Fork 333
Description
Is your feature request related to a problem? Please describe.
I am trying to use additional annotations in order to work with exernal-dns. Using the recent operator upgrade PR (#1219) we are able to configure additional annotations for headless services.
However, currently the operator adds annotations for both leader-headless and follower-headless services.
Describe the solution you'd like
We should have an option to choose if we want to enable additionalannotations for leader-headless or follower-headless or for both. We do not want to add these annotations for follower services.
Ideal solution would be to have separate service template like charts/redis-cluster/templates/leader-service.yaml and like charts/redis-cluster/templates/follower-service.yaml for leader-headless and follower-headless services. Where we have an option to configure headless services.
Describe alternatives you've considered
Patching k8sutils/labels.go file method - generateServiceAnots - add an if condition to check if its for leader or for follower. If for follower skip the additional annotations - well that's only for our usecase.
I also tried 'hacking' external service templates leader-service.yaml and follower-service.yaml - which creates additional services with ClusterIP - None
What version of redis-operator are you using?
redis-operator version: 0.19.1
Additional context
Additionally
Apart from this we would be happy to have one more option/flag to choose enable/disable creating
test-cluster-follower-headless
test-cluster-follower
services.
We might not want to create services for follower for example we might not want to create test-cluster-follower-headless, test-cluster-follower .
Thanks,
Arpan