Build on Request (for MacOS)

[tysonstrange]

Might just be a me problem, but I can't get the build on request to run for macos.

The build on request wasnt updated for a little while, all the checkout@v2 needs to be changed to @v4

The run-on macos-11 is also deprecated, and needs to be 13, 14, 15 or macos-latest.

I've tried updating those basic details, can get the others to build fine, but macos is throwing out some errors. Appears to be related to some old dependancies, but im not able to see why, since the vcpkg git commit reference used in the workflow is for versions above 1.72 .

2024-12-17T10:26:27.7517080Z /Users/runner/work/otcv8-ota-clone/vcpkg/installed/x64-osx/include/boost/mpl/aux_/integral_wrapper.hpp:73:31: error: integer value -1 is outside the valid range of values [0, 3] for this enumeration type [-Wenum-constexpr-conversion]
2024-12-17T10:26:27.7517430Z /Users/runner/work/otcv8-ota-clone/vcpkg/installed/x64-osx/include/boost/mpl/aux_/static_cast.hpp:24:47: note: expanded from macro 'BOOST_MPL_AUX_STATIC_CAST'
2024-12-17T10:26:27.7517540Z #   define BOOST_MPL_AUX_STATIC_CAST(T, expr) static_cast<T>(expr)
2024-12-17T10:26:27.7517600Z                                               ^
2024-12-17T10:26:27.7517670Z In file included from ../src/pthread/thread.cpp:11:
2024-12-17T10:26:27.7517780Z In file included from ../include/boost/thread/thread_only.hpp:22:
2024-12-17T10:26:27.7517890Z In file included from ../include/boost/thread/detail/thread.hpp:41:
2024-12-17T10:26:27.7518140Z In file included from /Users/runner/work/otcv8-ota-clone/vcpkg/installed/x64-osx/include/boost/functional/hash.hpp:6:
2024-12-17T10:26:27.7518620Z /Users/runner/work/otcv8-ota-clone/vcpkg/installed/x64-osx/include/boost/container_hash/hash.hpp:132:33: warning: 'unary_function<const std::error_category *, unsigned long>' is deprecated [-Wdeprecated-declarations]
2024-12-17T10:26:27.7518730Z         struct hash_base : std::unary_function<T, std::size_t> {};
2024-12-17T10:26:27.7518770Z                                 ^
2024-12-17T10:26:27.7519270Z /Users/runner/work/otcv8-ota-clone/vcpkg/installed/x64-osx/include/boost/container_hash/hash.hpp:692:18: note: in instantiation of template class 'boost::hash_detail::hash_base<const std::error_category *>' requested here
2024-12-17T10:26:27.7519340Z         : public boost::hash_detail::hash_base<T*>
2024-12-17T10:26:27.7519370Z                  ^
2024-12-17T10:26:27.7519870Z /Users/runner/work/otcv8-ota-clone/vcpkg/installed/x64-osx/include/boost/container_hash/hash.hpp:420:24: note: in instantiation of template class 'boost::hash<const std::error_category *>' requested here
2024-12-17T10:26:27.7519930Z         boost::hash<T> hasher;
2024-12-17T10:26:27.7519970Z                        ^
2024-12-17T10:26:27.7520480Z /Users/runner/work/otcv8-ota-clone/vcpkg/installed/x64-osx/include/boost/container_hash/hash.hpp:551:9: note: in instantiation of function template specialization 'boost::hash_combine<const std::error_category *>' requested here
2024-12-17T10:26:27.7520540Z         hash_combine(seed, &v.category());
2024-12-17T10:26:27.7520580Z         ^
2024-12-17T10:26:27.7521180Z /Applications/Xcode_15.4.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.5.sdk/usr/include/c++/v1/__functional/unary_function.h:23:29: note: 'unary_function<const std::error_category *, unsigned long>' has been explicitly marked deprecated here
2024-12-17T10:26:27.7521310Z struct _LIBCPP_TEMPLATE_VIS _LIBCPP_DEPRECATED_IN_CXX11 unary_function
2024-12-17T10:26:27.7521360Z                             ^
2024-12-17T10:26:27.7521810Z /Applications/Xcode_15.4.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.5.sdk/usr/include/c++/v1/__config:1025:41: note: expanded from macro '_LIBCPP_DEPRECATED_IN_CXX11'
2024-12-17T10:26:27.7521900Z #    define _LIBCPP_DEPRECATED_IN_CXX11 _LIBCPP_DEPRECATED
2024-12-17T10:26:27.7522000Z                                         ^
2024-12-17T10:26:27.7522420Z /Applications/Xcode_15.4.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.5.sdk/usr/include/c++/v1/__config:1010:49: note: expanded from macro '_LIBCPP_DEPRECATED'
2024-12-17T10:26:27.7522520Z #      define _LIBCPP_DEPRECATED __attribute__((__deprecated__))
2024-12-17T10:26:27.7522570Z                                                 ^
2024-12-17T10:26:27.7522630Z 33 warnings and 2 errors generated.
2024-12-17T10:26:27.7522680Z ...failed updating 1 target...
2024-12-17T10:26:27.7522740Z ninja: build stopped: subcommand failed.

It's saying some functions in boost are deprecated, but it should be using boost 1.76 in this and later vcpkg commits up to e82778a710538de07955dea6eb785132c3804d63 that use 1.80 and C++ 17

I am not familiar with macos. Any advice or suggestion?

[Oen44]

I don't have MacOS to test and I'm not a DevOps guy to work with these github workflows. And the last time I had to fix them it was pain in the ass because you can't test them locally, every time you want to check if your change works you have to push new workflow script and run the action. On top of that, MacOS actions are paid after free monthly limit is reached.

[tysonstrange]

Yeah... im in the same boat. I'm probably going to run out of minutes pretty soon. but you can make a new github account, fork/clone the repo and re-run the workflows if you run out of minutes xD

[tysonstrange]

Have exhausted the minutes on 2 github accounts. i hate apple.

on a side note, if using the client updater to update the binary for mac and linux, it will download the new one, save it into the linux/macos version of appdata but then WONT have permission to execute, so it will brick the client.

chmod +x needs to be manually executed on the new binary, which is difficult to do for the layman