fix: mypy errors

Author: krerkkiat

grading_lib/cli/__init__.py

@@ -42,7 +42,7 @@ def summary_command() -> None:
 @cli.command(name="rebase-todo-injector")
 @click.argument("todo_items_file_path")
 @click.argument("path")
-def rebase_todo_injector_command(todo_items_file_path, path) -> None:
+def rebase_todo_injector_command(todo_items_file_path: str, path: str) -> None:
     """
     An 'editor' that inject pre-made todo items for git interactive rebase.
 

grading_lib/qa.py

@@ -1,9 +1,15 @@
 """Set of utilities for quality assurance of the grading script."""
 
+import typing as ty
 from importlib import import_module
+from types import TracebackType
 
+from typing_extensions import Self
 
-def import_as_non_testcase(module_name, name, package=None):
+
+def import_as_non_testcase(
+    module_name: str, name: str, package: str | None = None
+) -> ty.Any:
     """Import the name from a module and prevent pytest from running it as testcase."""
     mod = import_module(module_name, package=package)
     cls = mod.__dict__[name]
@@ -17,13 +23,19 @@ class SetupThenTearDown:
     Intended to be used in the QA script.
     """
 
-    def __init__(self, obj):
+    def __init__(self, obj: ty.Any) -> None:
         self.obj = obj
 
-    def __enter__(self):
+    def __enter__(self) -> Self:
         if hasattr(self.obj, "setUp"):
             self.obj.setUp()
-
-    def __exit__(self, exc_type, exc_val, exc_tb):
+        return self
+
+    def __exit__(
+        self,
+        exc_type: type[BaseException] | None,
+        exc_val: BaseException | None,
+        exc_tb: TracebackType | None,
+    ) -> None:
         if hasattr(self.obj, "tearDown"):
             self.obj.tearDown()

grading_lib/repository.py

@@ -4,16 +4,19 @@
 import tempfile
 import uuid
 from pathlib import Path
+from types import TracebackType
 
 from git import Head, Repo, Tag
 from git.repo.fun import is_git_dir
+from typing_extensions import Self
 
 from .common import BaseTestCase, CommandResult, run_executable
 
 
 def ensure_git_author_identity(
-    name="ou-cs3560-grading-script", email="[email protected]"
-):
+    name: str = "ou-cs3560-grading-script",
+    email: str = "[email protected]",
+) -> None:
     """
     Set user.name and user.email is not set unless they are already set.
     """
@@ -41,9 +44,9 @@ class Repository:
     :raise ValueError: When the repository does not have a working tree directory.
     """
 
-    def __init__(self, path: str | Path, *args, **kwargs):
+    def __init__(self, path: str | Path, *args, **kwargs) -> None:
         self.repo: Repo
-        self.temp_dir: tempfile.TemporaryDirectory | None = None
+        self.temp_dir: tempfile.TemporaryDirectory[str] | None = None
 
         if isinstance(path, str):
             path = Path(path)
@@ -90,10 +93,15 @@ def __init__(self, path: str | Path, *args, **kwargs):
 
         self.working_tree_dir = Path(self.repo.working_tree_dir)
 
-    def __enter__(self):
+    def __enter__(self) -> Self:
         return self
 
-    def __exit__(self, exc_type, exc_val, exc_tb) -> None:
+    def __exit__(
+        self,
+        exc_type: type[BaseException] | None,
+        exc_val: BaseException | None,
+        exc_tb: TracebackType | None,
+    ) -> None:
         self.cleanup()
 
     def cleanup(self) -> None: