Skip to content

Add type hints and Refactoring #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tkamiya22 wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Add type hints and Refactoring #57

tkamiya22 wants to merge 5 commits into from

Conversation

@tkamiya22
Copy link

@tkamiya22 tkamiya22 commented Jul 21, 2024

resolve #38
Commits are separate for adding type hints and refactoring.

Type hints have been added to the following places:

  • Method arguments
  • Return values ​​of abstract methods
  • Variables for which can not type inference, such as []

For dicts, the element type has been made explicit with TypedDict.

@tkamiya22
Copy link
Author

tkamiya22 commented Jul 21, 2024

I noticed that commit 69a040e contains changes which is not of type hint.
It was added to prevent the variable type from becoming Unbound, but it affects when adding encoder types.

https://github.com/tkamiya22/rmqrcode-python/blob/69a040eb3e70adf733e8656f3784d9f574b94765/src/rmqrcode/segments.py#L166-L167

https://github.com/tkamiya22/rmqrcode-python/blob/69a040eb3e70adf733e8656f3784d9f574b94765/src/rmqrcode/segments.py#L188-L189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Type hinting

1 participant

@tkamiya22