Skip to content

Commit 276aa77

Browse files
committed
Merge branch 'feature-shorten-ptai-labels'
2 parents 16acbaf + 6a0172a commit 276aa77

File tree

2 files changed

+26
-3
lines changed

2 files changed

+26
-3
lines changed

plugin/src/main/java/org/owasp/benchmarkutils/score/parsers/sarif/PTAIReader.java

Lines changed: 24 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,37 @@
1818
package org.owasp.benchmarkutils.score.parsers.sarif;
1919

2020
import org.owasp.benchmarkutils.score.CweNumber;
21+
import org.owasp.benchmarkutils.score.ResultFile;
22+
import org.owasp.benchmarkutils.score.TestSuiteResults;
2123

2224
public class PTAIReader extends SarifReader {
2325

2426
static final int PTAI_CWE_EXTERNAL_FILEPATH_CONTROL = 73;
2527
static final int PTAI_CWE_BLIND_XPATH_INJECTION = 91;
2628

29+
static final String EXPECTED_TOOL_NAME = "Positive Technologies Application Inspector";
30+
static final String SHORTENED_TOOL_NAME = "PT Application Inspector";
31+
2732
public PTAIReader() {
28-
super("Positive Technologies Application Inspector", true, CweSourceType.FIELD);
33+
super(EXPECTED_TOOL_NAME, true, CweSourceType.FIELD);
34+
}
35+
36+
@Override
37+
public String toolName(ResultFile resultFile) {
38+
return SHORTENED_TOOL_NAME;
39+
}
40+
41+
/**
42+
* SARIF report tool version field is too long as it contains build number. Shorten it to X.Y.Z
43+
*/
44+
@Override
45+
public void setVersion(ResultFile resultFile, TestSuiteResults testSuiteResults) {
46+
super.setVersion(resultFile, testSuiteResults);
47+
String version = testSuiteResults.getToolVersion();
48+
String[] versionItems = version.split("\\.");
49+
if (versionItems.length < 4) return;
50+
testSuiteResults.setToolVersion(
51+
String.format("%s.%s.%s", versionItems[0], versionItems[1], versionItems[2]));
2952
}
3053

3154
@Override

plugin/src/test/java/org/owasp/benchmarkutils/score/parsers/sarif/PTAIReaderTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ void readerHandlesGivenResultFile() throws Exception {
4646

4747
assertEquals(TestSuiteResults.ToolType.SAST, result.getToolType());
4848

49-
assertEquals("Positive Technologies Application Inspector", result.getToolName());
50-
assertEquals("4.7.2.36549", result.getToolVersion());
49+
assertEquals("PT Application Inspector", result.getToolName());
50+
assertEquals("4.7.2", result.getToolVersion());
5151

5252
assertEquals(2, result.getTotalResults());
5353

0 commit comments

Comments
 (0)