Skip to content

Commit 8acec84

Browse files
committed
fix(network): Address CodeRabbit feedback on NAT resilience and S3 bucket keys
1 parent a0706b0 commit 8acec84

File tree

1 file changed

+5
-4
lines changed
  • Terraform/modules/01-Network

1 file changed

+5
-4
lines changed

Terraform/modules/01-Network/main.tf

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,9 @@ resource "aws_subnet" "private" {
5959

6060
# Routing and NAT Gateway for Private Subnets
6161

62-
# We create a SINGLE NAT Gateway and a SINGLE private route table. This is more
63-
# resilient, cost-effective, and simpler to manage than a per-AZ NAT Gateway.
62+
# We create a SINGLE NAT Gateway and a SINGLE private route table. This is a cost
63+
# optimization but introduces a single-AZ egress SPOF compared to per-AZ NAT gateways.
64+
# Scale to one NAT per AZ if higher availability is required.
6465

6566
resource "aws_eip" "nat" {
6667
tags = merge(
@@ -220,7 +221,7 @@ resource "aws_s3_bucket_server_side_encryption_configuration" "alb_access_logs"
220221
apply_server_side_encryption_by_default {
221222
sse_algorithm = "AES256"
222223
}
223-
bucket_key_enabled = true
224+
224225
}
225226
}
226227

@@ -232,7 +233,7 @@ resource "aws_s3_bucket_server_side_encryption_configuration" "s3_server_access_
232233
apply_server_side_encryption_by_default {
233234
sse_algorithm = "AES256"
234235
}
235-
bucket_key_enabled = true
236+
236237
}
237238
}
238239

0 commit comments

Comments
 (0)