Fixed IndexError when parsing malformed --modules-extra-args

- Added validation to check for '=' sign before splitting
- Provided the helpful error message when format is invalid
- Used split('=', 1) to properly handle values containing '=' characters
- Fixes issue #1199

Author: immortal71

nettacker/core/arg_parser.py

@@ -736,7 +736,20 @@ def parse_arguments(self):
         if options.modules_extra_args:
             all_args = {}
             for args in options.modules_extra_args.split("&"):
-                value = args.split("=")[1]
+                # Validate format
+                if "=" not in args:
+                    die_failure(
+                        f"Invalid format for --modules-extra-args: '{args}'\n"
+                        f"Expected format: key1=value1&key2=value2\n"
+                        f"Example: --modules-extra-args \"x_api_key=123&xyz_passwd=abc\""
+                    )
+                
+                # Split with maxsplit=1 to handle values containing '='
+                parts = args.split("=", 1)
+                key = parts[0]
+                value = parts[1]
+                
+                # Type conversion logic
                 if value.lower() == "true":
                     value = True
                 elif value.lower() == "false":
@@ -756,7 +769,8 @@ def parse_arguments(self):
                         value = int(value)
                     except Exception:
                         pass
-                all_args[args.split("=")[0]] = value
+                
+                all_args[key] = value
             options.modules_extra_args = all_args
 
         options.timeout = float(options.timeout)