Skip to content

Commit 131b11f

Browse files
authored
Merge pull request #2160 from OWASP/copilot/fix-2159
Update Node.js version from 22 to 24 across all configurations with compatible engines constraint
2 parents 4aa604b + 694996b commit 131b11f

File tree

11 files changed

+25
-7
lines changed

11 files changed

+25
-7
lines changed

.github/workflows/pr-preview.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,7 @@ jobs:
335335
- name: Setup Node.js
336336
uses: actions/setup-node@v4
337337
with:
338-
node-version: '22'
338+
node-version: '24'
339339

340340
- name: Install Playwright
341341
run: |

.github/workflows/pre-commit.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ jobs:
2727
uses: psf/black@stable
2828
- uses: actions/setup-node@v4
2929
with:
30-
node-version: 22
30+
node-version: 24
3131
cache: "npm"
3232
- uses: actions/setup-java@v4
3333
with:

.github/workflows/visual-diff.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ jobs:
107107
- name: Setup Node.js
108108
uses: actions/setup-node@v4
109109
with:
110-
node-version: '22'
110+
node-version: '24'
111111

112112
- name: Install Playwright
113113
run: |

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -573,7 +573,7 @@ You can use the OWASP Dependency-checker by calling `mvn dependency-check:aggreg
573573

574574
### Get the project started in IntelliJ IDEA
575575

576-
Requirements: make sure you have the following tools installed: [Docker](https://www.docker.com/products/docker-desktop/), [Java23 JDK](https://jdk.java.net/23/), [NodeJS 22 (LTS)](https://nodejs.org/en/download/current) and [IntelliJ IDEA](https://www.jetbrains.com/idea/download).
576+
Requirements: make sure you have the following tools installed: [Docker](https://www.docker.com/products/docker-desktop/), [Java23 JDK](https://jdk.java.net/23/), [NodeJS 24](https://nodejs.org/en/download/current) and [IntelliJ IDEA](https://www.jetbrains.com/idea/download).
577577

578578
1. Fork and clone the project as described in the [documentation](https://github.com/OWASP/wrongsecrets/blob/master/CONTRIBUTING.md).
579579
2. Import the project in IntelliJ (e.g. import as mvn project / local sources)

js/package-lock.json

Lines changed: 5 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

js/package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@
33
"version": "1.3.1",
44
"description": "Examples with how to not use secrets",
55
"main": "index.js",
6+
"engines": {
7+
"node": ">=20.0.0"
8+
},
69
"scripts": {
710
"build": "./node_modules/.bin/javascript-obfuscator index.js --output ../target/classes/static/js/index.js"
811
},

package-lock.json

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
11
{
2+
"engines": {
3+
"node": ">=20.0.0"
4+
},
25
"devDependencies": {
36
"@babel/eslint-parser": "^7.25.9",
47
"@babel/preset-env": "^7.26.0",

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -490,7 +490,7 @@
490490
</goals>
491491
<phase>generate-resources</phase>
492492
<configuration>
493-
<nodeVersion>v22.17.1</nodeVersion>
493+
<nodeVersion>v24.5.0</nodeVersion>
494494
<!-- download node from https://nodejs.org/dist/ -->
495495
<workingDirectory>js</workingDirectory>
496496
</configuration>

src/test/K8s-tests/package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
11
{
2+
"engines": {
3+
"node": ">=20.0.0"
4+
},
25
"scripts": {
36
"test": "echo \"Error: no test specified\" && exit 1"
47
},

0 commit comments

Comments
 (0)