Use Java 23 getFirst() and getLast() methods everywhere instead of .get(0) and .get(size()-1)

Co-authored-by: commjoen <[email protected]>

Author: Copilot

src/main/java/org/owasp/wrongsecrets/Challenges.java

@@ -96,11 +96,11 @@ public List<Difficulty> difficulties() {
   }
 
   public boolean isFirstChallenge(ChallengeDefinition challengeDefinition) {
-    return challengeDefinition.equals(definitions.challenges().get(0));
+    return challengeDefinition.equals(definitions.challenges().getFirst());
   }
 
   public boolean isLastChallenge(ChallengeDefinition challengeDefinition) {
-    return challengeDefinition.equals(definitions.challenges().get(definitions.challenges().size() - 1));
+    return challengeDefinition.equals(definitions.challenges().getLast());
   }
 
   public List<ChallengeDefinition> getChallengeDefinitions() {

src/test/java/org/owasp/wrongsecrets/ctftests/ChallengesControllerCTFClientModeTest.java

@@ -36,23 +36,23 @@ class ChallengesControllerCTFClientModeTest {
 
   @Test
   void shouldNotSpoilWhenInCTFMode() throws Exception {
-    var randomChallenge = challenges.getChallengeDefinitions().get(0);
+    var randomChallenge = challenges.getChallengeDefinitions().getFirst();
     mvc.perform(get("/spoil/%s".formatted(randomChallenge.name().shortName())))
         .andExpect(status().isOk())
         .andExpect(content().string(containsString("Spoils are disabled in CTF mode")));
   }
 
   @Test
   void shouldNotSpoilWhenInCTFModeEvenWhenChallengeUnsupported() throws Exception {
-    var firstChallenge = challenges.getChallengeDefinitions().get(0);
+    var firstChallenge = challenges.getChallengeDefinitions().getFirst();
     mvc.perform(get("/spoil/%s".formatted(firstChallenge.name().shortName())))
         .andExpect(status().isOk())
         .andExpect(content().string(containsString("Spoils are disabled in CTF mode")));
   }
 
   @Test
   void challenge0SshouldSShowTheAddressRightAnswersNeedToBeSubmittedTo() throws Exception {
-    var firstChallenge = challenges.getChallengeDefinitions().get(0);
+    var firstChallenge = challenges.getChallengeDefinitions().getFirst();
     mvc.perform(get("/challenge/%s".formatted(firstChallenge.name().shortName())))
         .andExpect(status().isOk())
         .andExpect(content().string(containsString("https://www.google.nl")));

src/test/java/org/owasp/wrongsecrets/ctftests/ChallengesControllerCTFModeWithPresetCloudValuesTest.java

@@ -42,7 +42,7 @@ class ChallengesControllerCTFModeWithPresetCloudValuesTest {
 
   @Test
   void shouldNotSpoilWhenInCTFMode() throws Exception {
-    var firstChallenge = challenges.getChallengeDefinitions().get(0);
+    var firstChallenge = challenges.getChallengeDefinitions().getFirst();
     mvc.perform(get("/spoil/%s".formatted(firstChallenge.name().shortName())))
         .andExpect(status().isOk())
         .andExpect(content().string(containsString("Spoils are disabled in CTF mode")));
@@ -51,7 +51,7 @@ void shouldNotSpoilWhenInCTFMode() throws Exception {
   @Test
   void shouldShowFlagWhenRespondingWithSuccessInCTFModeChallenge9() throws Exception {
     var challenge9Definition = challenges.findByShortName("challenge-9").orElseThrow();
-    var challenge9 = challenges.getChallenge(challenge9Definition).get(0);
+    var challenge9 = challenges.getChallenge(challenge9Definition).getFirst();
     var spoil = challenge9.spoiler().solution();
     mvc.perform(
             post("/challenge/%s".formatted(challenge9Definition.name().shortName()))

src/test/java/org/owasp/wrongsecrets/definitions/NavigationTest.java

@@ -16,7 +16,7 @@ void navigatePreviousWhenOnFirstChallenge() {
     var navigation =
         new Navigator(
             challengeDefinitionsConfiguration.challenges(),
-            challengeDefinitionsConfiguration.challenges().get(0));
+            challengeDefinitionsConfiguration.challenges().getFirst());
 
     assertThat(navigation.previous()).isEmpty();
   }
@@ -26,14 +26,14 @@ void navigateNextWhenOnLastChallenge() {
     var navigation =
         new Navigator(
             challengeDefinitionsConfiguration.challenges(),
-            challengeDefinitionsConfiguration.challenges().get(challengeDefinitionsConfiguration.challenges().size() - 1));
+            challengeDefinitionsConfiguration.challenges().getLast());
 
     assertThat(navigation.next()).isEmpty();
   }
 
   @Test
   void navigatePreviousAndNextOnSecondChallenge() {
-    var first = challengeDefinitionsConfiguration.challenges().get(0);
+    var first = challengeDefinitionsConfiguration.challenges().getFirst();
     var second = challengeDefinitionsConfiguration.challenges().get(1);
     var third = challengeDefinitionsConfiguration.challenges().get(2);