|
1 | | -# [\#129 PR](https://github.com/OWASP/www-project-machine-learning-security-top-10/pull/129) `open`: fix ePUB and WF to push updates to Repo |
| 1 | +# [\#129 PR](https://github.com/OWASP/www-project-machine-learning-security-top-10/pull/129) `open`: fix ePUB Renders. |
2 | 2 |
|
3 | 3 | #### <img src="https://avatars.githubusercontent.com/u/49409979?u=069bd6928cc6b4b478a304e0eb660ad4cb9cb505&v=4" width="50">[msnishanth9001](https://github.com/msnishanth9001) opened issue at [2023-10-20 06:50](https://github.com/OWASP/www-project-machine-learning-security-top-10/pull/129): |
4 | 4 |
|
@@ -41,6 +41,44 @@ The intent is to do both fix mirror and formatting issues. Once the formatting i |
41 | 41 | the following WF PR will publish ePUB and PDF. |
42 | 42 | - https://github.com/mltop10-info/mltop10.info/pull/4 |
43 | 43 |
|
| 44 | +#### <img src="https://avatars.githubusercontent.com/u/49409979?u=069bd6928cc6b4b478a304e0eb660ad4cb9cb505&v=4" width="50">[msnishanth9001](https://github.com/msnishanth9001) commented at [2023-10-30 07:30](https://github.com/OWASP/www-project-machine-learning-security-top-10/pull/129#issuecomment-1784623302): |
| 45 | + |
| 46 | +updated PR to remove WF for mirror. |
| 47 | + |
| 48 | +This fixes ePUB and PDF render only. |
| 49 | + |
| 50 | +#### <img src="https://avatars.githubusercontent.com/u/412800?v=4" width="50">[shsingh](https://github.com/shsingh) commented at [2023-10-31 17:11](https://github.com/OWASP/www-project-machine-learning-security-top-10/pull/129#issuecomment-1787638590): |
| 51 | + |
| 52 | +Hi @msnishanth9001 as your change is only for the _quarto.yml file did you want to add that as a PR to the mltop10-info repo instead? |
| 53 | + |
| 54 | +The _quarto.yml file is not contained under docs/ in this project repository |
| 55 | + |
| 56 | +#### <img src="https://avatars.githubusercontent.com/u/49409979?u=069bd6928cc6b4b478a304e0eb660ad4cb9cb505&v=4" width="50">[msnishanth9001](https://github.com/msnishanth9001) commented at [2023-10-31 17:19](https://github.com/OWASP/www-project-machine-learning-security-top-10/pull/129#issuecomment-1787651198): |
| 57 | + |
| 58 | +was using it to test the renders, forgot to remove. Done now. |
| 59 | + |
| 60 | +#### <img src="https://avatars.githubusercontent.com/u/412800?v=4" width="50">[shsingh](https://github.com/shsingh) commented at [2023-11-05 21:04](https://github.com/OWASP/www-project-machine-learning-security-top-10/pull/129#issuecomment-1793845257): |
| 61 | + |
| 62 | +Hi @msnishanth9001, |
| 63 | + |
| 64 | +The files look like they have gone back to cfc455f7b7cb8cdac19e46d2321090e9085f619c |
| 65 | + |
| 66 | +Will they work properly on both the OWASP site as well as render PDF on https://mltop10.info site? |
| 67 | + |
| 68 | +#### <img src="https://avatars.githubusercontent.com/u/49409979?u=069bd6928cc6b4b478a304e0eb660ad4cb9cb505&v=4" width="50">[msnishanth9001](https://github.com/msnishanth9001) commented at [2023-11-06 14:54](https://github.com/OWASP/www-project-machine-learning-security-top-10/pull/129#issuecomment-1795014821): |
| 69 | + |
| 70 | +> The files look like they have gone back to https://github.com/OWASP/www-project-machine-learning-security-top-10/commit/cfc455f7b7cb8cdac19e46d2321090e9085f619c |
| 71 | +
|
| 72 | +- I have rebased the commit. |
| 73 | + |
| 74 | +> Will they work properly on both the OWASP site as well as render PDF on https://mltop10.info/ site? |
| 75 | +
|
| 76 | +- yes. https://mltop10.info/ site needs this PR integrated. https://github.com/mltop10-info/mltop10.info/pull/6. |
| 77 | +- ePUB file to verify ePUB render available on my fork. > https://github.com/msnishanth9001/mltop10.info/blob/epub-fixes/docs/OWASP-Machine-Learning-Security-Top-10.epub |
| 78 | + |
| 79 | +- for the fix to actually take effect you would have to run > quarto render and upload the new ePUB and PDF files. |
| 80 | +- this WF is to make renders and upload new ePUB and PDF renders every time there is a change in MD files. https://github.com/mltop10-info/mltop10.info/pull/4 |
| 81 | + |
44 | 82 |
|
45 | 83 | ------------------------------------------------------------------------------- |
46 | 84 |
|
|
0 commit comments