feat: backup postgres databases owned by a specific user if PGDATABASE is not set and pg_dump is being used

Author: anantha1999

mariadb-logical-backup/Dockerfile

@@ -3,6 +3,8 @@ LABEL maintainer="Anantharam R U anantharam@obmondo.com"
 
 SHELL ["/bin/bash", "-o", "pipefail", "-c"]
 
+ARG PIP_VERSION="24.0"
+
 RUN apt-get update     \
     && apt-get install --no-install-recommends -y \
         apt-utils \
@@ -17,7 +19,7 @@ RUN apt-get update     \
         gcc \
         libffi-dev \
     && curl -sL https://aka.ms/InstallAzureCLIDeb | bash \
-    && pip3 install --upgrade pip \
+    && pip3 install --no-cache-dir pip=="${PIP_VERSION}" \
     && pip3 install --no-cache-dir awscli --upgrade \
     && pip3 install --no-cache-dir gsutil --upgrade \
     && apt-get update \

postgres-logical-backup/Dockerfile

@@ -17,7 +17,7 @@ RUN apt-get update     \
         gcc \
         libffi-dev \
     && curl -sL https://aka.ms/InstallAzureCLIDeb | bash \
-    && pip3 install --upgrade pip \
+    && pip3 install --no-cache-dir pip=="${PIP_VERSION}" \
     && pip3 install --no-cache-dir awscli --upgrade \
     && pip3 install --no-cache-dir gsutil --upgrade \
     && echo "deb http://apt.postgresql.org/pub/repos/apt/ $(lsb_release -cs)-pgdg main" > /etc/apt/sources.list.d/pgdg.list \

postgres-logical-backup/dump.sh

@@ -7,6 +7,7 @@ IFS=$'\n\t'
 # PGHOST PGPASSWORD
 
 ALL_DB_SIZE_QUERY="select sum(pg_database_size(datname)::numeric) from pg_database;"
+
 PG_BIN=/usr/lib/postgresql/$PG_VERSION/bin
 DUMP_SIZE_COEFF=5
 ERRORCOUNT=0
@@ -23,9 +24,9 @@ function dump {
   echo "Taking dump from ${PGHOST} using ${USE_PG_DUMP:-pg_dumpall}"
 
   if [[ "${USE_PG_DUMP:-}" == "true" ]]; then
-    "$PG_BIN"/pg_dump
+    "$PG_BIN"/pg_dump --verbose
   else
-    "$PG_BIN"/pg_dumpall --exclude-database='postgres'
+    "$PG_BIN"/pg_dumpall --exclude-database='postgres' --verbose
   fi
 }
 
@@ -105,7 +106,7 @@ function aws_upload {
   [[ ! -z "${LOGICAL_BACKUP_S3_REGION}" ]] && args+=("--region=${LOGICAL_BACKUP_S3_REGION}")
 
   echo "Uploading dump to s3"
-  aws s3 cp - "$PATH_TO_BACKUP" "${args[@]//\'/}"
+  aws s3 cp - "$PATH_TO_BACKUP" "${args[@]}"
 }
 
 function gcs_upload {
@@ -130,6 +131,18 @@ if [ "$LOGICAL_BACKUP_PROVIDER" == "az" ]; then
   dump | compress > /tmp/azure-backup.sql.gz
   az_upload /tmp/azure-backup.sql.gz
 else
+
+  # Backup all the databases owned by the user if PGDATABASE is not set
+  if [[ "${USE_PG_DUMP:-}" == "true" ]] && [[ -z "${PGDATABASE:-}" ]]; then
+    GET_DATABASE_LIST_FOR_USER_QUERY="SELECT datname FROM pg_database WHERE datistemplate = false AND  datname = '$PGUSER';"
+    DATABASES=$(psql -U postgres -tqAc $GET_DATABASE_LIST_FOR_USER_QUERY)
+    for DB in $DATABASES; do
+      echo "Backing up $DB"
+      # We set PGDATABASE locally for each run
+      PGDATABASE=$DB dump | compress | upload
+    done
+  fi
+
   dump | compress | upload
   [[ ${PIPESTATUS[0]} != 0 || ${PIPESTATUS[1]} != 0 || ${PIPESTATUS[2]} != 0 ]] && (( ERRORCOUNT += 1 ))
   set +x