go back to histogram

Author: DiogoSantoss

app/sse/listener.go

@@ -313,7 +313,7 @@ func (p *listener) recordBlockProcessingTime(slot uint64, addr string, headTimes
 
 	processingTime := headTimestamp.Sub(gossipTime)
 	if processingTime > 0 {
-		sseBlockProcessingTimeGauge.WithLabelValues(addr).Set(processingTime.Seconds())
+		sseBlockProcessingTimeHistogram.WithLabelValues(addr).Observe(processingTime.Seconds())
 	}
 
 	// Clean up this entry as it's no longer needed

app/sse/metrics.go

@@ -48,10 +48,11 @@ var (
 		Buckets:   []float64{0.5, 1, 1.5, 2, 2.5, 3, 3.5, 4, 4.5, 5, 6, 8, 10, 12},
 	}, []string{"addr"})
 
-	sseBlockProcessingTimeGauge = promauto.NewGaugeVec(prometheus.GaugeOpts{
+	sseBlockProcessingTimeHistogram = promauto.NewHistogramVec(prometheus.HistogramOpts{
 		Namespace: "app",
 		Subsystem: "beacon_node",
 		Name:      "sse_block_processing_time",
-		Help:      "Most recent block processing time in seconds (time between block gossip and head events). Lower values indicate better CPU/disk/RAM performance.",
+		Help:      "Time in seconds between block gossip and head events, indicating block processing time. Lower values indicate better CPU/disk/RAM performance.",
+		Buckets:   []float64{0.01, 0.05, 0.1, 0.2, 0.5, 1, 2, 4},
 	}, []string{"addr"})
 )

docs/metrics.md

@@ -16,7 +16,7 @@ when storing metrics from multiple nodes or clusters in one Prometheus instance.
 | `app_beacon_node_peers` | Gauge | Gauge set to the peer count of the upstream beacon node |  |
 | `app_beacon_node_sse_block` | Histogram | Block imported into fork choice delay, supplied by beacon node`s SSE endpoint. Values between 0s and 4s for Ethereum mainnet are considered safe | `addr` |
 | `app_beacon_node_sse_block_gossip` | Histogram | Block reception via gossip delay, supplied by beacon node`s SSE endpoint. Values between 0s and 4s for Ethereum mainnet are considered safe | `addr` |
-| `app_beacon_node_sse_block_processing_time` | Gauge | Most recent block processing time in seconds (time between block gossip and head events). Lower values indicate better CPU/disk/RAM performance. | `addr` |
+| `app_beacon_node_sse_block_processing_time` | Histogram | Time in seconds between block gossip and head events, indicating block processing time. Lower values indicate better CPU/disk/RAM performance. | `addr` |
 | `app_beacon_node_sse_chain_reorg_depth` | Histogram | Chain reorg depth, supplied by beacon node`s SSE endpoint | `addr` |
 | `app_beacon_node_sse_head_delay` | Histogram | Delay in seconds between slot start and head update, supplied by beacon node`s SSE endpoint. Values between 8s and 12s for Ethereum mainnet are considered safe. | `addr` |
 | `app_beacon_node_sse_head_slot` | Gauge | Current beacon node head slot, supplied by beacon node`s SSE endpoint | `addr` |