Linting

Author: KaloyanTanev

cmd/dkg.go

@@ -29,6 +29,7 @@ this command at the same time.`,
 			if len(config.Nickname) > 32 {
 				return errors.New("--nickname exceeds 32 character limit")
 			}
+
 			return nil
 		},
 		RunE: func(cmd *cobra.Command, args []string) error { //nolint:revive // keep args variable name for clarity

dkg/pedersen/reshare.go

@@ -29,10 +29,8 @@ func RunReshareDKG(ctx context.Context, config *Config, board *Board, shares []s
 
 	// Validate that AddedPeers and RemovedPeers are disjoint sets
 	for _, addedPeer := range config.Reshare.AddedPeers {
-		for _, removedPeer := range config.Reshare.RemovedPeers {
-			if addedPeer == removedPeer {
-				return nil, errors.New("peer cannot be both added and removed", z.Any("peer_id", addedPeer))
-			}
+		if slices.Contains(config.Reshare.RemovedPeers, addedPeer) {
+			return nil, errors.New("peer cannot be both added and removed", z.Any("peer_id", addedPeer))
 		}
 	}
 
@@ -126,6 +124,7 @@ func RunReshareDKG(ctx context.Context, config *Config, board *Board, shares []s
 		for _, removedPeerID := range config.Reshare.RemovedPeers {
 			if idx, ok := config.PeerMap[removedPeerID]; ok && idx.PeerIdx == int(node.Index) {
 				isRemoving = true
+
 				if idx.PeerIdx == thisNodeIndex {
 					thisIsRemovedNode = true
 				}
@@ -138,6 +137,7 @@ func RunReshareDKG(ctx context.Context, config *Config, board *Board, shares []s
 		for _, addedPeerID := range config.Reshare.AddedPeers {
 			if idx, ok := config.PeerMap[addedPeerID]; ok && idx.PeerIdx == int(node.Index) {
 				isNewlyAdded = true
+
 				if idx.PeerIdx == thisNodeIndex {
 					thisIsAddedNode = true
 				}

dkg/sync/sync_test.go

@@ -24,6 +24,7 @@ import (
 func TestSyncProtocol(t *testing.T) {
 	versions := make(map[int]version.SemVer)
 	nicknames := make(map[int]string)
+
 	for i := range 5 {
 		versions[i] = version.Version
 		nicknames[i] = fmt.Sprintf("node%d", i)