deps: fix some struct field names in comment #4213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: oncecelll <[email protected]>
|
KaloyanTanev
approved these changes
Jan 9, 2026
KaloyanTanev
added
the
merge when ready
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4213 +/- ##
==========================================
- Coverage 56.96% 56.94% -0.02%
==========================================
Files 237 237
Lines 30622 30622
==========================================
- Hits 17445 17439 -6
- Misses 10945 10955 +10
+ Partials 2232 2228 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
It seems that the CI failure is unrelated to this change Module: github.com/quic-go/quic-go
Found in: github.com/quic-go/[email protected]
Fixed in: github.com/quic-go/[email protected]
Example traces found:
#1: for function github.com/quic-go/quic-go/http3.ConfigureTLSConfig
httpServeHook.Call @ github.com/obolnetwork/charon/app/app.go:1130:10
Server.ListenAndServe @ stdlib/src/net/http/server.go:3389:16
Server.Serve @ stdlib/src/net/http/server.go:3493:3
conn.serve @ stdlib/src/net/http/server.go:1967:37
Conn.HandshakeContext @ stdlib/src/crypto/tls/conn.go:1515:27
Conn.handshakeContext @ stdlib/src/crypto/tls/conn.go:1575:32
Conn.serverHandshake @ stdlib/src/crypto/tls/handshake_server.go:43:44
Conn.readClientHello @ stdlib/src/crypto/tls/handshake_server.go:169:56
ConfigureTLSConfig @ github.com/quic-go/quic-go/http3/server.go:62:29
ConfigureTLSConfig @ github.com/quic-go/quic-go/http3/server.go:50:6
It should be necessary to upgrade the corresponding dependencies |
KaloyanTanev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix some struct field names in comment
category: docs
ticket: none