feat(core): do not implement Number

Author: ObserverOfTime

kbigint/src/androidMain/kotlin/io/github/observeroftime/kbigint/KBigInt.kt

@@ -6,7 +6,7 @@ import android.annotation.TargetApi
 import android.os.Build.VERSION_CODES
 import java.math.BigInteger
 
-actual class KBigInt private constructor(private var value: BigInteger) : Comparable<KBigInt>, Number() {
+actual class KBigInt private constructor(private var value: BigInteger) : Comparable<KBigInt> {
     actual constructor(number: String) : this(BigInteger(number))
 
     actual constructor(number: Int) : this(number.toBigInteger())
@@ -93,17 +93,26 @@ actual class KBigInt private constructor(private var value: BigInteger) : Compar
 
     actual override fun toString() = value.toString()
 
-    override fun toByte() = value.toByte()
-
-    override fun toDouble() = value.toDouble()
-
-    override fun toFloat() = value.toFloat()
-
-    override fun toInt() = value.toInt()
+    /**
+     * Convert the value to an [Int].
+     *
+     * @see [BigInteger.toInt]
+     */
+    fun toInt() = value.toInt()
 
-    override fun toLong() = value.toLong()
+    /**
+     * Convert the value to a [Long].
+     *
+     * @see [BigInteger.toLong]
+     */
+    fun toLong() = value.toLong()
 
-    override fun toShort() = value.toShort()
+    /**
+     * Convert the value to a [Double].
+     *
+     * @see [BigInteger.toDouble]
+     */
+    fun toDouble() = value.toDouble()
 
     /** Convert the value to a [ByteArray]. */
     @Suppress("unused")

kbigint/src/androidUnitTest/kotlin/io/github/observeroftime/kbigint/KBigIntTest.kt

@@ -96,12 +96,9 @@ actual class KBigIntTest {
     }
 
     @Test
-    actual fun testToNumber() {
-        assertEquals(OVER_MAX_INT.toByte(), long.toByte())
-        assertEquals(OVER_MAX_INT.toDouble(), long.toDouble())
-        assertEquals(OVER_MAX_INT.toFloat(), long.toFloat())
+    fun testToNumber() {
         assertEquals(OVER_MAX_INT.toInt(), long.toInt())
         assertEquals(OVER_MAX_INT, long.toLong())
-        assertEquals(OVER_MAX_INT.toShort(), long.toShort())
+        assertEquals(OVER_MAX_INT.toDouble(), long.toDouble())
     }
 }

kbigint/src/commonTest/kotlin/io/github/observeroftime/kbigint/KBigIntTest.kt

@@ -18,5 +18,4 @@ expect class KBigIntTest {
     fun testEquals()
     fun testHashCode()
     fun testToString()
-    fun testToNumber()
 }

kbigint/src/jsMain/kotlin/io/github/observeroftime/kbigint/KBigInt.kt

@@ -3,9 +3,7 @@ package io.github.observeroftime.kbigint
 @JsExport
 @Suppress("UNUSED_VARIABLE")
 @OptIn(ExperimentalStdlibApi::class, ExperimentalJsExport::class)
-actual class KBigInt private constructor(
-    @JsExternalArgument private var value: BigInt
-) : Comparable<KBigInt>, Number() {
+actual class KBigInt private constructor(@JsExternalArgument private var value: BigInt) : Comparable<KBigInt> {
     @JsName("fromString")
     actual constructor(number: String) : this(BigInt(number))
 
@@ -140,38 +138,15 @@ actual class KBigInt private constructor(
 
     actual override fun hashCode() = toString().hashCode()
 
-    /**
-     * Convert the value to a [Byte].
-     *
-     * @throws [NumberFormatException] if the value does not fit in [Byte]
-     */
-    override fun toByte() = toString().toByte()
-
-    override fun toDouble() = toString().toDouble()
-
-    override fun toFloat() = toString().toFloat()
-
     /**
      * Convert the value to an [Int].
      *
      * @throws [NumberFormatException] if the value does not fit in [Int]
      */
-    override fun toInt() = toString().toInt()
+    fun toInt() = toString().toInt()
 
-    /**
-     * Convert the value to a [Long].
-     *
-     * @throws [NumberFormatException] if the value does not fit in [Long]
-     */
-    @Suppress("NON_EXPORTABLE_TYPE")
-    override fun toLong() = toString().toLong()
-
-    /**
-     * Convert the value to a [Short].
-     *
-     * @throws [NumberFormatException] if the value does not fit in [Short]
-     */
-    override fun toShort() = toString().toShort()
+    /** Convert the value to a [Double]. */
+    fun toDouble() = toString().toDouble()
 
     actual override fun toString() = value.toString()
 }

kbigint/src/jsTest/kotlin/io/github/observeroftime/kbigint/KBigIntTest.kt

@@ -99,13 +99,8 @@ actual class KBigIntTest {
     }
 
     @Test
-    actual fun testToNumber() {
-        assertFailsWith(NumberFormatException::class) { long.toByte() }
-        assertFailsWith(NumberFormatException::class) { long.toShort() }
+    fun testToNumber() {
         assertFailsWith(NumberFormatException::class) { long.toInt() }
-
         assertEquals(OVER_MAX_INT.toDouble(), long.toDouble())
-        assertEquals(OVER_MAX_INT.toFloat(), long.toFloat())
-        assertEquals(OVER_MAX_INT, long.toLong())
     }
 }

kbigint/src/jvmMain/kotlin/io/github/observeroftime/kbigint/KBigInt.kt

@@ -4,7 +4,7 @@ package io.github.observeroftime.kbigint
 
 import java.math.BigInteger
 
-actual class KBigInt private constructor(private var value: BigInteger) : Comparable<KBigInt>, Number() {
+actual class KBigInt private constructor(private var value: BigInteger) : Comparable<KBigInt> {
     actual constructor(number: String) : this(BigInteger(number))
 
     actual constructor(number: Int) : this(number.toBigInteger())
@@ -88,27 +88,14 @@ actual class KBigInt private constructor(private var value: BigInteger) : Compar
 
     actual override fun toString() = value.toString()
 
-    /**
-     * Convert the value to a [Byte].
-     *
-     * @throws [ArithmeticException] if the value does not fit in [Byte]
-     * @see [BigInteger.byteValueExact]
-     */
-    @Throws(ArithmeticException::class)
-    override fun toByte() = value.byteValueExact()
-
-    override fun toDouble() = value.toDouble()
-
-    override fun toFloat() = value.toFloat()
-
     /**
      * Convert the value to an [Int].
      *
      * @throws [ArithmeticException] if the value does not fit in [Int]
      * @see [BigInteger.intValueExact]
      */
     @Throws(ArithmeticException::class)
-    override fun toInt() = value.intValueExact()
+    fun toInt() = value.intValueExact()
 
     /**
      * Convert the value to a [Long].
@@ -117,16 +104,14 @@ actual class KBigInt private constructor(private var value: BigInteger) : Compar
      * @see [BigInteger.longValueExact]
      */
     @Throws(ArithmeticException::class)
-    override fun toLong() = value.longValueExact()
+    fun toLong() = value.longValueExact()
 
     /**
-     * Convert the value to a [Short].
+     * Convert the value to a [Double].
      *
-     * @throws [ArithmeticException] if the value does not fit in [Short]
-     * @see [BigInteger.shortValueExact]
+     * @see [BigInteger.toDouble]
      */
-    @Throws(ArithmeticException::class)
-    override fun toShort() = value.shortValueExact()
+    fun toDouble() = value.toDouble()
 
     /**
      * Convert the value to a [ByteArray].

kbigint/src/jvmTest/kotlin/io/github/observeroftime/kbigint/KBigIntTest.kt

@@ -96,13 +96,9 @@ actual class KBigIntTest {
     }
 
     @Test
-    actual fun testToNumber() {
-        assertFailsWith(ArithmeticException::class) { long.toByte() }
-        assertFailsWith(ArithmeticException::class) { long.toShort() }
+    fun testToNumber() {
         assertFailsWith(ArithmeticException::class) { long.toInt() }
-
-        assertEquals(OVER_MAX_INT.toDouble(), long.toDouble())
-        assertEquals(OVER_MAX_INT.toFloat(), long.toFloat())
         assertEquals(OVER_MAX_INT, long.toLong())
+        assertEquals(OVER_MAX_INT.toDouble(), long.toDouble())
     }
 }

kbigint/src/nativeInterop/cinterop/tommath.def

@@ -58,15 +58,3 @@ static inline int kbi_mp_sign(mp_int *a) {
 static inline mp_err kbi_mp_pow(mp_int *a, int n, mp_int *b) {
     return n == 2 ? mp_sqr(a, b) : mp_expt_n(a, n, b);
 }
-
-static inline char kbi_mp_get_byte(mp_int *a) {
-    return (char) mp_get_i32(a);
-}
-
-static inline short kbi_mp_get_short(mp_int *a) {
-    return (short) mp_get_i32(a);
-}
-
-static inline float kbi_mp_get_float(mp_int *a) {
-    return (float) mp_get_double(a);
-}

kbigint/src/nativeMain/kotlin/io/github/observeroftime/kbigint/KBigInt.kt

@@ -8,7 +8,7 @@ import net.libtom.libtommath.*
 
 @ObjCName("KBigInt")
 @OptIn(ExperimentalForeignApi::class, ExperimentalObjCName::class)
-actual class KBigInt private constructor(private var value: mp_int) : Comparable<KBigInt>, Number() {
+actual class KBigInt private constructor(private var value: mp_int) : Comparable<KBigInt> {
     private constructor() : this(nativeHeap.alloc<mp_int>())
 
     @Suppress("unused")
@@ -346,17 +346,14 @@ actual class KBigInt private constructor(private var value: mp_int) : Comparable
         return string
     }
 
-    override fun toByte() = kbi_mp_get_byte(value.ptr)
+    /** Convert the value to an [Int]. */
+    fun toInt() = mp_get_i32(value.ptr)
 
-    override fun toDouble() = mp_get_double(value.ptr)
+    /** Convert the value to a [Long]. */
+    fun toLong() = mp_get_i64(value.ptr)
 
-    override fun toFloat() = kbi_mp_get_float(value.ptr)
-
-    override fun toInt() = mp_get_i32(value.ptr)
-
-    override fun toLong() = mp_get_i64(value.ptr)
-
-    override fun toShort() = kbi_mp_get_short(value.ptr)
+    /** Convert the value to a [Double]. */
+    fun toDouble() = mp_get_double(value.ptr)
 
     private inline fun dispose(value: mp_int) {
         mp_clear(value.ptr)

kbigint/src/nativeTest/kotlin/io/github/observeroftime/kbigint/KBigIntTest.kt

@@ -112,12 +112,9 @@ actual class KBigIntTest {
     }
 
     @Test
-    actual fun testToNumber() {
-        assertEquals(OVER_MAX_INT.toByte(), long.toByte())
-        assertEquals(OVER_MAX_INT.toDouble(), long.toDouble())
-        assertEquals(OVER_MAX_INT.toFloat(), long.toFloat())
+    fun testToNumber() {
         assertEquals(OVER_MAX_INT.toInt(), long.toInt())
         assertEquals(OVER_MAX_INT, long.toLong())
-        assertEquals(OVER_MAX_INT.toShort(), long.toShort())
+        assertEquals(OVER_MAX_INT.toDouble(), long.toDouble())
     }
 }