Skip to content

Commit 0e01e28

Browse files
bosdbosd
authored andcommitted
Fix: Make separator default consistent across application
- Changed default separator in sort_for_self_referencing() from ',' to ';' - This matches the application-wide default used in preflight.py - Eliminates inconsistency between function default and call site default - Updated tests to explicitly pass ',' separator where needed for test data - Addresses review comment about inconsistent defaults for the same parameter This change improves consistency and maintainability by ensuring the same default separator is used throughout the application.
1 parent 2300d52 commit 0e01e28

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/odoo_data_flow/lib/sort.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ def sort_for_self_referencing(
1414
id_column: str,
1515
parent_column: str,
1616
encoding: str = "utf-8",
17-
separator: str = ",",
17+
separator: str = ";",
1818
) -> Optional[Union[str, bool]]:
1919
"""Sorts a CSV file for self-referencing hierarchies.
2020

0 commit comments

Comments
 (0)