test(module): Add test coverage for version-aware language installer

Added unit tests to cover the new, version-specific logic for Odoo 15+ and Odoo 18+ in the language installer. This resolves the low test coverage reported by Codecov.

- Created `tests/test_odoo_lib.py` to test the generic `get_odoo_version` function, including success and failure cases.
- Added new tests in `tests/test_language_installer.py` to validate the installation paths for Odoo 18+ (direct activation) and Odoo 15-17 (wizard-based).
- Added tests for warning conditions, such as when languages are already active.

Author: bosd

src/odoo_data_flow/lib/actions/language_installer.py

@@ -49,11 +49,9 @@ def _install_languages_legacy(
         try:
             log.info(f"Installing language: {lang_code}")
             wizard_id = wizard_obj.create({"lang": lang_code})
-            # In legacy versions, the method is called on the model proxy with the ID.
             wizard_obj.lang_install([wizard_id])
             log.info(f"Triggered installation for '{lang_code}'.")
         except Exception as e:
-            # Log the error for the specific language but continue with others.
             log.error(f"Failed to install language '{lang_code}': {e}")
 
 
@@ -71,6 +69,9 @@ def run_language_installation(config: str, languages: list[str]) -> None:
         # New logic for Odoo 18 and newer
         if odoo_version >= 18:
             _install_languages_v18_plus(connection, languages)
+            log.info("Language installation process triggered successfully.")
+            log.info("--- Language Installation Finished ---")
+            return
 
         # Logic for Odoo 15, 16, 17
         elif odoo_version >= 15:

tests/test_language_installer.py

@@ -2,6 +2,8 @@
 
 from unittest.mock import MagicMock, call, patch
 
+import pytest
+
 from odoo_data_flow.lib.actions.language_installer import (
     run_language_installation,
 )
@@ -100,3 +102,107 @@ def test_run_language_installation_api_error(
     logged_message = mock_log_error.call_args[0][0]
     assert "Failed to install language 'en_US'" in logged_message
     assert "Odoo API Error" in logged_message
+
+
+@patch("odoo_data_flow.lib.actions.language_installer.odoo_lib.get_odoo_version")
+@patch(
+    "odoo_data_flow.lib.actions.language_installer.conf_lib.get_connection_from_config"
+)
+def test_run_installation_v18_success(
+    mock_get_connection: MagicMock, mock_get_odoo_version: MagicMock
+) -> None:
+    """Tests the successful installation path for Odoo 18+."""
+    # 1. Setup
+    mock_get_odoo_version.return_value = 18
+    mock_lang_model = MagicMock()
+    mock_lang_model.search.return_value = [101, 102]  # Dummy DB IDs
+
+    mock_connection = MagicMock()
+    mock_connection.get_model.return_value = mock_lang_model
+    mock_get_connection.return_value = mock_connection
+
+    # 2. Action
+    run_language_installation(config="dummy.conf", languages=["de_DE", "es_ES"])
+
+    # 3. Assert
+    mock_connection.get_model.assert_called_once_with("res.lang")
+    mock_lang_model.search.assert_called_once_with(
+        [("code", "in", ["de_DE", "es_ES"]), ("active", "=", False)]
+    )
+    mock_lang_model.write.assert_called_once_with([101, 102], {"active": True})
+
+
+@pytest.mark.parametrize("version", [15, 16, 17])
+@patch("odoo_data_flow.lib.actions.language_installer.odoo_lib.get_odoo_version")
+@patch(
+    "odoo_data_flow.lib.actions.language_installer.conf_lib.get_connection_from_config"
+)
+def test_run_installation_v15_to_v17_success(
+    mock_get_connection: MagicMock,
+    mock_get_odoo_version: MagicMock,
+    version: int,
+) -> None:
+    """Tests the successful installation path for Odoo 15, 16, and 17."""
+    # 1. Setup
+    mock_get_odoo_version.return_value = version
+
+    # Define separate mocks for each model we'll interact with
+    mock_lang_model = MagicMock()
+    mock_lang_model.search.return_value = [101, 102]
+
+    mock_wizard_obj = MagicMock()
+    mock_wizard_obj.create.return_value = 42
+
+    mock_connection = MagicMock()
+
+    def get_model_side_effect(model_name: str) -> MagicMock:
+        if model_name == "res.lang":
+            return mock_lang_model
+        if model_name == "base.language.install":
+            return mock_wizard_obj
+        # Return a default mock for any other unexpected calls
+        return MagicMock()
+
+    mock_connection.get_model.side_effect = get_model_side_effect
+    mock_get_connection.return_value = mock_connection
+
+    # 2. Action
+    run_language_installation(config="dummy.conf", languages=["de_DE", "es_ES"])
+
+    # 3. Assertions
+    # Check that the correct search was performed on the lang model
+    mock_lang_model.search.assert_called_once_with([("code", "in", ["de_DE", "es_ES"])])
+
+    # Check that the wizard was created with the correct IDs from the search
+    mock_wizard_obj.create.assert_called_once_with({"langs": [(6, 0, [101, 102])]})
+
+    # Check that the installation method was executed on the created wizard
+    mock_wizard_obj.browse(42).lang_install.assert_called_once()
+
+
+@patch("odoo_data_flow.lib.actions.language_installer.log.warning")
+@patch("odoo_data_flow.lib.actions.language_installer.odoo_lib.get_odoo_version")
+@patch(
+    "odoo_data_flow.lib.actions.language_installer.conf_lib.get_connection_from_config"
+)
+def test_run_installation_v18_already_active(
+    mock_get_connection: MagicMock,
+    mock_get_odoo_version: MagicMock,
+    mock_log_warning: MagicMock,
+) -> None:
+    """Tests the warning log when languages are already active in Odoo 18."""
+    # 1. Setup
+    mock_get_odoo_version.return_value = 18
+    mock_lang_model = MagicMock()
+    mock_lang_model.search.return_value = []  # Simulate no inactive languages found
+
+    mock_connection = MagicMock()
+    mock_connection.get_model.return_value = mock_lang_model
+    mock_get_connection.return_value = mock_connection
+
+    # 2. Action
+    run_language_installation(config="dummy.conf", languages=["de_DE"])
+
+    # 3. Assert
+    mock_log_warning.assert_called_once()
+    assert "already active or do not exist" in mock_log_warning.call_args[0][0]

tests/test_odoo_lib.py

@@ -0,0 +1,39 @@
+"""This tests the common, reusable functions for interacting with Odoo."""
+
+from unittest.mock import MagicMock, patch
+
+from odoo_data_flow.lib.odoo_lib import get_odoo_version
+
+
+def test_get_odoo_version_success() -> None:
+    """Tests successful detection of an Odoo version."""
+    # 1. Setup
+    mock_connection = MagicMock()
+    mock_ir_module = MagicMock()
+    mock_ir_module.search_read.return_value = [{"latest_version": "17.0.1.0.0"}]
+    mock_connection.get_model.return_value = mock_ir_module
+
+    # 2. Action
+    version = get_odoo_version(mock_connection)
+
+    # 3. Assert
+    assert version == 17
+    mock_connection.get_model.assert_called_once_with("ir.module.module")
+
+
+@patch("odoo_data_flow.lib.odoo_lib.log.warning")
+def test_get_odoo_version_failure_on_exception(
+    mock_log_warning: MagicMock,
+) -> None:
+    """Tests fallback behavior when version detection raises an exception."""
+    # 1. Setup
+    mock_connection = MagicMock()
+    mock_connection.get_model.side_effect = Exception("Connection Error")
+
+    # 2. Action
+    version = get_odoo_version(mock_connection)
+
+    # 3. Assert
+    assert version == 14  # Should return the fallback value
+    mock_log_warning.assert_called_once()
+    assert "Could not detect Odoo version" in mock_log_warning.call_args[0][0]