Fix import location for _show_warning_panel to comply with PEP 8

- Move local import of _show_warning_panel to module level for consistency
- Update mock fixture to patch at correct location (preflight module instead of ui module)
- Maintain all existing functionality while following Python best practices
- All tests continue to pass (376/376)

Author: bosd

src/odoo_data_flow/lib/preflight.py

@@ -17,7 +17,7 @@
 from ..logging_config import log
 from . import cache, conf_lib, sort
 from .actions import language_installer
-from .internal.ui import _show_error_panel
+from .internal.ui import _show_error_panel, _show_warning_panel
 
 # A registry to hold all pre-flight check functions
 PREFLIGHT_CHECKS: list[Callable[..., bool]] = []
@@ -360,8 +360,6 @@ def _validate_header(
 
     # Warn about readonly fields, especially non-stored ones
     if readonly_fields:
-        from .internal.ui import _show_warning_panel
-
         warning_message = (
             "The following readonly fields will be silently ignored during import:\n"
         )

tests/test_preflight.py

@@ -45,7 +45,7 @@ def mock_cache() -> Generator[MagicMock, None, None]:
 @pytest.fixture
 def mock_show_warning_panel() -> Generator[MagicMock, None, None]:
     """Fixture to mock _show_warning_panel."""
-    with patch("odoo_data_flow.lib.internal.ui._show_warning_panel") as mock_panel:
+    with patch("odoo_data_flow.lib.preflight._show_warning_panel") as mock_panel:
         yield mock_panel