Optimize _handle_create_error to eliminate unnecessary intermediate list creation\n\n- Refactor _handle_create_error to return the failed_line directly instead of wrapping it in a list\n- Remove redundant list() call when creating failed line\n- Update caller to use append() instead of extend() for better performance\n- Eliminate unnecessary intermediate list creation for better efficiency\n- Maintain all existing functionality while improving performance\n\nFixes the inefficiency noted in code review where the function was creating\nan unnecessary intermediate list and the caller was using extend() instead of append().

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>

Author: bosd

src/odoo_data_flow/import_threaded.py

@@ -420,7 +420,7 @@ def _handle_create_error(
     create_error: Exception,
     line: list[Any],
     error_summary: str,
-) -> tuple[str, list[list[Any]], str]:
+) -> tuple[str, list[Any], str]:
     """Handle errors during record creation.
 
     Args:
@@ -430,9 +430,8 @@ def _handle_create_error(
         error_summary: Current error summary
 
     Returns:
-        Tuple of (error_message, failed_lines, error_summary)
+        Tuple of (error_message, failed_line, error_summary)
     """
-    failed_lines = []
     error_str = str(create_error)
     error_str_lower = error_str.lower()
 
@@ -450,9 +449,8 @@ def _handle_create_error(
         if "Fell back to create" in error_summary:
             error_summary = error_message
 
-    failed_line = [*list(line), error_message]
-    failed_lines.append(failed_line)
-    return error_message, failed_lines, error_summary
+    failed_line = [*line, error_message]
+    return error_message, failed_line, error_summary
 
 
 def _create_batch_individually(
@@ -509,15 +507,15 @@ def _create_batch_individually(
             id_map[source_id] = new_record.id
         except IndexError as e:
             error_message = f"Malformed row detected (row {i + 1} in batch): {e}"
-            failed_lines.append([*list(line), error_message])
+            failed_lines.append([*line, error_message])
             if "Fell back to create" in error_summary:
                 error_summary = "Malformed CSV row detected"
             continue
         except Exception as create_error:
-            error_message, new_failed_lines, error_summary = _handle_create_error(
+            error_message, new_failed_line, error_summary = _handle_create_error(
                 i, create_error, line, error_summary
             )
-            failed_lines.extend(new_failed_lines)
+            failed_lines.append(new_failed_line)
     return {
         "id_map": id_map,
         "failed_lines": failed_lines,