intermediate save

Author: bosd

src/odoo_data_flow/lib/preflight.py

@@ -16,6 +16,23 @@
 
 from odoo_data_flow.enums import PreflightMode
 
+__all__ = [
+    "PREFLIGHT_CHECKS",
+    "PreflightMode",
+    "_get_csv_header",
+    "_get_installed_languages",
+    "_get_odoo_fields",
+    "_get_required_languages",
+    "_handle_missing_languages",
+    "_validate_header",
+    "connection_check",
+    "deferral_and_strategy_check",
+    "language_check",
+    "register_check",
+    "self_referencing_check",
+    "type_correction_check",
+]
+
 from ..logging_config import log
 from . import cache, conf_lib, sort
 from .actions import language_installer
@@ -221,6 +238,10 @@ def _handle_missing_languages(
         log.info("--headless mode detected. Auto-confirming language installation.")
         if isinstance(config, dict):
             log.error("Language installation from a dict config is not supported.")
+            _show_error_panel(
+                "Language installation from a dict config is not supported",
+                "Please use a configuration file instead.",
+            )
             return False
         return language_installer.run_language_installation(
             config, list(missing_languages)
@@ -232,6 +253,10 @@ def _handle_missing_languages(
 
     if isinstance(config, dict):
         log.error("Language installation from a dict config is not supported.")
+        _show_error_panel(
+            "Language installation from a dict config is not supported",
+            "Please use a configuration file instead.",
+        )
         return False
     return language_installer.run_language_installation(config, list(missing_languages))
 

tests/test_mapper.py

@@ -3,7 +3,7 @@
 import inspect
 import logging
 import os
-from typing import Any, Callable
+from typing import TYPE_CHECKING, Any, Callable
 from unittest.mock import MagicMock, call, patch
 
 import httpx
@@ -12,6 +12,9 @@
 from odoo_data_flow.lib import mapper
 from odoo_data_flow.lib.internal.exceptions import SkippingError
 
+if TYPE_CHECKING:
+    import pytest_mock
+
 # Import MapperFunc for type hinting in this test file
 from odoo_data_flow.lib.mapper import MapperFunc
 
@@ -70,7 +73,7 @@ def concat_fun(line: LineDict, state: StateDict) -> str:
 
 # --- Pytest Fixtures for Patching ---
 @pytest.fixture(autouse=True)
-def mock_mapper_dependencies(mocker: MagicMock) -> None:
+def mock_mapper_dependencies(mocker: "pytest_mock.MockerFixture") -> None:
     """Fixture to mock external dependencies in mapper.py."""
     mocker.patch("odoo_data_flow.lib.mapper.to_m2o", side_effect=_mock_to_m2o)
     mocker.patch(
@@ -105,7 +108,7 @@ def test_val_postprocess_builtin() -> None:
     assert mapper_func(LINE_SIMPLE, {}) == "a"
 
 
-def test_val_postprocess_fallback(mocker: MagicMock) -> None:
+def test_val_postprocess_fallback(mocker: "pytest_mock.MockerFixture") -> None:
     """Test post process fallback.
 
     Tests the val mapper's fallback from a 2-arg to a 1-arg postprocess call.
@@ -280,7 +283,7 @@ def test_binary_url_map_empty() -> None:
     assert mapper_func(LINE_SIMPLE, {}) == ""
 
 
-def test_binary_url_map_skip_on_not_found(mocker: MagicMock) -> None:
+def test_binary_url_map_skip_on_not_found(mocker: "pytest_mock.MockerFixture") -> None:
     """Tests that binary_url_map raises SkippingError when request fails."""
     mock_httpx_get = mocker.patch("odoo_data_flow.lib.mapper.httpx.get")
     mock_httpx_get.side_effect = httpx.RequestError(
@@ -292,7 +295,7 @@ def test_binary_url_map_skip_on_not_found(mocker: MagicMock) -> None:
         mapper_func(LINE_SIMPLE, {})
 
 
-def test_binary_url_map_request_exception(mocker: MagicMock) -> None:
+def test_binary_url_map_request_exception(mocker: "pytest_mock.MockerFixture") -> None:
     """Tests that a warning is logged when a URL request fails and skip=False."""
     mock_httpx_get = mocker.patch("odoo_data_flow.lib.mapper.httpx.get")
     mock_log_warning = mocker.patch("odoo_data_flow.lib.mapper.log.warning")
@@ -451,7 +454,7 @@ def test_map_val_m2m_with_non_string_key() -> None:
     assert mapper_func({}, {}) == "One"
 
 
-def test_binary_with_path_prefix(mocker: MagicMock) -> None:
+def test_binary_with_path_prefix(mocker: "pytest_mock.MockerFixture") -> None:
     """Tests the binary mapper with a path_prefix."""
     mock_open = mocker.patch(
         "builtins.open", mocker.mock_open(read_data=b"file_content")
@@ -470,7 +473,7 @@ def test_m2o_att_name() -> None:
     assert result == {"att1": "prefix.att1", "att3": "prefix.att3"}
 
 
-def test_m2o_fun_state_present_but_unused(mocker: MagicMock) -> None:
+def test_m2o_fun_state_present_but_unused(mocker: "pytest_mock.MockerFixture") -> None:
     """Confirms m2o_fun works correctly when 'state' is provided but not directly used.
 
     Args:
@@ -497,7 +500,7 @@ def test_m2o_fun_state_present_but_unused(mocker: MagicMock) -> None:
 
 
 def test_m2o_fun_with_skip_and_empty_value_state_unused(
-    mocker: MagicMock,
+    mocker: "pytest_mock.MockerFixture",
 ) -> None:
     """Tests m2o_fun with 'skip' when value is empty, confirming state is unused.
 
@@ -525,7 +528,9 @@ def test_m2o_fun_with_skip_and_empty_value_state_unused(
     assert state == {"initial": "value"}
 
 
-def test_m2o_map_fun_state_passed_to_concat_mapper(mocker: MagicMock) -> None:
+def test_m2o_map_fun_state_passed_to_concat_mapper(
+    mocker: "pytest_mock.MockerFixture",
+) -> None:
     """Test m2o_map state management.
 
     Confirms m2o_map passes 'state' to the underlying concat_mapper and
@@ -556,7 +561,9 @@ def test_m2o_map_fun_state_passed_to_concat_mapper(mocker: MagicMock) -> None:
     mock_to_m2o.assert_called_once_with("test_prefix", "John_Doe_APP", default="")
 
 
-def test_m2o_map_fun_state_modified_by_concat_mapper(mocker: MagicMock) -> None:
+def test_m2o_map_fun_state_modified_by_concat_mapper(
+    mocker: "pytest_mock.MockerFixture",
+) -> None:
     """Confirms m2o_map's underlying concat_mapper can modify the state.
 
     Args:
@@ -573,7 +580,7 @@ def test_m2o_map_fun_state_modified_by_concat_mapper(mocker: MagicMock) -> None:
 
 
 def test_m2o_map_fun_with_skip_and_empty_concat_value_state_passed(
-    mocker: MagicMock,
+    mocker: "pytest_mock.MockerFixture",
 ) -> None:
     """Tests m2o_map.
 

tests/test_preflight.py

@@ -359,7 +359,7 @@ def test_language_check_handles_get_installed_languages_failure(
             config="",
             headless=False,
         )
-        
+
         # Should return False when _get_installed_languages fails
         assert result is False
         mock_get_langs.assert_called_once_with("")
@@ -492,11 +492,14 @@ def test_language_check_fail_mode_skips_entire_check(
         mock_install.assert_not_called()
         mock_confirm.assert_not_called()
 
-
-
     @patch("odoo_data_flow.lib.preflight.Confirm.ask", return_value=True)
-    def test_language_check_dict_config_installation_not_supported(
+    @patch(
+        "odoo_data_flow.lib.preflight._get_installed_languages",
+        return_value={"en_US"},
+    )
+    def test_language_check_dict_config_installation_not_supported_v2(
         self,
+        mock_get_langs: MagicMock,
         mock_confirm: MagicMock,
         mock_polars_read_csv: MagicMock,
         mock_conf_lib: MagicMock,
@@ -530,6 +533,7 @@ def test_language_check_dict_config_installation_not_supported(
             in mock_show_error_panel.call_args[0][0]
         )
 
+
 class TestDeferralAndStrategyCheck:
     """Tests for the deferral_and_strategy_check pre-flight checker."""