@@ -346,28 +346,26 @@ def _convert_external_id_field(
346346 Tuple of (base_field_name, converted_value)
347347 """
348348 base_field_name = field_name [:- 3 ] # Remove '/id' suffix
349+ converted_value = False
349350
350- # Handle empty external ID references
351351 if not field_value :
352352 # Empty external ID means no value for this field
353- converted_value = False
354353 log .debug (
355354 f"Converted empty external ID { field_name } -> { base_field_name } (False)"
356355 )
357356 else :
358357 # Convert external ID to database ID
359358 try :
360359 # Look up the database ID for this external ID
361- record_ref = model .browse (). env .ref (field_value , raise_if_not_found = False )
360+ record_ref = model .env .ref (field_value , raise_if_not_found = False )
362361 if record_ref :
363362 converted_value = record_ref .id
364363 log .debug (
365364 f"Converted external ID { field_name } ({ field_value } ) -> "
366365 f"{ base_field_name } ({ record_ref .id } )"
367366 )
368367 else :
369- # If we can't find the external ID, set to False
370- converted_value = False
368+ # If we can't find the external ID, value remains False
371369 log .warning (
372370 f"Could not find record for external ID '{ field_value } ', "
373371 f"setting { base_field_name } to False"
@@ -377,8 +375,7 @@ def _convert_external_id_field(
377375 f"Error looking up external ID '{ field_value } ' for field "
378376 f"'{ field_name } ': { e } "
379377 )
380- # On error, set to False
381- converted_value = False
378+ # On error, value remains False
382379
383380 return base_field_name , converted_value
384381
0 commit comments