Skip to content

Commit c4b846e

Browse files
rmeissnernlordellremedcu
authored
Add ERC: Permissionless CREATE2 Factory (ethereum#1052)
* Create erc.md * Rename erc.md to erc-permissionless_create2_factory.md * Add discussion link * Fix Minor Typo Just fixes a small inconsistency where we were using `||` and `++` for byte concatenation. Prefer the former. * Fix Heading for 3rd Existing Method * Add More Context about Using Private Key (#2) * Minor Edits - Remove duplicate linking to EIP-7702 (only first one should be linked) - Remove trailing whitespace - Fix spelling error * Fix Requires Reference Requires should be _just_ numbers without the `EIP-` or `ERC-` prefix. This causes issues with the generated HTLM and proofer. * Title Case Sections Fixed some section titles that weren't titlecased correctly. * Use `RETURNDATASIZE` Instead of `PUSH0` In order to not depend on EIP-3855 `PUSH0` opcode, we refactor the factory code to use `RETURNDATASIZE` which is guaranteed to be `0` **except** for when `CREATE2` reverts. With a little bit of moving code around, we also managed to change make the code one byte smaller and fit into a 32-byte word. * Typos * Use eip number * Fix Section Lint The ERC lint does not like additional top level sections, so move the "custom" forwards compatibility section into a subsection of the backwards compatibility * Remove Non-relative Links We remove all non-relative links, as the ERC linter does not allow them. This is slightly unfortunate, since they did provide additional context to the ERC, but 🤷. Note that we format GitHub repositories with italicized title and code for them to stand out: ``` _Title_ (`org/repo`) ``` * Edits to ERC (ethereum#4) * Edits to ERC This PR implements the suggested edits to the ERC, and adds a new section explaining the rationale why Nick's method cannot be used for generating the EIP-7702 authorization signature (since it was a question on Ethereum magicians). * Some small follow-up edits * Another small edit * Clarify reverts cause. Co-authored-by: Shebin John <admin@remedcu.com> --------- Co-authored-by: Shebin John <admin@remedcu.com> * Fix Description The description included a forbidden word, remove it. --------- Co-authored-by: Nicholas Rodrigues Lordello <n@lordello.net> Co-authored-by: Nicholas Rodrigues Lordello <nick@safe.global> Co-authored-by: Shebin John <admin@remedcu.com>
1 parent 9f76a19 commit c4b846e

File tree

1 file changed

+330
-0
lines changed

1 file changed

+330
-0
lines changed

0 commit comments

Comments
 (0)