chore: clean up linting issues (#649)

alxdca · web-flow · commit efb308635737 · 2026-03-03T14:52:47.000+01:00
diff --git a/examples/setup-aep-fee-router/index.ts b/examples/setup-aep-fee-router/index.ts
@@ -169,7 +169,7 @@ async function main() {
     ['parentChainRewardRecipient', parentChainRewardRecipient],
   ] as const);
 
-  type FeeCollectorKey = typeof feeCollectors extends Map<infer K, any> ? K : never;
+  type FeeCollectorKey = typeof feeCollectors extends Map<infer K, unknown> ? K : never;
 
   const feeCollectorToRewardDistributor: Record<FeeCollectorKey, `0x${string}`> = {} as Record<
     FeeCollectorKey,
diff --git a/prettier.config.cjs b/prettier.config.cjs
@@ -1,4 +1,5 @@
 module.exports = {
+  // eslint-disable-next-line @typescript-eslint/no-require-imports
   ...require('@offchainlabs/prettier-config'),
   // override here
 };
diff --git a/src/actions/getMaxTimeVariation.ts b/src/actions/getMaxTimeVariation.ts
@@ -3,7 +3,7 @@ import { sequencerInboxABI } from '../contracts/SequencerInbox';
 import { ActionParameters } from '../types/Actions';
 
 export type GetMaxTimeVariationParameters<Curried extends boolean = false> = ActionParameters<
-  {},
+  Record<string, never>,
   'sequencerInbox',
   Curried
 >;
diff --git a/src/arbAggregatorPrepareTransactionRequest.ts b/src/arbAggregatorPrepareTransactionRequest.ts
@@ -86,7 +86,7 @@ export async function arbAggregatorPrepareTransactionRequest<
     abi: arbAggregatorABI,
   } as unknown as ArbAggregatorPrepareFunctionDataParameters<TFunctionName>);
 
-  // @ts-ignore (todo: fix viem type issue)
+  // @ts-expect-error -- todo: fix viem type issue
   const request = await client.prepareTransactionRequest({
     chain: client.chain,
     to,
diff --git a/src/arbAggregatorReadContract.ts b/src/arbAggregatorReadContract.ts
@@ -20,7 +20,7 @@ export function arbAggregatorReadContract<
   client: PublicClient<Transport, TChain>,
   params: ArbAggregatorReadContractParameters<TFunctionName>,
 ): Promise<ArbAggregatorReadContractReturnType<TFunctionName>> {
-  // @ts-ignore (todo: fix viem type issue)
+  // @ts-expect-error -- todo: fix viem type issue
   return client.readContract({
     address: arbAggregatorAddress,
     abi: arbAggregatorABI,
diff --git a/src/arbGasInfoReadContract.ts b/src/arbGasInfoReadContract.ts
@@ -20,7 +20,7 @@ export function arbGasInfoReadContract<
   client: PublicClient<Transport, TChain>,
   params: ArbGasInfoReadContractParameters<TFunctionName>,
 ): Promise<ArbGasInfoReadContractReturnType<TFunctionName>> {
-  // @ts-ignore (todo: fix viem type issue)
+  // @ts-expect-error -- todo: fix viem type issue
   return client.readContract({
     address: arbGasInfoAddress,
     abi: arbGasInfoABI,
diff --git a/src/arbOwnerPrepareTransactionRequest.ts b/src/arbOwnerPrepareTransactionRequest.ts
@@ -87,7 +87,7 @@ export async function arbOwnerPrepareTransactionRequest<
     abi: arbOwnerABI,
   } as unknown as ArbOwnerPrepareFunctionDataParameters<TFunctionName>);
 
-  // @ts-ignore (todo: fix viem type issue)
+  // @ts-expect-error -- todo: fix viem type issue
   const request = await client.prepareTransactionRequest({
     chain: client.chain,
     to,
diff --git a/src/arbOwnerReadContract.ts b/src/arbOwnerReadContract.ts
@@ -20,7 +20,7 @@ export function arbOwnerReadContract<
   client: PublicClient<Transport, TChain>,
   params: ArbOwnerReadContractParameters<TFunctionName>,
 ): Promise<ArbOwnerReadContractReturnType<TFunctionName>> {
-  // @ts-ignore (todo: fix viem type issue)
+  // @ts-expect-error -- todo: fix viem type issue
   return client.readContract({
     address: arbOwnerPublicAddress,
     abi: arbOwnerPublicABI,
diff --git a/src/chains.unit.test.ts b/src/chains.unit.test.ts
@@ -6,7 +6,7 @@ import { testHelper_createCustomParentChain } from './testHelpers';
 describe('registerCustomParentChain', () => {
   it(`throws if "contracts.rollupCreator.address" is invalid`, () => {
     // omit contracts from the chain
-    const { contracts, ...chain } = testHelper_createCustomParentChain();
+    const { ...chain } = testHelper_createCustomParentChain();
 
     expect(() =>
       registerCustomParentChain({
diff --git a/src/createRollup.ts b/src/createRollup.ts
@@ -221,7 +221,7 @@ export async function createRollup<TChain extends Chain | undefined>({
   // from RPCs that use load balancing and caching. More information can be found here:
   // https://github.com/wevm/viem/issues/1056#issuecomment-1689800265 )
   const tx = createRollupPrepareTransaction(
-    // @ts-ignore (todo: fix viem type issue)
+    // @ts-expect-error -- todo: fix viem type issue
     await parentChainPublicClient.getTransaction({ hash: txHash }),
   );
 
diff --git a/src/createRollupPrepareDeploymentParamsConfig/v2.1.ts b/src/createRollupPrepareDeploymentParamsConfig/v2.1.ts
@@ -5,7 +5,6 @@ import { validateParentChain } from '../types/ParentChain';
 import { Prettify } from '../types/utils';
 import { prepareChainConfigSortKeys } from '../prepareChainConfigSortKeys';
 
-import { createRollup } from '../createRollup';
 import { CreateRollupFunctionInputs } from '../types/createRollupTypes';
 import { prepareChainConfig } from '../prepareChainConfig';
 
diff --git a/src/createRollupPrepareDeploymentParamsConfig/v3.1.ts b/src/createRollupPrepareDeploymentParamsConfig/v3.1.ts
@@ -6,7 +6,6 @@ import { Prettify } from '../types/utils';
 import { getWethAddress } from '../utils';
 import { prepareChainConfigSortKeys } from '../prepareChainConfigSortKeys';
 
-import { createRollup } from '../createRollup';
 import { CreateRollupFunctionInputs } from '../types/createRollupTypes';
 import { prepareChainConfig } from '../prepareChainConfig';
 
diff --git a/src/createRollupPrepareTransaction.ts b/src/createRollupPrepareTransaction.ts
@@ -28,7 +28,7 @@ function createRollupDecodeFunctionData<TAbi extends RollupCreatorABI<RollupCrea
   ].forEach((abi) => {
     try {
       result = decodeFunctionData({ abi, data }) as DecodeFunctionDataReturnType<TAbi>;
-    } catch (error) {
+    } catch {
       // do nothing
     }
   });
diff --git a/src/createRollupPrepareTransactionReceipt.ts b/src/createRollupPrepareTransactionReceipt.ts
@@ -62,7 +62,7 @@ function decodeRollupCreatedEventLog(
       if (result.eventName === 'RollupCreated') {
         decodedEventLog = result;
       }
-    } catch (error) {
+    } catch {
       // do nothing
     }
   });
diff --git a/src/createRollupPrepareTransactionRequest-v2.1.unit.test.ts b/src/createRollupPrepareTransactionRequest-v2.1.unit.test.ts
@@ -1,6 +1,6 @@
 import { it, expect } from 'vitest';
 import { createPublicClient, http, zeroAddress } from 'viem';
-import { arbitrum, arbitrumSepolia } from 'viem/chains';
+import { arbitrumSepolia } from 'viem/chains';
 
 import { generateChainId } from './utils';
 import { prepareChainConfig } from './prepareChainConfig';
diff --git a/src/createRollupPrepareTransactionRequest-v3.1.unit.test.ts b/src/createRollupPrepareTransactionRequest-v3.1.unit.test.ts
@@ -1,6 +1,6 @@
 import { it, expect } from 'vitest';
 import { createPublicClient, http, zeroAddress } from 'viem';
-import { arbitrum, arbitrumSepolia } from 'viem/chains';
+import { arbitrumSepolia } from 'viem/chains';
 
 import { generateChainId } from './utils';
 import { prepareChainConfig } from './prepareChainConfig';
diff --git a/src/createRollupPrepareTransactionRequest.ts b/src/createRollupPrepareTransactionRequest.ts
@@ -146,7 +146,7 @@ export async function createRollupPrepareTransactionRequest<TChain extends Chain
   const paramsWithDefaults = { ...defaults, ...params, maxDataSize };
   const createRollupGetCallValueParams = { ...paramsWithDefaults, account };
 
-  // @ts-ignore (todo: fix viem type issue)
+  // @ts-expect-error -- todo: fix viem type issue
   const request = await publicClient.prepareTransactionRequest({
     chain: publicClient.chain,
     to: rollupCreatorAddressOverride ?? getRollupCreatorAddress(publicClient, rollupCreatorVersion),
diff --git a/src/createSafePrepareTransactionRequest.ts b/src/createSafePrepareTransactionRequest.ts
@@ -5,7 +5,6 @@ import {
   PublicClient,
   Transport,
   encodeFunctionData,
-  TransactionRequest,
   PrepareTransactionRequestParameters,
 } from 'viem';
 import {
diff --git a/src/createTokenBridge-ethers.ts b/src/createTokenBridge-ethers.ts
@@ -1,5 +1,5 @@
 import { Address, PublicClient, Transport, Chain } from 'viem';
-import { BigNumber, ContractFactory, ethers } from 'ethers';
+import { BigNumber, ContractFactory, ethers, ContractInterface } from 'ethers';
 import { ParentToChildMessageGasEstimator } from '@arbitrum/sdk';
 import { getBaseFee } from '@arbitrum/sdk/dist/lib/utils/lib';
 import { RollupAdminLogic__factory } from '@arbitrum/sdk/dist/lib/abi/factories/RollupAdminLogic__factory';
@@ -12,7 +12,7 @@ import { publicClientToProvider } from './ethers-compat/publicClientToProvider';
 
 type NamedFactory = ContractFactory & { contractName: string };
 const NamedFactoryInstance = (contractJson: {
-  abi: any;
+  abi: ContractInterface;
   bytecode: string;
   contractName: string;
 }): NamedFactory => {
@@ -122,7 +122,7 @@ export async function createTokenBridgeGetInputs<
       ? BigNumber.from(retryableGasOverrides.maxGasPrice)
       : await l2Provider.getGasPrice();
 
-  let retryableFee = maxSubmissionCostForFactory
+  const retryableFee = maxSubmissionCostForFactory
     .add(maxSubmissionCostForContracts)
     .add(maxGasForFactory.mul(maxGasPrice))
     .add(maxGasForContracts.mul(maxGasPrice));
diff --git a/src/createTokenBridge.integration.test.ts b/src/createTokenBridge.integration.test.ts
@@ -1,12 +1,5 @@
 import { describe, it, expect } from 'vitest';
-import {
-  createPublicClient,
-  encodeFunctionData,
-  http,
-  parseEther,
-  zeroAddress,
-  parseAbi,
-} from 'viem';
+import { createPublicClient, encodeFunctionData, http, zeroAddress, parseAbi } from 'viem';
 
 import { nitroTestnodeL1, nitroTestnodeL2, nitroTestnodeL3 } from './chains';
 import { getInformationFromTestnode, getNitroTestnodePrivateKeyAccounts } from './testHelpers';
diff --git a/src/createTokenBridge.ts b/src/createTokenBridge.ts
@@ -266,7 +266,7 @@ export async function createTokenBridge<
   // wait for retryables to execute
   console.log(`Waiting for retryable tickets to execute on the Orbit chain...`);
   const orbitChainRetryableReceipts = await txReceipt.waitForRetryables({
-    // @ts-ignore (todo: fix viem type issue)
+    // @ts-expect-error -- todo: fix viem type issue
     orbitPublicClient: orbitChainPublicClient,
   });
   console.log(`Retryables executed`);
@@ -279,7 +279,7 @@ export async function createTokenBridge<
 
   // fetching the TokenBridge contracts
   const tokenBridgeContracts = await txReceipt.getTokenBridgeContracts({
-    // @ts-ignore (todo: fix viem type issue)
+    // @ts-expect-error -- todo: fix viem type issue
     parentChainPublicClient,
   });
 
@@ -319,7 +319,7 @@ export async function createTokenBridge<
     // Wait for retryables to execute
     const orbitChainSetWethGatewayRetryableReceipt =
       await setWethGatewayTxReceipt.waitForRetryables({
-        // @ts-ignore (todo: fix viem type issue)
+        // @ts-expect-error -- todo: fix viem type issue
         orbitPublicClient: orbitChainPublicClient,
       });
     console.log(`Retryables executed`);
@@ -335,13 +335,13 @@ export async function createTokenBridge<
 
     return {
       transaction,
-      // @ts-ignore (todo: fix viem type issue)
+      // @ts-expect-error -- todo: fix viem type issue
       transactionReceipt: txReceipt,
       retryables: orbitChainRetryableReceipts,
       tokenBridgeContracts,
       setWethGateway: {
         transaction: setWethGatewayTransaction,
-        // @ts-ignore (todo: fix viem type issue)
+        // @ts-expect-error -- todo: fix viem type issue
         transactionReceipt: setWethGatewayTxReceipt,
         retryables: [orbitChainSetWethGatewayRetryableReceipt[0]],
       },
@@ -350,7 +350,7 @@ export async function createTokenBridge<
 
   return {
     transaction,
-    // @ts-ignore (todo: fix viem type issue)
+    // @ts-expect-error -- todo: fix viem type issue
     transactionReceipt: txReceipt,
     retryables: orbitChainRetryableReceipts,
     tokenBridgeContracts,
diff --git a/src/createTokenBridgePrepareCustomFeeTokenApprovalTransactionRequest.ts b/src/createTokenBridgePrepareCustomFeeTokenApprovalTransactionRequest.ts
@@ -1,4 +1,4 @@
-import { Address, PublicClient, Transport, Chain, maxInt256 } from 'viem';
+import { Address, PublicClient, Transport, Chain } from 'viem';
 
 import { approvePrepareTransactionRequest, fetchDecimals } from './utils/erc20';
 
diff --git a/src/createTokenBridgePrepareSetWethGatewayTransactionRequest.ts b/src/createTokenBridgePrepareSetWethGatewayTransactionRequest.ts
@@ -229,7 +229,7 @@ export async function createTokenBridgePrepareSetWethGatewayTransactionRequest<
   });
 
   // prepare the transaction request with a call to the upgrade executor
-  // @ts-ignore (todo: fix viem type issue)
+  // @ts-expect-error -- todo: fix viem type issue
   const request = await parentChainPublicClient.prepareTransactionRequest({
     chain: parentChainPublicClient.chain,
     to: rollupCoreContracts.upgradeExecutor,
diff --git a/src/createTokenBridgePrepareTransactionRequest.ts b/src/createTokenBridgePrepareTransactionRequest.ts
@@ -79,7 +79,7 @@ export async function createTokenBridgePrepareTransactionRequest<
     parentChainPublicClient,
   });
 
-  // @ts-ignore (todo: fix viem type issue)
+  // @ts-expect-error -- todo: fix viem type issue
   const request = await parentChainPublicClient.prepareTransactionRequest({
     chain: parentChainPublicClient.chain,
     to: tokenBridgeCreatorAddress,
diff --git a/src/decorators/arbGasInfoPublicActions.ts b/src/decorators/arbGasInfoPublicActions.ts
@@ -7,6 +7,7 @@ import {
   ArbGasInfoReadContractReturnType,
 } from '../arbGasInfoReadContract';
 
+// eslint-disable-next-line @typescript-eslint/no-unused-vars -- todo: remove generic if not breaking
 export type ArbGasInfoPublicActions<TChain extends Chain | undefined = Chain | undefined> = {
   arbGasInfoReadContract: <TFunctionName extends ArbGasInfoFunctionName>(
     args: ArbGasInfoReadContractParameters<TFunctionName>,
diff --git a/src/decorators/arbOwnerPublicActionsUpgradeExecutor.integration.test.ts b/src/decorators/arbOwnerPublicActionsUpgradeExecutor.integration.test.ts
@@ -10,7 +10,7 @@ import { getNitroTestnodePrivateKeyAccounts } from '../testHelpers';
 const devPrivateKey = getNitroTestnodePrivateKeyAccounts().l3RollupOwner.privateKey;
 
 // L3 Upgrade Executor Address
-let upgradeExecutorAddress: Address = '0x24198F8A339cd3C47AEa3A764A20d2dDaB4D1b5b';
+const upgradeExecutorAddress: Address = '0x24198F8A339cd3C47AEa3A764A20d2dDaB4D1b5b';
 
 const owner = privateKeyToAccount(devPrivateKey);
 const randomAccount = privateKeyToAccount(generatePrivateKey());
diff --git a/src/decorators/sequencerInboxActions.integration.test.ts b/src/decorators/sequencerInboxActions.integration.test.ts
@@ -1,5 +1,5 @@
 import { describe, it, expect } from 'vitest';
-import { Address, createPublicClient, http, zeroAddress } from 'viem';
+import { createPublicClient, http, zeroAddress } from 'viem';
 import { generatePrivateKey, privateKeyToAccount } from 'viem/accounts';
 
 import { nitroTestnodeL2 } from '../chains';
diff --git a/src/feeRouter.integration.test.ts b/src/feeRouter.integration.test.ts
@@ -13,10 +13,7 @@ import { generatePrivateKey, privateKeyToAccount } from 'viem/accounts';
 
 import { nitroTestnodeL1, nitroTestnodeL2 } from './chains';
 import { getNitroTestnodePrivateKeyAccounts } from './testHelpers';
-import {
-  feeRouterDeployChildToParentRewardRouter,
-  feeRouterDeployOpChildToParentRewardRouter,
-} from './feeRouterDeployChildToParentRewardRouter';
+import { feeRouterDeployChildToParentRewardRouter } from './feeRouterDeployChildToParentRewardRouter';
 import { feeRouterDeployRewardDistributor } from './feeRouterDeployRewardDistributor';
 
 const testnodeAccounts = getNitroTestnodePrivateKeyAccounts();
diff --git a/src/getBatchPosters.ts b/src/getBatchPosters.ts
@@ -126,7 +126,7 @@ export async function getBatchPosters<TChain extends Chain>(
       hash: createRollupTransactionHash,
     });
     blockNumber = receipt.blockNumber;
-  } catch (e) {
+  } catch {
     blockNumber = 0n;
   }
 
diff --git a/src/getKeysets.integration.test.ts b/src/getKeysets.integration.test.ts
@@ -110,7 +110,7 @@ async function createAnytrustRollup() {
 describe('successfully get valid keysets', () => {
   it('when disabling the same keyset multiple time', async () => {
     const { createRollupInformation } = await createAnytrustRollup();
-    const { sequencerInbox, upgradeExecutor, rollup } = createRollupInformation.coreContracts;
+    const { sequencerInbox, upgradeExecutor } = createRollupInformation.coreContracts;
     const { keysets: initialKeysets } = await getKeysets(client, {
       sequencerInbox,
     });
diff --git a/src/getKeysets.ts b/src/getKeysets.ts
@@ -54,7 +54,8 @@ export async function getKeysets<TChain extends Chain>(
     });
     blockNumber = receipt.blockNumber;
   } catch (e) {
-    console.warn(`[getKeysets] ${(e as any).message}`);
+    const message = e instanceof Error ? e.message : String(e);
+    console.warn(`[getKeysets] ${message}`);
     blockNumber = 0n;
   }
 
diff --git a/src/getKeysets.unit.test.ts b/src/getKeysets.unit.test.ts
@@ -39,7 +39,6 @@ function mockInvalidateKeysetHashEvent(keysetHash: Hex) {
 function mockData({
   logs,
   method,
-  params,
 }: {
   logs: unknown[];
   method:
diff --git a/src/getValidators.ts b/src/getValidators.ts
@@ -228,7 +228,7 @@ export async function getValidators<TChain extends Chain>(
       hash: createRollupTransactionHash,
     });
     blockNumber = receipt.blockNumber;
-  } catch (e) {
+  } catch {
     blockNumber = 0n;
   }
 
diff --git a/src/isAnyTrust.ts b/src/isAnyTrust.ts
@@ -48,7 +48,7 @@ export async function isAnyTrust<TChain extends Chain>({
       });
 
       result = parseConfig(config);
-    } catch (error) {
+    } catch {
       // do nothing
     }
   });
diff --git a/src/rollupAdminLogicPrepareTransactionRequest.ts b/src/rollupAdminLogicPrepareTransactionRequest.ts
@@ -92,7 +92,7 @@ export async function rollupAdminLogicPrepareTransactionRequest<
     abi: rollupABI,
   } as unknown as RollupAdminLogicPrepareFunctionDataParameters<TFunctionName>);
 
-  // @ts-ignore (todo: fix viem type issue)
+  // @ts-expect-error -- todo: fix viem type issue
   const request = await client.prepareTransactionRequest({
     chain: client.chain,
     to,
diff --git a/src/scripts/generateNodeConfigType.ts b/src/scripts/generateNodeConfigType.ts
@@ -83,7 +83,7 @@ function parseCliOptions(fileContents: string): CliOption[] {
   );
   // sanitize the boolean types
   lines = lines.map((line) => {
-    let split = line.split(' ');
+    const split = line.split(' ');
     // if the flag is just a boolean, then the type is omitted from the --help output, e.g. "--init.force"
     // to make things simpler and consistent, we replace the empty string with boolean
     if (split[1] === '') {
@@ -126,7 +126,7 @@ function createCliOptionsNestedObject(options: CliOption[]): CliOptionNestedObje
   const result: CliOptionNestedObject = {};
 
   options.forEach((option) => {
-    let paths = option.name.split('.');
+    const paths = option.name.split('.');
     let current: CliOptionNestedObject = result;
 
     for (let i = 0; i < paths.length; i++) {
diff --git a/src/sequencerInboxPrepareTransactionRequest.ts b/src/sequencerInboxPrepareTransactionRequest.ts
@@ -90,7 +90,7 @@ export async function sequencerInboxPrepareTransactionRequest<
     abi: sequencerInboxABI,
   } as unknown as SequencerInboxPrepareFunctionDataParameters<TFunctionName>);
 
-  // @ts-ignore (todo: fix viem type issue)
+  // @ts-expect-error -- todo: fix viem type issue
   const request = await client.prepareTransactionRequest({
     chain: client.chain,
     to,
diff --git a/src/sequencerInboxReadContract.ts b/src/sequencerInboxReadContract.ts
diff --git a/src/setAnyTrustFastConfirmerPrepareTransactionRequest.ts b/src/setAnyTrustFastConfirmerPrepareTransactionRequest.ts
diff --git a/src/setValidKeyset.ts b/src/setValidKeyset.ts
diff --git a/src/setValidKeysetPrepareTransactionRequest.ts b/src/setValidKeysetPrepareTransactionRequest.ts
diff --git a/src/types/ParentChain.ts b/src/types/ParentChain.ts
diff --git a/src/upgradeExecutorEncodeFunctionData.ts b/src/upgradeExecutorEncodeFunctionData.ts
diff --git a/src/upgradeExecutorPrepareAddExecutorTransactionRequest.ts b/src/upgradeExecutorPrepareAddExecutorTransactionRequest.ts
diff --git a/src/upgradeExecutorPrepareRemoveExecutorTransactionRequest.ts b/src/upgradeExecutorPrepareRemoveExecutorTransactionRequest.ts
diff --git a/src/utils/erc20.ts b/src/utils/erc20.ts
diff --git a/src/utils/validateChain.ts b/src/utils/validateChain.ts
diff --git a/wagmi.config.ts b/wagmi.config.ts
