Remove benchmark code from debug code

Author: KolbyML

Makefile

@@ -245,7 +245,7 @@ test-go-redis: test-go-deps
 
 .PHONY: test-go-experimental
 test-go-experimental: test-go-deps
-	.github/workflows/gotestsum.sh --timeout 120m --run TestExperimental --tags debugblock,benchsequencer --nolog
+	.github/workflows/gotestsum.sh --timeout 120m --run TestExperimental --tags debugblock --nolog
 	@printf $(done)
 
 .PHONY: test-gen-proofs
@@ -362,7 +362,7 @@ $(output_root)/bin/transaction-filterer: $(DEP_PREDICATE) build-node-deps
 
 # nitro built with experimental tooling enabled
 $(output_root)/bin/nitro-experimental: $(DEP_PREDICATE) build-node-deps
-	go build $(GOLANG_PARAMS) --tags debugblock,benchsequencer -o $@ "$(CURDIR)/cmd/nitro"
+	go build $(GOLANG_PARAMS) --tags debugblock -o $@ "$(CURDIR)/cmd/nitro"
 
 # recompile wasm, but don't change timestamp unless files differ
 $(replay_wasm): $(DEP_PREDICATE) $(go_source) .make/solgen

cmd/util/confighelpers/configuration.go

@@ -209,7 +209,7 @@ func devFlagArgs() []string {
 		"--init.empty=false",
 		"--http.port", "8547",
 		"--http.addr", "127.0.0.1",
-		"--http.api=net,web3,eth,arb,arbdebug,debug,benchseq",
+		"--http.api=net,web3,eth,arb,arbdebug,debug",
 		"--node.transaction-streamer.track-block-metadata-from=1",
 	}
 	return args

execution/gethexec/bench_sequencer.go

@@ -221,27 +221,21 @@ func LiveTracingConfigAddOptions(prefix string, f *pflag.FlagSet) {
 }
 
 type DangerousConfig struct {
-	DebugBlock     debugblock.Config    `koanf:"debug-block"`
-	BenchSequencer BenchSequencerConfig `koanf:"bench-sequencer"`
+	DebugBlock debugblock.Config `koanf:"debug-block"`
 }
 
 var DefaultDangerousConfig = DangerousConfig{
-	DebugBlock:     debugblock.ConfigDefault,
-	BenchSequencer: BenchSequencerConfigDefault,
+	DebugBlock: debugblock.ConfigDefault,
 }
 
 func DangerousConfigAddOptions(prefix string, f *pflag.FlagSet) {
 	debugblock.ConfigAddOptions(prefix+".debug-block", f)
-	BenchSequencerConfigAddOptions(prefix+".bench-sequencer", f)
 }
 
 func (c *DangerousConfig) Validate() error {
 	if err := c.DebugBlock.Validate(); err != nil {
 		return err
 	}
-	if err := c.BenchSequencer.Validate(); err != nil {
-		return err
-	}
 	return nil
 }
 
@@ -340,17 +334,13 @@ func CreateExecutionNode(
 		log.Warn("sequencer enabled without l1 client")
 	}
 
-	var benchSequencerService interface{}
 	if config.Sequencer.Enable {
 		seqConfigFetcher := func() *SequencerConfig { return &configFetcher.Get().Sequencer }
 		sequencer, err = NewSequencer(execEngine, parentChainReader, seqConfigFetcher, parentChainID)
 		if err != nil {
 			return nil, err
 		}
 		txPublisher = sequencer
-		if config.Dangerous.BenchSequencer.Enable {
-			txPublisher, benchSequencerService = NewBenchSequencer(sequencer)
-		}
 	} else {
 		if config.Forwarder.RedisUrl != "" {
 			txPublisher = NewRedisTxForwarder(config.forwardingTarget, &config.Forwarder)
@@ -481,14 +471,6 @@ func CreateExecutionNode(
 			Authenticated: config.RPCServer.Authenticated,
 		})
 	}
-	if benchSequencerService != nil {
-		apis = append(apis, rpc.API{
-			Namespace: "benchseq",
-			Service:   benchSequencerService,
-			Public:    false,
-		})
-	}
-
 	stack.RegisterAPIs(apis)
 
 	return execNode, nil