Skip to content

Commit 3999a58

Browse files
committed
Reduce parallelism in pebble nightly tests
These tests are still flaky even after spliting them into two separate jobs. This PR tries to solve this issue by reducing the parallelism to half of the available cores. Close NIT-4375
1 parent 3a25bb0 commit 3999a58

File tree

3 files changed

+16
-1
lines changed

3 files changed

+16
-1
lines changed

.github/workflows/_go-tests.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,11 +220,14 @@ jobs:
220220
${{ github.workspace }}/.github/workflows/gotestsum.sh --timeout 90m --test_database_engine pebble
221221
--junitfile test-results/junit-pebble.xml --run '^Test[A-L]'
222222
223+
- name: define
224+
if: inputs.run-pebble-b
225+
223226
- name: run pebble tests (B-batch)
224227
if: inputs.run-pebble-b
225228
run: >-
226229
${{ github.workspace }}/.github/workflows/gotestsum.sh --timeout 90m --test_database_engine pebble
227-
--junitfile test-results/junit-pebble.xml --skip '^Test[A-L]'
230+
--junitfile test-results/junit-pebble.xml --skip '^Test[A-L]' --parallel $(( $(nproc) > 2 ? $(nproc) / 2 : 1 ))
228231
229232
# --------------------- PROCESS JUNIT LOGS ---------------------
230233

.github/workflows/gotestsum.sh

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ race=false
1919
cover=false
2020
consensus_execution_in_same_process_use_rpc=false
2121
flaky=false
22+
parallel=""
2223
while [[ $# -gt 0 ]]; do
2324
case $1 in
2425
--timeout)
@@ -83,6 +84,9 @@ while [[ $# -gt 0 ]]; do
8384
flaky=true
8485
shift
8586
;;
87+
--parallel)
88+
check_missing_value $# "$1" "--parallel"
89+
parallel=$1
8690
*)
8791
echo "Invalid argument: $1"
8892
exit 1
@@ -136,6 +140,10 @@ if [ "$cover" == true ]; then
136140
cmd="$cmd -coverprofile=coverage.txt -covermode=atomic -coverpkg=./...,./go-ethereum/..."
137141
fi
138142

143+
if [ "$parallel" != "" ]; then
144+
cmd="$cmd -parallel $parallel"
145+
fi
146+
139147
if [ "$test_state_scheme" != "" ]; then
140148
cmd="$cmd -args -- --test_state_scheme=$test_state_scheme --test_loglevel=8"
141149
else

changelog/gligneul-nit-4375.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
### Ignored
2+
3+
- Reduce parallelism in pebble nightly tests
4+

0 commit comments

Comments
 (0)