Add Succinct SP1 as an arbitrator-like runner

Author: wakabat

arbitrator/arbutil/Cargo.toml

@@ -21,3 +21,7 @@ serde = { workspace = true, features = ["derive", "rc"] }
 siphasher = { workspace = true }
 tiny-keccak = { workspace = true, features = ["keccak"] }
 wasmparser = { workspace = true }
+
+[features]
+default = []
+sp1 = []

arbitrator/arbutil/src/operator.rs

@@ -1178,6 +1178,8 @@ impl From<&Operator<'_>> for OperatorCode {
             O::I16x8RelaxedQ15mulrS { .. } => 0xfd111,
             O::I16x8RelaxedDotI8x16I7x16S { .. } => 0xfd112,
             O::I32x4RelaxedDotI8x16I7x16AddS { .. } => 0xfd113,
+            #[cfg(feature = "sp1")]
+            _ => todo!(),
         })
     }
 }

arbitrator/prover/Cargo.toml

@@ -64,3 +64,4 @@ counters = []
 native = ["dep:wasmer", "dep:wasmer-compiler-singlepass", "brotli/wasmer_traits", "dep:c-kzg"]
 singlepass_rayon = ["wasmer-compiler-singlepass?/rayon"]
 rayon = ["dep:rayon"]
+sp1 = []

arbitrator/prover/src/binary.rs

@@ -3,16 +3,16 @@
 
 use crate::{
     programs::{
+        FuncMiddleware, Middleware, ModuleMod, STYLUS_ENTRY_POINT, StylusData,
         config::CompileConfig, counter::Counter, depth::DepthChecker, dynamic::DynamicMeter,
-        heap::HeapBound, meter::Meter, start::StartMover, FuncMiddleware, Middleware, ModuleMod,
-        StylusData, STYLUS_ENTRY_POINT,
+        heap::HeapBound, meter::Meter, start::StartMover,
     },
     value::{ArbValueType, FunctionType, IntegerValType, Value},
 };
 use arbutil::{
-    evm::ARBOS_VERSION_STYLUS_CHARGING_FIXES, math::SaturatingSum, Bytes32, Color, DebugColor,
+    Bytes32, Color, DebugColor, evm::ARBOS_VERSION_STYLUS_CHARGING_FIXES, math::SaturatingSum,
 };
-use eyre::{bail, ensure, eyre, Result, WrapErr};
+use eyre::{Result, WrapErr, bail, ensure, eyre};
 use fnv::{FnvHashMap as HashMap, FnvHashSet as HashSet};
 use nom::{
     branch::alt,
@@ -22,7 +22,7 @@ use nom::{
 };
 use serde::{Deserialize, Serialize};
 use std::{convert::TryInto, fmt::Debug, hash::Hash, mem, path::Path, str::FromStr};
-use wasmer_types::{entity::EntityRef, ExportIndex, FunctionIndex, LocalFunctionIndex};
+use wasmer_types::{ExportIndex, FunctionIndex, LocalFunctionIndex, entity::EntityRef};
 use wasmparser::{
     Data, Element, ExternalKind, MemoryType, Name, NameSectionReader, Naming, Operator, Parser,
     Payload, TableType, TypeRef, ValType, Validator, WasmFeatures,
@@ -255,6 +255,8 @@ impl From<ExportIndex> for ExportKind {
             E::Table(_) => Self::Table,
             E::Memory(_) => Self::Memory,
             E::Global(_) => Self::Global,
+            #[cfg(feature = "sp1")]
+            E::Tag(_) => Self::Tag,
         }
     }
 }
@@ -301,6 +303,7 @@ pub struct WasmBinary<'a> {
 }
 
 pub fn parse<'a>(input: &'a [u8], path: &'_ Path) -> Result<WasmBinary<'a>> {
+    #[cfg(not(feature = "sp1"))]
     let features = WasmFeatures {
         mutable_global: true,
         saturating_float_to_int: true,
@@ -324,6 +327,17 @@ pub fn parse<'a>(input: &'a [u8], path: &'_ Path) -> Result<WasmBinary<'a>> {
         component_model_values: false,
         component_model_nested_names: false,
     };
+    #[cfg(feature = "sp1")]
+    let features = {
+        let mut features = WasmFeatures::empty();
+        features.set(WasmFeatures::MUTABLE_GLOBAL, true);
+        features.set(WasmFeatures::SATURATING_FLOAT_TO_INT, true);
+        features.set(WasmFeatures::SIGN_EXTENSION, true);
+        features.set(WasmFeatures::MULTI_VALUE, true);
+        features.set(WasmFeatures::BULK_MEMORY, true); // not all ops supported yet
+        features.set(WasmFeatures::FLOATS, true);
+        features
+    };
     Validator::new_with_features(features)
         .validate_all(input)
         .wrap_err_with(|| eyre!("failed to validate {}", path.to_string_lossy().red()))?;
@@ -429,7 +443,11 @@ pub fn parse<'a>(input: &'a [u8], path: &'_ Path) -> Result<WasmBinary<'a>> {
                 }
 
                 // CHECK: maybe reader.data_offset()
+                #[cfg(not(feature = "sp1"))]
                 let name_reader = NameSectionReader::new(reader.data(), 0);
+                #[cfg(feature = "sp1")]
+                let name_reader =
+                    NameSectionReader::new(wasmparser::BinaryReader::new(reader.data(), 0));
 
                 for name in name_reader {
                     match name? {

arbitrator/prover/src/host.rs

@@ -8,60 +8,14 @@ use crate::{
     machine::{Function, InboxIdentifier},
     programs::StylusData,
     utils,
-    value::{ArbValueType, FunctionType},
+    value::{ArbValueType, FunctionType, InternalFunc},
     wavm::{wasm_to_wavm, Instruction, Opcode},
 };
 use arbutil::{evm::user::UserOutcomeKind, Color, PreimageType};
 use eyre::{bail, ErrReport, Result};
 use lazy_static::lazy_static;
-use num_derive::FromPrimitive;
 use std::{collections::HashMap, path::Path, str::FromStr};
 
-/// Represents the internal hostio functions a module may have.
-#[derive(Clone, Copy, Debug, FromPrimitive)]
-#[repr(u64)]
-pub enum InternalFunc {
-    WavmCallerLoad8,
-    WavmCallerLoad32,
-    WavmCallerStore8,
-    WavmCallerStore32,
-    MemoryFill,
-    MemoryCopy,
-    UserInkLeft,
-    UserInkStatus,
-    UserSetInk,
-    UserStackLeft,
-    UserSetStack,
-    UserMemorySize,
-    CallMain,
-}
-
-impl InternalFunc {
-    pub fn ty(&self) -> FunctionType {
-        use ArbValueType::*;
-        use InternalFunc::*;
-        macro_rules! func {
-            ([$($args:expr),*], [$($outs:expr),*]) => {
-                FunctionType::new(vec![$($args),*], vec![$($outs),*])
-            };
-        }
-        #[rustfmt::skip]
-        let ty = match self {
-            WavmCallerLoad8  | WavmCallerLoad32  => func!([I32], [I32]),
-            WavmCallerStore8 | WavmCallerStore32 => func!([I32, I32], []),
-            MemoryFill       | MemoryCopy        => func!([I32, I32, I32], []),
-            UserInkLeft    => func!([], [I64]),      // λ() → ink_left
-            UserInkStatus  => func!([], [I32]),      // λ() → ink_status
-            UserSetInk     => func!([I64, I32], []), // λ(ink_left, ink_status)
-            UserStackLeft  => func!([], [I32]),      // λ() → stack_left
-            UserSetStack   => func!([I32], []),      // λ(stack_left)
-            UserMemorySize => func!([], [I32]),      // λ() → memory_size
-            CallMain       => func!([I32], [I32]),   // λ(args_len) → status
-        };
-        ty
-    }
-}
-
 /// Represents the internal hostio functions a module may have.
 pub enum Hostio {
     WavmCallerLoad8,

arbitrator/prover/src/memory.rs

@@ -7,7 +7,7 @@ use crate::{
 };
 use arbutil::Bytes32;
 use digest::Digest;
-use eyre::{bail, ErrReport, Result};
+use eyre::{bail, Result};
 use parking_lot::Mutex;
 use serde::{Deserialize, Serialize};
 use sha3::Keccak256;
@@ -16,8 +16,6 @@ use std::{borrow::Cow, collections::HashSet, convert::TryFrom};
 #[cfg(feature = "counters")]
 use std::sync::atomic::{AtomicUsize, Ordering};
 
-use wasmer_types::Pages;
-
 #[cfg(feature = "rayon")]
 use rayon::prelude::*;
 
@@ -37,34 +35,6 @@ pub fn print_counters() {
     );
 }
 
-pub struct MemoryType {
-    pub min: Pages,
-    pub max: Option<Pages>,
-}
-
-impl MemoryType {
-    pub fn new(min: Pages, max: Option<Pages>) -> Self {
-        Self { min, max }
-    }
-}
-
-impl From<&wasmer_types::MemoryType> for MemoryType {
-    fn from(value: &wasmer_types::MemoryType) -> Self {
-        Self::new(value.minimum, value.maximum)
-    }
-}
-
-impl TryFrom<&wasmparser::MemoryType> for MemoryType {
-    type Error = ErrReport;
-
-    fn try_from(value: &wasmparser::MemoryType) -> std::result::Result<Self, Self::Error> {
-        Ok(Self {
-            min: Pages(value.initial.try_into()?),
-            max: value.maximum.map(|x| x.try_into()).transpose()?.map(Pages),
-        })
-    }
-}
-
 #[derive(Debug, Default, Serialize, Deserialize)]
 pub struct Memory {
     buffer: Vec<u8>,

arbitrator/prover/src/parse_input.rs

@@ -1,9 +1,9 @@
 use arbutil::Bytes32;
 use serde::Deserialize;
 use serde_json;
-use serde_with::base64::Base64;
 use serde_with::As;
 use serde_with::DisplayFromStr;
+use serde_with::base64::Base64;
 use std::{
     collections::HashMap,
     io::{self, BufRead},
@@ -54,13 +54,22 @@ impl AsRef<[u8]> for UserWasm {
 }
 
 /// The Vec<u8> is compressed using brotli, and must be decompressed before use.
+#[cfg(not(feature = "sp1"))]
 impl From<Vec<u8>> for UserWasm {
     fn from(data: Vec<u8>) -> Self {
         let decompressed = brotli::decompress(&data, brotli::Dictionary::Empty).unwrap();
         Self(decompressed)
     }
 }
 
+/// Due to alignment reason, we will do the decompression elsewhere in SP1.
+#[cfg(feature = "sp1")]
+impl From<Vec<u8>> for UserWasm {
+    fn from(data: Vec<u8>) -> Self {
+        Self(data)
+    }
+}
+
 #[derive(Debug, Clone, Deserialize)]
 #[serde(rename_all = "PascalCase")]
 pub struct BatchInfo {

arbitrator/prover/src/print.rs

@@ -2,9 +2,8 @@
 // For license information, see https://github.com/OffchainLabs/nitro/blob/master/LICENSE.md
 
 use crate::{
-    host::InternalFunc,
     machine::Module,
-    value::{FunctionType, Value},
+    value::{FunctionType, InternalFunc, Value},
     wavm::{self, Opcode},
 };
 use arbutil::Color;

arbitrator/prover/src/programs/config.rs

@@ -14,12 +14,10 @@ use wasmparser::Operator;
 #[cfg(feature = "native")]
 use {
     super::{
-        counter::Counter, depth::DepthChecker, dynamic::DynamicMeter, heap::HeapBound,
-        meter::Meter, start::StartMover, MiddlewareWrapper,
+        MiddlewareWrapper, counter::Counter, depth::DepthChecker, dynamic::DynamicMeter,
+        heap::HeapBound, meter::Meter, start::StartMover,
     },
     std::sync::Arc,
-    wasmer::{Cranelift, CraneliftOptLevel, Engine, Store, Target},
-    wasmer_compiler_singlepass::Singlepass,
 };
 
 #[derive(Clone, Copy, Debug)]
@@ -177,8 +175,16 @@ impl CompileConfig {
 
         config
     }
+}
 
-    #[cfg(feature = "native")]
+#[cfg(all(feature = "native", not(feature = "sp1")))]
+use {
+    wasmer::{Cranelift, CraneliftOptLevel, Engine, Store, Target},
+    wasmer_compiler_singlepass::Singlepass,
+};
+
+#[cfg(all(feature = "native", not(feature = "sp1")))]
+impl CompileConfig {
     fn engine_type(&self, target: Target, cranelift: bool) -> Engine {
         use wasmer::sys::EngineBuilder;
 
@@ -217,13 +223,11 @@ impl CompileConfig {
             .into()
     }
 
-    #[cfg(feature = "native")]
     // cranelift only matters for compilation and not usually needed
     pub fn engine(&self, target: Target) -> Engine {
         self.engine_type(target, true)
     }
 
-    #[cfg(feature = "native")]
     pub fn store(&self, target: Target, cranelift: bool) -> Store {
         Store::new(self.engine_type(target, cranelift))
     }

arbitrator/prover/src/programs/counter.rs

@@ -2,10 +2,12 @@
 // For license information, see https://github.com/OffchainLabs/nitro/blob/master/LICENSE.md
 
 use super::{FuncMiddleware, Middleware, ModuleMod};
-use crate::Machine;
 
+#[cfg(feature = "sp1")]
+use crate::operator::{OperatorCode, OperatorInfo};
+#[cfg(not(feature = "sp1"))]
 use arbutil::operator::{OperatorCode, OperatorInfo};
-use eyre::{eyre, Result};
+use eyre::{Result, eyre};
 use fnv::FnvHashMap as HashMap;
 use lazy_static::lazy_static;
 use parking_lot::Mutex;
@@ -139,7 +141,8 @@ pub trait CountingMachine {
     fn operator_counts(&mut self) -> Result<BTreeMap<OperatorCode, u64>>;
 }
 
-impl CountingMachine for Machine {
+#[cfg(not(feature = "sp1"))]
+impl CountingMachine for crate::Machine {
     fn operator_counts(&mut self) -> Result<BTreeMap<OperatorCode, u64>> {
         let mut counts = BTreeMap::new();