Skip to content

remove blob fee pricing update #4204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
tsahee wants to merge 1 commit into
base: v3.9.x-release
Choose a base branch
from
+0 −12
Draft

remove blob fee pricing update #4204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions arbnode/dataposter/data_poster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -736,18 +736,6 @@ func (p *DataPoster) feeAndTipCaps(ctx context.Context, nonce uint64, gasLimit u
}
}

if lastTx != nil && (arbmath.BigLessThan(newBaseFeeCap, currentNonBlobFee) || (numBlobs > 0 && arbmath.BigLessThan(newBlobFeeCap, currentBlobFee))) {
// Make sure our replace by fee can meet the current parent chain fee demands.
// Without this check, we'd blindly increase each fee component by the min rbf amount each time,
// without looking at which component(s) actually need increased.
// E.g. instead of 2x basefee and 2x blobfee, we might actually want to 4x basefee and 2x blobfee.
// This check lets us hold off on the rbf until we are actually meet the current fee requirements,
// which lets us move in a particular direction (biasing towards either basefee or blobfee).
log.Info("can't meet current parent chain fees with current target max cost", logFields...)
// wait until we have a higher target max cost to replace by fee
return lastTx.GasFeeCap(), lastTx.GasTipCap(), lastTx.BlobGasFeeCap(), nil
}

// Ensure we bid at least 1 wei to prevent division by zero
if newBaseFeeCap.Sign() == 0 {
newBaseFeeCap = big.NewInt(1)
Expand Down
Loading