Skip to content

Fix Beacon API host validation in validator service #16046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maradini77 wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Fix Beacon API host validation in validator service #16046

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7b9cd89
Update service.go
maradini77 Nov 24, 2025
4f90822
Create maradini77_patch-2.md
maradini77 Nov 25, 2025
95d225c
Update maradini77_patch-2.md
maradini77 Nov 25, 2025
69e2c0e
Update service.go
maradini77 Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/maradini77_patch-2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
### Fixed

- Prevent validator service from starting with empty Beacon API host lists by filtering and validating endpoints.
16 changes: 14 additions & 2 deletions validator/client/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,8 +181,7 @@ func (v *ValidatorService) Start() {
return
}

u := strings.ReplaceAll(v.conn.GetBeaconApiUrl(), " ", "")
hosts := strings.Split(u, ",")
hosts := sanitizeBeaconAPIHosts(v.conn.GetBeaconApiUrl())
if len(hosts) == 0 {
log.WithError(err).Error("No API hosts provided")
return
Expand Down Expand Up @@ -376,6 +375,19 @@ func ConstructDialOptions(
return dialOpts
}

func sanitizeBeaconAPIHosts(raw string) []string {
u := strings.ReplaceAll(raw, " ", "")
rawHosts := strings.Split(u, ",")
hosts := make([]string, 0, len(rawHosts))
for _, host := range rawHosts {
if host == "" {
continue
}
hosts = append(hosts, host)
}
return hosts
}

func (v *ValidatorService) Graffiti(ctx context.Context, pubKey [fieldparams.BLSPubkeyLength]byte) ([]byte, error) {
if v.validator == nil {
return nil, errors.New("validator is unavailable")
Expand Down