fix: allow full-capacity snapshots in fromSnapshot #16070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return nil, ErrInvalidSnapshotRoot | ||
| } | ||
| if snapshot.depositCount >= math.PowerOf2(uint64(DepositContractDepth)) { | ||
| if snapshot.depositCount > math.PowerOf2(uint64(DepositContractDepth)) { |
Member
There was a problem hiding this comment.
This seems like a good candidate for a regression test. Do you have a specific case already which could be added here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The capacity guard in fromSnapshot used >= against 2^DepositContractDepth, rejecting snapshots whose deposit_count exactly equals the tree capacity. This contradicts both our fromSnapshotParts implementation, which explicitly handles the equality case by returning a FinalizedNode, and the EIP‑4881 reference implementation where deposits == 2**level is valid. Changing the check to a strict > makes equality acceptable, preventing false rejections of full trees and keeping behavior consistent with the spec and the rest of the code.