Skip to content

perf: avoid string copy when importing slashing protection JSON #16081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Fibonacci747 wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

perf: avoid string copy when importing slashing protection JSON #16081

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b77490
perf: avoid string copy when importing slashing protection JSON
Fibonacci747 Nov 29, 2025
c5086cc
add changelog
Fibonacci747 Nov 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/Fibonacci747_perf.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
### Changed

- avoid string copy when importing slashing protection JSON [#16081](https://github.com/OffchainLabs/prysm/pull/16081)
7 changes: 3 additions & 4 deletions validator/rpc/handlers_slashing.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
package rpc

import (
"bytes"
"encoding/json"
"io"
"net/http"
"strings"

"github.com/OffchainLabs/prysm/v7/monitoring/tracing/trace"
"github.com/OffchainLabs/prysm/v7/network/httputil"
Expand Down Expand Up @@ -74,9 +74,8 @@ func (s *Server) ImportSlashingProtection(w http.ResponseWriter, r *http.Request
httputil.HandleError(w, "empty slashing_protection_json specified", http.StatusBadRequest)
return
}
enc := []byte(req.SlashingProtectionJson)
buf := bytes.NewBuffer(enc)
if err := s.db.ImportStandardProtectionJSON(ctx, buf); err != nil {
rdr := strings.NewReader(req.SlashingProtectionJson)
if err := s.db.ImportStandardProtectionJSON(ctx, rdr); err != nil {
httputil.HandleError(w, errors.Wrap(err, "could not import slashing protection history").Error(), http.StatusInternalServerError)
return
}
Expand Down