Skip to content

Custom settings sample broken in multiple ways #1013

@Rick-Kirkham

Description

@Rick-Kirkham

The custom settings sample can't be sideloaded on desktop and doesn't work online and the Readme is incomplete.

URL of sample

URL linking to the sample that has the bug.

Describe the bug

  1. The domain in the URLs in the manifest refer to davidchesnut.github.io, but the files are actually hosted on officedev.github.io.

  2. The Readme doesn't tell the user how to see the output of any of the buttons on the task pane. By looking at the code, I was able to see that there is supposed to be a banner at the bottom of the task pane that displays notifications.

  3. The displayStatusMessage() method never runs. It might be that it is never called. So there is no feedback to the user for any of the buttons on the task pane.

    Behavior is the same whether using GitHub hosting or localhost.

To Reproduce

Steps to reproduce the behavior:

  1. Follow the Read me instructions to sideload on Office on the web.
  2. Try any of the functionality in the task pane.

Expected behavior

The readme instructions should work.

Environment

  • Platform [PC desktop, Mac, iOS, Office Online]: on the Web
  • Host [Excel, Word, PowerPoint, etc.]: applies to all three of these
  • Office version number: N/A (Office on the Web)
  • Operating System: Windows
  • Browser (if using Office Online): Edge

Additional context

The sample cannot be updated to support the unified manifest until it is working.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions