update tag from @sync to @SupportSync

Author: hermanwenhe

packages/custom-functions-metadata/src/parseTree.ts

@@ -30,7 +30,7 @@ export interface IFunctionOptions {
   excludeFromAutoComplete?: boolean;
   linkedEntityLoadService?: boolean;
   capturesCallingObject?: boolean;
-  sync?: boolean
+  supportSync?: boolean;
 }
 
 export interface IFunctionParameter {
@@ -133,7 +133,7 @@ const REQUIRESADDRESS = "requiresaddress";
 const REQUIRESPARAMETERADDRESSES = "requiresparameteraddresses";
 const STREAMING = "streaming";
 const VOLATILE = "volatile";
-const SYNC = "sync";
+const SUPPORT_SYNC = "supportsync";
 
 const TYPE_MAPPINGS = {
   [ts.SyntaxKind.NumberKeyword]: "number",
@@ -465,7 +465,7 @@ export function parseTree(sourceCode: string, sourceFileName: string): IParseTre
             !options.excludeFromAutoComplete &&
             !options.linkedEntityLoadService &&
             !options.capturesCallingObject &&
-            !options.sync
+            !options.supportSync
           ) {
             delete functionMetadata.options;
           } else {
@@ -509,8 +509,8 @@ export function parseTree(sourceCode: string, sourceFileName: string): IParseTre
               delete options.capturesCallingObject;
             }
 
-            if (!options.sync) {
-              delete options.sync;
+            if (!options.supportSync) {
+              delete options.supportSync;
             }
           }
 
@@ -674,7 +674,7 @@ function getOptions(
     excludeFromAutoComplete: isExcludedFromAutoComplete(func),
     linkedEntityLoadService: isLinkedEntityLoadService(func),
     capturesCallingObject: capturesCallingObject(func),
-    sync: isSync(func),
+    supportSync: supportSync(func),
   };
 
   if (isAddressRequired(func) || isRequiresParameterAddresses(func)) {
@@ -689,14 +689,6 @@ function getOptions(
     }
   }
 
-  if (isSync(func)) {
-    if (!isInvocationFunction) {
-      const functionPosition = getPosition(func, func.parameters.end);
-      const errorString = `Since @sync is present, the last function parameter should be of type CustomFunctions.Invocation :`;
-      extra.errors.push(logError(errorString, functionPosition));
-    }
-  }
-
   if (
     optionsItem.linkedEntityLoadService &&
     (optionsItem.excludeFromAutoComplete ||
@@ -1082,8 +1074,8 @@ function capturesCallingObject(node: ts.Node): boolean {
  * Returns true if sync tag found in comments
  * @param node jsDocs node
  */
-function isSync(node: ts.Node): boolean {
-  return hasTag(node, SYNC);
+function supportSync(node: ts.Node): boolean {
+  return hasTag(node, SUPPORT_SYNC);
 }
 
 function containsTag(tag: ts.JSDocTag, tagName: string): boolean {