fix: move logic

Author: qinzhouxu

packages/fx-core/src/component/deps-checker/internal/testToolChecker.ts

@@ -81,7 +81,7 @@ export class TestToolChecker implements DepsChecker {
       } else {
         this.telemetryProperties[TelemetryProperties.SymlinkTestToolVersionError] =
           versionRes.error.message;
-        await unlinkSymlink(symlinkDir);
+        await unlinkSymlink(symlinkDir, true);
       }
     }
 

packages/fx-core/src/component/deps-checker/util/fileHelper.ts

@@ -9,11 +9,16 @@ import { v3DefaultHelpLink } from "../constant/helpLink";
 import { Messages } from "../constant/message";
 import { DepsCheckerError } from "../../../error/depCheck";
 
-export async function unlinkSymlink(linkFilePath: string): Promise<void> {
+export async function unlinkSymlink(linkFilePath: string, forceUpdate = false): Promise<void> {
   try {
     const stat = await fs.lstat(linkFilePath);
     if (stat.isSymbolicLink()) {
       await fs.unlink(linkFilePath);
+    } else {
+      if (forceUpdate) {
+        // For regular file or directory, remove it
+        await fs.remove(linkFilePath);
+      }
     }
   } catch (error: unknown) {
     const statError = error as { code?: string };
@@ -28,18 +33,10 @@ export async function createSymlink(
   linkFilePath: string,
   forceUpdate = false
 ): Promise<void> {
-  await unlinkSymlink(linkFilePath);
+  await unlinkSymlink(linkFilePath, forceUpdate);
   // check if destination already exists
   if (await fs.pathExists(linkFilePath)) {
-    if (!forceUpdate) {
-      throw new DepsCheckerError(Messages.symlinkDirAlreadyExist(linkFilePath), v3DefaultHelpLink);
-    }
-    try {
-      // For regular file or directory, unlink will fail so we remove it
-      await fs.remove(linkFilePath);
-    } catch {
-      throw new DepsCheckerError(Messages.symlinkDirAlreadyExist(linkFilePath), v3DefaultHelpLink);
-    }
+    throw new DepsCheckerError(Messages.symlinkDirAlreadyExist(linkFilePath), v3DefaultHelpLink);
   }
 
   return await fs.ensureSymlink(