Skip to content

Commit dc12c6b

Browse files
refactor: remove net6 templates (#13059)
* refactor: remove Azure Functions .net 6 templates and unify the template id * refactor: remove isolated question logic
1 parent 3b8dd69 commit dc12c6b

File tree

142 files changed

+65
-3855
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

142 files changed

+65
-3855
lines changed

packages/fx-core/src/component/generator/templates/templateNames.ts

Lines changed: 0 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,8 @@ export enum TemplateNames {
2424
DashboardTab = "dashboard-tab",
2525
NotificationExpress = "notification-express",
2626
NotificationWebApi = "notification-webapi",
27-
NotificationHttpTriggerIsolated = "notification-http-trigger-isolated",
2827
NotificationHttpTrigger = "notification-http-trigger",
29-
NotificationTimerTriggerIsolated = "notification-timer-trigger-isolated",
3028
NotificationTimerTrigger = "notification-timer-trigger",
31-
NotificationHttpTimerTriggerIsolated = "notification-http-timer-trigger-isolated",
3229
NotificationHttpTimerTrigger = "notification-http-timer-trigger",
3330
CommandAndResponse = "command-and-response",
3431
Workflow = "workflow",
@@ -76,21 +73,12 @@ export const Feature2TemplateName = {
7673
[`${CapabilityOptions.notificationBot().id}:${
7774
NotificationTriggerOptions.functionsHttpTrigger().id
7875
}`]: TemplateNames.NotificationHttpTrigger,
79-
[`${CapabilityOptions.notificationBot().id}:${
80-
NotificationTriggerOptions.functionsHttpTriggerIsolated().id
81-
}`]: TemplateNames.NotificationHttpTriggerIsolated,
8276
[`${CapabilityOptions.notificationBot().id}:${
8377
NotificationTriggerOptions.functionsTimerTrigger().id
8478
}`]: TemplateNames.NotificationTimerTrigger,
85-
[`${CapabilityOptions.notificationBot().id}:${
86-
NotificationTriggerOptions.functionsTimerTriggerIsolated().id
87-
}`]: TemplateNames.NotificationTimerTriggerIsolated,
8879
[`${CapabilityOptions.notificationBot().id}:${
8980
NotificationTriggerOptions.functionsHttpAndTimerTrigger().id
9081
}`]: TemplateNames.NotificationHttpTimerTrigger,
91-
[`${CapabilityOptions.notificationBot().id}:${
92-
NotificationTriggerOptions.functionsHttpAndTimerTriggerIsolated().id
93-
}`]: TemplateNames.NotificationHttpTimerTriggerIsolated,
9482
[`${CapabilityOptions.commandBot().id}:undefined`]: TemplateNames.CommandAndResponse,
9583
[`${CapabilityOptions.workflowBot().id}:undefined`]: TemplateNames.Workflow,
9684
[`${CapabilityOptions.basicBot().id}:undefined`]: TemplateNames.DefaultBot,
@@ -180,47 +168,20 @@ export const inputsToTemplateName: Map<{ [key: string]: any }, TemplateNames> =
180168
},
181169
TemplateNames.NotificationWebApi,
182170
],
183-
[
184-
{
185-
[QuestionNames.ProgrammingLanguage]: ProgrammingLanguage.CSharp,
186-
[QuestionNames.Capabilities]: CapabilityOptions.notificationBot().id,
187-
[QuestionNames.BotTrigger]: NotificationTriggerOptions.functionsHttpTrigger().id,
188-
["isIsolated"]: true,
189-
},
190-
TemplateNames.NotificationHttpTriggerIsolated,
191-
],
192171
[
193172
{
194173
[QuestionNames.Capabilities]: CapabilityOptions.notificationBot().id,
195174
[QuestionNames.BotTrigger]: NotificationTriggerOptions.functionsHttpTrigger().id,
196175
},
197176
TemplateNames.NotificationHttpTrigger,
198177
],
199-
[
200-
{
201-
[QuestionNames.ProgrammingLanguage]: ProgrammingLanguage.CSharp,
202-
[QuestionNames.Capabilities]: CapabilityOptions.notificationBot().id,
203-
[QuestionNames.BotTrigger]: NotificationTriggerOptions.functionsTimerTrigger().id,
204-
["isIsolated"]: true,
205-
},
206-
TemplateNames.NotificationTimerTriggerIsolated,
207-
],
208178
[
209179
{
210180
[QuestionNames.Capabilities]: CapabilityOptions.notificationBot().id,
211181
[QuestionNames.BotTrigger]: NotificationTriggerOptions.functionsTimerTrigger().id,
212182
},
213183
TemplateNames.NotificationTimerTrigger,
214184
],
215-
[
216-
{
217-
[QuestionNames.ProgrammingLanguage]: ProgrammingLanguage.CSharp,
218-
[QuestionNames.Capabilities]: CapabilityOptions.notificationBot().id,
219-
[QuestionNames.BotTrigger]: NotificationTriggerOptions.functionsHttpAndTimerTrigger().id,
220-
["isIsolated"]: true,
221-
},
222-
TemplateNames.NotificationHttpTimerTriggerIsolated,
223-
],
224185
[
225186
{
226187
[QuestionNames.Capabilities]: CapabilityOptions.notificationBot().id,

packages/fx-core/src/question/constants.ts

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -938,17 +938,6 @@ export class NotificationTriggerOptions {
938938
};
939939
}
940940

941-
static functionsTimerTriggerIsolated(): HostTypeTriggerOptionItem {
942-
return {
943-
id: "timer-functions-isolated",
944-
hostType: HostType.Functions,
945-
triggers: [NotificationTriggers.TIMER],
946-
label: getLocalizedString("plugins.bot.triggers.timer-functions.label"),
947-
description: getLocalizedString("plugins.bot.triggers.timer-functions.description"),
948-
detail: getLocalizedString("plugins.bot.triggers.timer-functions.detail"),
949-
};
950-
}
951-
952941
static functionsHttpAndTimerTrigger(): HostTypeTriggerOptionItem {
953942
return {
954943
id: "http-and-timer-functions",
@@ -960,17 +949,6 @@ export class NotificationTriggerOptions {
960949
};
961950
}
962951

963-
static functionsHttpAndTimerTriggerIsolated(): HostTypeTriggerOptionItem {
964-
return {
965-
id: "http-and-timer-functions-isolated",
966-
hostType: HostType.Functions,
967-
triggers: [NotificationTriggers.HTTP, NotificationTriggers.TIMER],
968-
label: getLocalizedString("plugins.bot.triggers.http-and-timer-functions.label"),
969-
description: getLocalizedString("plugins.bot.triggers.http-and-timer-functions.description"),
970-
detail: getLocalizedString("plugins.bot.triggers.http-and-timer-functions.detail"),
971-
};
972-
}
973-
974952
static functionsHttpTrigger(): HostTypeTriggerOptionItem {
975953
return {
976954
id: "http-functions",
@@ -982,17 +960,6 @@ export class NotificationTriggerOptions {
982960
};
983961
}
984962

985-
static functionsHttpTriggerIsolated(): HostTypeTriggerOptionItem {
986-
return {
987-
id: "http-functions-isolated",
988-
hostType: HostType.Functions,
989-
triggers: [NotificationTriggers.HTTP],
990-
label: getLocalizedString("plugins.bot.triggers.http-functions.label"),
991-
description: getLocalizedString("plugins.bot.triggers.http-functions.description"),
992-
detail: getLocalizedString("plugins.bot.triggers.http-functions.detail"),
993-
};
994-
}
995-
996963
static functionsTriggers(): HostTypeTriggerOptionItem[] {
997964
return [
998965
NotificationTriggerOptions.functionsHttpAndTimerTrigger(),

templates/csharp/notification-http-timer-trigger-isolated/.gitignore

Lines changed: 0 additions & 30 deletions
This file was deleted.

templates/csharp/notification-http-timer-trigger-isolated/.{{NewProjectTypeName}}/.gitignore

Lines changed: 0 additions & 10 deletions
This file was deleted.

templates/csharp/notification-http-timer-trigger-isolated/.{{NewProjectTypeName}}/README.md.tpl

Lines changed: 0 additions & 49 deletions
This file was deleted.

templates/csharp/notification-http-timer-trigger-isolated/.{{NewProjectTypeName}}/launchSettings.json.tpl

Lines changed: 0 additions & 25 deletions
This file was deleted.

templates/csharp/notification-http-timer-trigger-isolated/.{{NewProjectTypeName}}/{{NewProjectTypeName}}.{{NewProjectTypeExt}}.tpl

Lines changed: 0 additions & 6 deletions
This file was deleted.

templates/csharp/notification-http-timer-trigger-isolated/.{{NewProjectTypeName}}/{{NewProjectTypeName}}.{{NewProjectTypeExt}}.user.tpl

Lines changed: 0 additions & 14 deletions
This file was deleted.

templates/csharp/notification-http-timer-trigger-isolated/.{{NewProjectTypeName}}/{{ProjectName}}.slnLaunch.user.tpl

Lines changed: 0 additions & 78 deletions
This file was deleted.

templates/csharp/notification-http-timer-trigger-isolated/AdapterWithErrorHandler.cs.tpl

Lines changed: 0 additions & 34 deletions
This file was deleted.

0 commit comments

Comments
 (0)