Skip to content

Commit ec398e0

Browse files
cortinicoOlimpiaZurek
authored andcommitted
Build RNTester Release inside buildAll (facebook#35464)
Summary: Pull Request resolved: facebook#35464 This extends the buildAll task to build both RNTester Debug and Release We can finally do this now as debug and release are fully isolated and don't clash on each other. Changelog: [Internal] [Changed] - Build RNTester Release inside buildAll Reviewed By: cipolleschi Differential Revision: D41521995 fbshipit-source-id: 37ec5e3b55080372f01f2736c1bb020b3776b193
1 parent 6362a58 commit ec398e0

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

.circleci/config.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -716,10 +716,6 @@ jobs:
716716
name: Build & Test React Native using Gradle
717717
command: ./gradlew buildAll
718718

719-
- run:
720-
name: Build RN Tester for Release using Gradle
721-
command: ./gradlew packages:rn-tester:android:app:assembleRelease
722-
723719
- report_bundle_size:
724720
platform: android
725721

build.gradle.kts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,8 @@ tasks.register("buildAll") {
8989
dependsOn(":ReactAndroid:assemble")
9090
// This creates all the Maven artifacts and makes them available in the /android folder
9191
dependsOn(":ReactAndroid:installArchives")
92-
// This builds RN Tester for Hermes/JSC for debug only
93-
dependsOn(":packages:rn-tester:android:app:assembleDebug")
92+
// This builds RN Tester for Hermes/JSC for debug and release
93+
dependsOn(":packages:rn-tester:android:app:assemble")
9494
// This compiles the Unit Test sources (without running them as they're partially broken)
9595
dependsOn(":ReactAndroid:compileDebugUnitTestSources")
9696
dependsOn(":ReactAndroid:compileReleaseUnitTestSources")

0 commit comments

Comments
 (0)