directly look for typing._GenericAlias

OliverKoo · OliverKoo · commit 09365a72c62f · 2019-07-03T11:50:26.000-04:00
diff --git a/ghapp/ghapp/cattrs.py b/ghapp/ghapp/cattrs.py
@@ -51,7 +51,7 @@ def _register_ignore_optional_none(cls, converter=None):
     prev_unstructure = converter._unstructure_func.dispatch(cls)
     optional_attrs = {
         f.name for f in attr.fields(cls)
-        if isinstance(f.type, typing.Union) and type(None) in f.type.__args__
+        if isinstance(f.type, typing._GenericAlias) and type(None) in f.type.__args__
     }
 
     def unstructure_ignoring_optional_none(obj):

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ def _register_ignore_optional_none(cls, converter=None):`
`51`	`51`	`prev_unstructure = converter._unstructure_func.dispatch(cls)`
`52`	`52`	`optional_attrs = {`
`53`	`53`	`f.name for f in attr.fields(cls)`
`54`		`- if isinstance(f.type, typing.Union) and type(None) in f.type.__args__`
	`54`	`+ if isinstance(f.type, typing._GenericAlias) and type(None) in f.type.__args__`
`55`	`55`	`}`
`56`	`56`
`57`	`57`	`def unstructure_ignoring_optional_none(obj):`