fix(actions): rework release workflow (Pycord-Development#3034)

* fix(actions): rework release workflow

* style(pre-commit): auto fixes from pre-commit.com hooks

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Author: Lulalaby

.github/workflows/release.yml

@@ -28,6 +28,7 @@ jobs:
       is_rc: ${{ steps.determine_vars.outputs.is_rc }}
       version: ${{ steps.determine_vars.outputs.version }}
       previous_tag: ${{ steps.determine_vars.outputs.previous_tag }}
+      previous_final_tag: ${{ steps.determine_vars.outputs.previous_final_tag }}
     runs-on: ubuntu-latest
     steps:
       - name: "Checkout Repository"
@@ -41,18 +42,24 @@ jobs:
         env:
           VERSION: ${{ github.event.inputs.version }}
         run: |
-          VALID_VERSION_REGEX='^([0-9]+\.[0-9]+\.[0-9]+((a|b|rc|\.dev|\.post)[0-9]+)?)$'
+          set -euo pipefail
+          VALID_VERSION_REGEX='^[0-9]+\.[0-9]+\.[0-9]+(rc[0-9]+)?$'
           if ! [[ $VERSION =~ $VALID_VERSION_REGEX ]]; then
-            echo "::error::Invalid version string '$VERSION'. Must match PEP 440 (e.g. 1.2.0, 1.2.0rc1, 1.2.0.dev1, 1.2.0a1, 1.2.0b1, 1.2.0.post1)"
+            echo "::error::Invalid version string '$VERSION'. Only releases like 1.2.3 and release candidates like 1.2.3rc1 are supported."
             exit 1
           fi
-          if ! [[ $VERSION =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]] && ! [[ $VERSION =~ ^[0-9]+\.[0-9]+\.[0-9]+rc[0-9]+$ ]]; then
-            echo "::error::Unsupported version string '$VERSION'. Only normal releases (e.g. 1.2.3) and rc (e.g. 1.2.3rc1) are supported at this time."
+          echo "version=$VERSION" >> $GITHUB_OUTPUT
+          PREVIOUS_TAG=$(git describe --tags --abbrev=0 HEAD^ 2>/dev/null || git describe --tags --abbrev=0 2>/dev/null || true)
+          if [[ -z "$PREVIOUS_TAG" ]]; then
+            echo "::error::Could not determine previous tag. Ensure at least one tag exists."
             exit 1
           fi
-          echo "version=$VERSION" >> $GITHUB_OUTPUT
-          PREVIOUS_TAG=$(git describe --tags --abbrev=0 HEAD^)
           echo "previous_tag=${PREVIOUS_TAG}" >> $GITHUB_OUTPUT
+          PREVIOUS_FINAL_TAG=$(git tag --sort=-v:refname | grep -E '^[0-9]+\.[0-9]+\.[0-9]+$' | head -n1 || true)
+          if [[ -z "$PREVIOUS_FINAL_TAG" ]]; then
+            PREVIOUS_FINAL_TAG=$PREVIOUS_TAG
+          fi
+          echo "previous_final_tag=${PREVIOUS_FINAL_TAG}" >> $GITHUB_OUTPUT
           MAJOR_MINOR_VERSION=$(echo $VERSION | grep -oE '^[0-9]+\.[0-9]+')
           echo "branch_name=v${MAJOR_MINOR_VERSION}.x" >> $GITHUB_OUTPUT
           if [[ $VERSION == *rc* ]]; then
@@ -146,17 +153,21 @@ jobs:
         shell: bash
         env:
           VERSION: ${{ inputs.version }}
+          PREVIOUS_TAG: ${{ needs.pre_config.outputs.previous_tag }}
           REPOSITORY: ${{ github.repository }}
           GITHUB_TOKEN: ${{ secrets.ADMIN_GITHUB_TOKEN }}
           BRANCH: ${{ github.ref_name }}
         run: |
           git config user.name "NyuwBot"
           git config user.email "[email protected]"
           DATE=$(date +'%Y-%m-%d')
-          sed -i "/These changes are available on the \`.*\` branch, but have not yet been released\./{N;d;}" CHANGELOG.md
-          sed -i "s/## \[Unreleased\]/## [$VERSION] - $DATE/" CHANGELOG.md
-          sed -i "0,/## \[$VERSION\]/ s|## \[$VERSION\]|## [Unreleased]\n\nThese changes are available on the \`$BRANCH\` branch, but have not yet been released.\n\n### Added\n\n### Changed\n\n### Fixed\n\n### Deprecated\n\n### Removed\n\n&|" CHANGELOG.md
-          sed -i "s|\[unreleased\]:.*|[unreleased]: https://github.com/$REPOSITORY/compare/v$VERSION...HEAD\n[$VERSION]: https://github.com/$REPOSITORY/compare/$(git describe --tags --abbrev=0 @^)...v$VERSION|" CHANGELOG.md
+          python scripts/update_changelog.py \
+            --path CHANGELOG.md \
+            --version "$VERSION" \
+            --previous-tag "$PREVIOUS_TAG" \
+            --branch "$BRANCH" \
+            --repository "$REPOSITORY" \
+            --date "$DATE"
           git add CHANGELOG.md
           git commit -m "chore(release): update CHANGELOG.md for version $VERSION"
       - name: "Commit and Push Changelog to ${{ github.ref_name }}"
@@ -235,67 +246,36 @@ jobs:
   docs_release:
     runs-on: ubuntu-latest
     needs: [lib_release, pre_config]
-    if:
-      ${{ needs.pre_config.outputs.is_rc == 'false' || (needs.pre_config.outputs.is_rc
-      == 'true' && endsWith(needs.pre_config.outputs.version, '0rc1')) }}
     environment: release
     steps:
-      - name: "Sync Versions on Read the Docs"
-        run: |
-          curl --location --request POST 'https://readthedocs.org/api/v3/projects/pycord/sync-versions/' \
-          --header 'Content-Type: application/json' \
-          --header "Authorization: Token ${{ secrets.READTHEDOCS_TOKEN }}"
+      - name: "Checkout repository"
+        uses: actions/checkout@v6
+        with:
+          fetch-depth: 0
+          fetch-tags: true
 
-      - name: "Activate and Show Version on Read the Docs"
+      - name: "Sync and activate version on Read the Docs"
+        env:
+          READTHEDOCS_TOKEN: ${{ secrets.READTHEDOCS_TOKEN }}
         run: |
-          VERSION=${{ needs.pre_config.outputs.version }}
-          MAJOR_MINOR_VERSION=$(echo $VERSION | grep -oE '^[0-9]+\.[0-9]+')
-          HIDDEN=$([[ $VERSION == *rc* ]] && echo true || echo false)
-          if [[ $VERSION == *rc* ]]; then
-            DOCS_VERSION="v${MAJOR_MINOR_VERSION}.x"
-          else
-            DOCS_VERSION="v$VERSION"
-          fi
-          curl --location --request PATCH "https://readthedocs.org/api/v3/projects/pycord/versions/$DOCS_VERSION/" \
-          --header 'Content-Type: application/json' \
-          --header "Authorization: Token ${{ secrets.READTHEDOCS_TOKEN }}" \
-          --data '{
-              "active": true,
-              "hidden": $HIDDEN
-          }'
+          python3 scripts/manage_rtd_version.py \
+            --project pycord \
+            --version "${{ needs.pre_config.outputs.version }}" \
+            --sync
 
   inform_discord:
     runs-on: ubuntu-latest
     needs: [docs_release, lib_release, pre_config]
     environment: release
     steps:
       - name: "Notify Discord"
-        run: |
-          VERSION=${{ needs.pre_config.outputs.version }}
-          MAJOR_MINOR_VERSION=$(echo $VERSION | grep -oE '^[0-9]+\.[0-9]+')
-          DOCS_URL="<https://docs.pycord.dev/en/v$VERSION/changelog.html>"
-          GITHUB_COMPARE_URL="<https://github.com/Pycord-Development/pycord/compare/${{ needs.pre_config.outputs.previous_tag }}...v$VERSION>"
-          GITHUB_RELEASE_URL="<https://github.com/Pycord-Development/pycord/releases/tag/v$VERSION>"
-          PYPI_RELEASE_URL="<https://pypi.org/project/py-cord/$VERSION/>"
-          if [[ $VERSION == *rc* ]]; then
-            ANNOUNCEMENT="## <:pycord:1063211537008955495> Pycord v$VERSION Release Candidate ($MAJOR_MINOR_VERSION) is available!\n\n"
-            ANNOUNCEMENT="${ANNOUNCEMENT}@here\n\n"
-            ANNOUNCEMENT="${ANNOUNCEMENT}This is a pre-release (release candidate) for testing and feedback.\n\n"
-            ANNOUNCEMENT="${ANNOUNCEMENT}You can view the changelog here: <$DOCS_URL>\n\n"
-            ANNOUNCEMENT="${ANNOUNCEMENT}Check out the [GitHub changelog]($GITHUB_COMPARE_URL), [GitHub release page]($GITHUB_RELEASE_URL), and [PyPI release page]($PYPI_RELEASE_URL).\n\n"
-            ANNOUNCEMENT="${ANNOUNCEMENT}You can install this version by running the following command:\n\`\`\`sh\npip install -U py-cord==$VERSION\n\`\`\`\n\n"
-            ANNOUNCEMENT="${ANNOUNCEMENT}Please try it out and let us know your feedback or any issues!"
-          else
-            ANNOUNCEMENT="## <:pycord:1063211537008955495> Pycord v${VERSION} is out!\n\n"
-            ANNOUNCEMENT="${ANNOUNCEMENT}@everyone\n\n"
-            ANNOUNCEMENT="${ANNOUNCEMENT}You can view the changelog here: <$DOCS_URL>\n\n"
-            ANNOUNCEMENT="${ANNOUNCEMENT}Feel free to take a look at the [GitHub changelog]($GITHUB_COMPARE_URL), [GitHub release page]($GITHUB_RELEASE_URL) and the [PyPI release page]($PYPI_RELEASE_URL).\n\n"
-            ANNOUNCEMENT="${ANNOUNCEMENT}You can install this version by running the following command:\n\`\`\`sh\npip install -U py-cord==$VERSION\n\`\`\`"
-          fi
-          curl -H "Content-Type: application/json" \
-            -X POST \
-            -d "{\"content\":\"$ANNOUNCEMENT\",\"allowed_mentions\":{\"parse\":[\"everyone\",\"roles\"]}}" \
-            ${{ secrets.DISCORD_WEBHOOK_URL }}
+        env:
+          VERSION: ${{ needs.pre_config.outputs.version }}
+          PREVIOUS_TAG: ${{ needs.pre_config.outputs.previous_tag }}
+          PREVIOUS_FINAL_TAG: ${{ needs.pre_config.outputs.previous_final_tag }}
+          DISCORD_WEBHOOK_URL: ${{ secrets.DISCORD_WEBHOOK_URL }}
+          REPOSITORY: ${{ github.repository }}
+        run: python scripts/notify_discord.py
 
   determine_milestone_id:
     runs-on: ubuntu-latest

scripts/manage_rtd_version.py

@@ -0,0 +1,116 @@
+import argparse
+import json
+import os
+import re
+import sys
+import urllib.error
+import urllib.request
+
+API_BASE = "https://readthedocs.org/api/v3"
+
+
+def sync_versions(project: str, token: str) -> None:
+    url = f"{API_BASE}/projects/{project}/sync-versions/"
+    req = urllib.request.Request(
+        url,
+        data=json.dumps({}).encode("utf-8"),
+        headers={
+            "Content-Type": "application/json",
+            "Authorization": f"Token {token}",
+        },
+        method="POST",
+    )
+    with urllib.request.urlopen(req) as resp:  # noqa: S310
+        if resp.status >= 300:
+            raise RuntimeError(
+                f"Sync versions failed for {project} with status {resp.status}"
+            )
+
+
+def activate_version(project: str, docs_version: str, hidden: bool, token: str) -> None:
+    url = f"{API_BASE}/projects/{project}/versions/{docs_version}/"
+    payload = {"active": True, "hidden": hidden}
+    req = urllib.request.Request(
+        url,
+        data=json.dumps(payload).encode("utf-8"),
+        headers={
+            "Content-Type": "application/json",
+            "Authorization": f"Token {token}",
+        },
+        method="PATCH",
+    )
+    with urllib.request.urlopen(req) as resp:  # noqa: S310
+        if resp.status >= 300:
+            raise RuntimeError(
+                f"Activating version {docs_version} for {project} failed with status {resp.status}"
+            )
+
+
+def determine_docs_version(version: str) -> tuple[str, bool]:
+    match = re.match(
+        r"^(?P<major>\d+)\.(?P<minor>\d+)\.(?P<patch>\d+)(?P<suffix>rc\d+)?$", version
+    )
+    if not match:
+        raise ValueError(f"Version '{version}' is not in the expected format")
+    major = match.group("major")
+    minor = match.group("minor")
+    suffix = match.group("suffix") or ""
+    hidden = bool(suffix)
+    if hidden:
+        docs_version = f"v{major}.{minor}.x"
+    else:
+        docs_version = f"v{version}"
+    return docs_version, hidden
+
+
+def main() -> None:
+    parser = argparse.ArgumentParser(
+        description="Manage Read the Docs version activation."
+    )
+    parser.add_argument(
+        "--project", default="pycord", help="RTD project slug (default: pycord)"
+    )
+    parser.add_argument(
+        "--version", required=True, help="Release version (e.g., 2.6.0 or 2.6.0rc1)"
+    )
+    parser.add_argument("--token", help="RTD token (overrides READTHEDOCS_TOKEN env)")
+    parser.add_argument(
+        "--sync", action="store_true", help="Sync versions before activating"
+    )
+    parser.add_argument(
+        "--dry-run",
+        action="store_true",
+        help="Print planned actions without calling RTD",
+    )
+    args = parser.parse_args()
+
+    token = args.token or os.environ.get("READTHEDOCS_TOKEN")
+    if not token:
+        sys.exit("Missing Read the Docs token.")
+
+    try:
+        docs_version, hidden = determine_docs_version(args.version)
+    except ValueError as exc:
+        sys.exit(str(exc))
+
+    if args.dry_run:
+        plan = {
+            "project": args.project,
+            "version": args.version,
+            "docs_version": docs_version,
+            "hidden": hidden,
+            "sync": args.sync,
+        }
+        print(json.dumps(plan, indent=2))
+        return
+
+    try:
+        if args.sync:
+            sync_versions(args.project, token)
+        activate_version(args.project, docs_version, hidden, token)
+    except (urllib.error.HTTPError, urllib.error.URLError, RuntimeError) as exc:
+        sys.exit(str(exc))
+
+
+if __name__ == "__main__":
+    main()

scripts/notify_discord.py

@@ -0,0 +1,97 @@
+import argparse
+import json
+import os
+import sys
+import urllib.error
+import urllib.request
+
+
+def build_message(
+    version: str, previous_tag: str, previous_final_tag: str, repo: str
+) -> str:
+    major_minor = version.split(".")[:2]
+    major_minor_str = ".".join(major_minor)
+    docs_url = f"https://docs.pycord.dev/en/v{version}/changelog.html"
+    base_compare = previous_tag
+    if "rc" not in version:
+        base_compare = previous_final_tag or previous_tag
+    compare_url = f"https://github.com/{repo}/compare/{base_compare}...v{version}"
+    release_url = f"https://github.com/{repo}/releases/tag/v{version}"
+    pypi_url = f"https://pypi.org/project/py-cord/{version}/"
+
+    if "rc" in version:
+        heading = f"## <:pycord:1063211537008955495> Pycord v{version} Release Candidate ({major_minor_str}) is available!\n\n"
+        audience = "@here\n\n"
+        preface = (
+            "This is a pre-release (release candidate) for testing and feedback.\n\n"
+        )
+        docs_line = f"You can view the changelog here: <{docs_url}>\n\n"
+        links = f"Check out the [GitHub changelog](<{compare_url}>), [GitHub release page](<{release_url}>), and [PyPI release page](<{pypi_url}>).\n\n"
+        install = f"You can install this version by running the following command:\n```sh\npip install -U py-cord=={version}\n```\n\n"
+        close = "Please try it out and let us know your feedback or any issues!"
+    else:
+        heading = f"## <:pycord:1063211537008955495> Pycord v{version} is out!\n\n"
+        audience = "@everyone\n\n"
+        preface = ""
+        docs_line = f"You can view the changelog here: <{docs_url}>\n\n"
+        links = f"Feel free to take a look at the [GitHub changelog](<{compare_url}>), [GitHub release page](<{release_url}>) and the [PyPI release page](<{pypi_url}>).\n\n"
+        install = f"You can install this version by running the following command:\n```sh\npip install -U py-cord=={version}\n```"
+        close = ""
+
+    return heading + audience + preface + docs_line + links + install + close
+
+
+def send_webhook(webhook_url: str, content: str) -> None:
+    payload = {"content": content, "allowed_mentions": {"parse": ["everyone", "roles"]}}
+    data = json.dumps(payload).encode("utf-8")
+    req = urllib.request.Request(
+        webhook_url,
+        data=data,
+        headers={
+            "Content-Type": "application/json",
+            "User-Agent": "pycord-release-bot/1.0 (+https://github.com/Pycord-Development/pycord)",
+            "Accept": "*/*",
+        },
+        method="POST",
+    )
+    with urllib.request.urlopen(req) as resp:  # noqa: S310
+        if resp.status >= 300:
+            raise RuntimeError(f"Webhook post failed with status {resp.status}")
+
+
+def main() -> None:
+    parser = argparse.ArgumentParser(description="Notify Discord about a release.")
+    parser.add_argument(
+        "--dry-run", action="store_true", help="Print payload instead of sending"
+    )
+    parser.add_argument(
+        "--webhook-url", help="Webhook URL (overrides DISCORD_WEBHOOK_URL)"
+    )
+    args = parser.parse_args()
+
+    version = os.environ.get("VERSION")
+    previous_tag = os.environ.get("PREVIOUS_TAG")
+    previous_final_tag = os.environ.get("PREVIOUS_FINAL_TAG")
+    webhook_url = args.webhook_url or os.environ.get("DISCORD_WEBHOOK_URL")
+    repo = os.environ.get("REPOSITORY")
+
+    if not all([version, previous_tag, repo]) or (not args.dry_run and not webhook_url):
+        sys.exit("Missing required environment variables.")
+
+    message = build_message(
+        version, previous_tag, previous_final_tag or previous_tag, repo
+    )
+
+    if args.dry_run:
+        payload = {
+            "content": message,
+            "allowed_mentions": {"parse": ["everyone", "roles"]},
+        }
+        print(json.dumps(payload, indent=2))
+        return
+
+    send_webhook(webhook_url, message)
+
+
+if __name__ == "__main__":
+    main()