Skip to content

Commit 790f610

Browse files
author
Egor Lindberg
committed
fix issues for lib lint
1 parent aa23b85 commit 790f610

35 files changed

+4005
-382
lines changed

‎Example/ORCarousel.xcodeproj/project.pbxproj‎

Lines changed: 23 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
/* End PBXContainerItemProxy section */
2929

3030
/* Begin PBXFileReference section */
31-
1323D82EE6E0C2298AEBBD62 /* README.md */ = {isa = PBXFileReference; includeInIndex = 1; name = README.md; path = ../README.md; sourceTree = "<group>"; };
31+
1323D82EE6E0C2298AEBBD62 /* README.md */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = net.daringfireball.markdown; name = README.md; path = ../README.md; sourceTree = "<group>"; };
3232
29E526F856D370E086B640DF /* Pods-ORCarousel_Example.debug.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-ORCarousel_Example.debug.xcconfig"; path = "Target Support Files/Pods-ORCarousel_Example/Pods-ORCarousel_Example.debug.xcconfig"; sourceTree = "<group>"; };
3333
43B6F0C6EE865A6BE8CBFB10 /* Pods-ORCarousel_Example.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-ORCarousel_Example.release.xcconfig"; path = "Target Support Files/Pods-ORCarousel_Example/Pods-ORCarousel_Example.release.xcconfig"; sourceTree = "<group>"; };
3434
4E2B28B95F9C736919D0DBBB /* Pods_ORCarousel_Example.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = Pods_ORCarousel_Example.framework; sourceTree = BUILT_PRODUCTS_DIR; };
@@ -43,9 +43,9 @@
4343
607FACEA1AFB9204008FA782 /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
4444
607FACEB1AFB9204008FA782 /* Tests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Tests.swift; sourceTree = "<group>"; };
4545
8BF35B28F02AB981318C3C25 /* Pods-ORCarousel_Tests.debug.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-ORCarousel_Tests.debug.xcconfig"; path = "Target Support Files/Pods-ORCarousel_Tests/Pods-ORCarousel_Tests.debug.xcconfig"; sourceTree = "<group>"; };
46-
A695A1FF5FB7CAB99E2D28A7 /* LICENSE */ = {isa = PBXFileReference; includeInIndex = 1; name = LICENSE; path = ../LICENSE; sourceTree = "<group>"; };
46+
A695A1FF5FB7CAB99E2D28A7 /* LICENSE */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text; name = LICENSE; path = ../LICENSE; sourceTree = "<group>"; };
4747
DF69CCFE50F293E138129CE0 /* Pods-ORCarousel_Tests.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-ORCarousel_Tests.release.xcconfig"; path = "Target Support Files/Pods-ORCarousel_Tests/Pods-ORCarousel_Tests.release.xcconfig"; sourceTree = "<group>"; };
48-
EA6E14874C8C7945362E6B9E /* ORCarousel.podspec */ = {isa = PBXFileReference; includeInIndex = 1; name = ORCarousel.podspec; path = ../ORCarousel.podspec; sourceTree = "<group>"; };
48+
EA6E14874C8C7945362E6B9E /* ORCarousel.podspec */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text; name = ORCarousel.podspec; path = ../ORCarousel.podspec; sourceTree = "<group>"; };
4949
F379AB5F503405B5320D3A20 /* Pods_ORCarousel_Tests.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = Pods_ORCarousel_Tests.framework; sourceTree = BUILT_PRODUCTS_DIR; };
5050
/* End PBXFileReference section */
5151

@@ -156,7 +156,6 @@
156156
8BF35B28F02AB981318C3C25 /* Pods-ORCarousel_Tests.debug.xcconfig */,
157157
DF69CCFE50F293E138129CE0 /* Pods-ORCarousel_Tests.release.xcconfig */,
158158
);
159-
name = Pods;
160159
path = Pods;
161160
sourceTree = "<group>";
162161
};
@@ -209,7 +208,7 @@
209208
isa = PBXProject;
210209
attributes = {
211210
LastSwiftUpdateCheck = 0830;
212-
LastUpgradeCheck = 0830;
211+
LastUpgradeCheck = 1220;
213212
ORGANIZATIONNAME = CocoaPods;
214213
TargetAttributes = {
215214
607FACCF1AFB9204008FA782 = {
@@ -225,7 +224,7 @@
225224
};
226225
buildConfigurationList = 607FACCB1AFB9204008FA782 /* Build configuration list for PBXProject "ORCarousel" */;
227226
compatibilityVersion = "Xcode 3.2";
228-
developmentRegion = English;
227+
developmentRegion = en;
229228
hasScannedForEncodings = 0;
230229
knownRegions = (
231230
en,
@@ -311,10 +310,12 @@
311310
inputPaths = (
312311
"${PODS_ROOT}/Target Support Files/Pods-ORCarousel_Example/Pods-ORCarousel_Example-frameworks.sh",
313312
"${BUILT_PRODUCTS_DIR}/ORCarousel/ORCarousel.framework",
313+
"${BUILT_PRODUCTS_DIR}/PureLayout/PureLayout.framework",
314314
);
315315
name = "[CP] Embed Pods Frameworks";
316316
outputPaths = (
317317
"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/ORCarousel.framework",
318+
"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/PureLayout.framework",
318319
);
319320
runOnlyForDeploymentPostprocessing = 0;
320321
shellPath = /bin/sh;
@@ -397,6 +398,7 @@
397398
isa = XCBuildConfiguration;
398399
buildSettings = {
399400
ALWAYS_SEARCH_USER_PATHS = NO;
401+
CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
400402
CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
401403
CLANG_CXX_LIBRARY = "libc++";
402404
CLANG_ENABLE_MODULES = YES;
@@ -405,14 +407,17 @@
405407
CLANG_WARN_BOOL_CONVERSION = YES;
406408
CLANG_WARN_COMMA = YES;
407409
CLANG_WARN_CONSTANT_CONVERSION = YES;
410+
CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
408411
CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
409412
CLANG_WARN_EMPTY_BODY = YES;
410413
CLANG_WARN_ENUM_CONVERSION = YES;
411414
CLANG_WARN_INFINITE_RECURSION = YES;
412415
CLANG_WARN_INT_CONVERSION = YES;
413416
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
417+
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
414418
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
415419
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
420+
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
416421
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
417422
CLANG_WARN_STRICT_PROTOTYPES = YES;
418423
CLANG_WARN_SUSPICIOUS_MOVE = YES;
@@ -438,18 +443,20 @@
438443
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
439444
GCC_WARN_UNUSED_FUNCTION = YES;
440445
GCC_WARN_UNUSED_VARIABLE = YES;
441-
IPHONEOS_DEPLOYMENT_TARGET = 9.3;
446+
IPHONEOS_DEPLOYMENT_TARGET = 12.0;
442447
MTL_ENABLE_DEBUG_INFO = YES;
443448
ONLY_ACTIVE_ARCH = YES;
444449
SDKROOT = iphoneos;
445450
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
451+
SWIFT_VERSION = 5.0;
446452
};
447453
name = Debug;
448454
};
449455
607FACEE1AFB9204008FA782 /* Release */ = {
450456
isa = XCBuildConfiguration;
451457
buildSettings = {
452458
ALWAYS_SEARCH_USER_PATHS = NO;
459+
CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
453460
CLANG_CXX_LANGUAGE_STANDARD = "gnu++0x";
454461
CLANG_CXX_LIBRARY = "libc++";
455462
CLANG_ENABLE_MODULES = YES;
@@ -458,14 +465,17 @@
458465
CLANG_WARN_BOOL_CONVERSION = YES;
459466
CLANG_WARN_COMMA = YES;
460467
CLANG_WARN_CONSTANT_CONVERSION = YES;
468+
CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
461469
CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
462470
CLANG_WARN_EMPTY_BODY = YES;
463471
CLANG_WARN_ENUM_CONVERSION = YES;
464472
CLANG_WARN_INFINITE_RECURSION = YES;
465473
CLANG_WARN_INT_CONVERSION = YES;
466474
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
475+
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
467476
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
468477
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
478+
CLANG_WARN_QUOTED_INCLUDE_IN_FRAMEWORK_HEADER = YES;
469479
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
470480
CLANG_WARN_STRICT_PROTOTYPES = YES;
471481
CLANG_WARN_SUSPICIOUS_MOVE = YES;
@@ -484,10 +494,11 @@
484494
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
485495
GCC_WARN_UNUSED_FUNCTION = YES;
486496
GCC_WARN_UNUSED_VARIABLE = YES;
487-
IPHONEOS_DEPLOYMENT_TARGET = 9.3;
497+
IPHONEOS_DEPLOYMENT_TARGET = 12.0;
488498
MTL_ENABLE_DEBUG_INFO = NO;
489499
SDKROOT = iphoneos;
490500
SWIFT_OPTIMIZATION_LEVEL = "-Owholemodule";
501+
SWIFT_VERSION = 5.0;
491502
VALIDATE_PRODUCT = YES;
492503
};
493504
name = Release;
@@ -503,7 +514,7 @@
503514
PRODUCT_BUNDLE_IDENTIFIER = "org.cocoapods.demo.$(PRODUCT_NAME:rfc1034identifier)";
504515
PRODUCT_NAME = "$(TARGET_NAME)";
505516
SWIFT_SWIFT3_OBJC_INFERENCE = Default;
506-
SWIFT_VERSION = 4.0;
517+
SWIFT_VERSION = 5.0;
507518
};
508519
name = Debug;
509520
};
@@ -518,7 +529,7 @@
518529
PRODUCT_BUNDLE_IDENTIFIER = "org.cocoapods.demo.$(PRODUCT_NAME:rfc1034identifier)";
519530
PRODUCT_NAME = "$(TARGET_NAME)";
520531
SWIFT_SWIFT3_OBJC_INFERENCE = Default;
521-
SWIFT_VERSION = 4.0;
532+
SWIFT_VERSION = 5.0;
522533
};
523534
name = Release;
524535
};
@@ -539,7 +550,7 @@
539550
PRODUCT_BUNDLE_IDENTIFIER = "org.cocoapods.$(PRODUCT_NAME:rfc1034identifier)";
540551
PRODUCT_NAME = "$(TARGET_NAME)";
541552
SWIFT_SWIFT3_OBJC_INFERENCE = Default;
542-
SWIFT_VERSION = 4.0;
553+
SWIFT_VERSION = 5.0;
543554
TEST_HOST = "$(BUILT_PRODUCTS_DIR)/ORCarousel_Example.app/ORCarousel_Example";
544555
};
545556
name = Debug;
@@ -557,7 +568,7 @@
557568
PRODUCT_BUNDLE_IDENTIFIER = "org.cocoapods.$(PRODUCT_NAME:rfc1034identifier)";
558569
PRODUCT_NAME = "$(TARGET_NAME)";
559570
SWIFT_SWIFT3_OBJC_INFERENCE = Default;
560-
SWIFT_VERSION = 4.0;
571+
SWIFT_VERSION = 5.0;
561572
TEST_HOST = "$(BUILT_PRODUCTS_DIR)/ORCarousel_Example.app/ORCarousel_Example";
562573
};
563574
name = Release;

‎Example/ORCarousel.xcodeproj/xcshareddata/xcschemes/ORCarousel-Example.xcscheme‎

Lines changed: 10 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Scheme
3-
LastUpgradeVersion = "0900"
3+
LastUpgradeVersion = "1220"
44
version = "1.3">
55
<BuildAction
66
parallelizeBuildables = "YES"
@@ -40,8 +40,16 @@
4040
buildConfiguration = "Debug"
4141
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
4242
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
43-
language = ""
4443
shouldUseLaunchSchemeArgsEnv = "YES">
44+
<MacroExpansion>
45+
<BuildableReference
46+
BuildableIdentifier = "primary"
47+
BlueprintIdentifier = "607FACCF1AFB9204008FA782"
48+
BuildableName = "ORCarousel_Example.app"
49+
BlueprintName = "ORCarousel_Example"
50+
ReferencedContainer = "container:ORCarousel.xcodeproj">
51+
</BuildableReference>
52+
</MacroExpansion>
4553
<Testables>
4654
<TestableReference
4755
skipped = "NO">
@@ -54,23 +62,11 @@
5462
</BuildableReference>
5563
</TestableReference>
5664
</Testables>
57-
<MacroExpansion>
58-
<BuildableReference
59-
BuildableIdentifier = "primary"
60-
BlueprintIdentifier = "607FACCF1AFB9204008FA782"
61-
BuildableName = "ORCarousel_Example.app"
62-
BlueprintName = "ORCarousel_Example"
63-
ReferencedContainer = "container:ORCarousel.xcodeproj">
64-
</BuildableReference>
65-
</MacroExpansion>
66-
<AdditionalOptions>
67-
</AdditionalOptions>
6865
</TestAction>
6966
<LaunchAction
7067
buildConfiguration = "Debug"
7168
selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB"
7269
selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB"
73-
language = ""
7470
launchStyle = "0"
7571
useCustomWorkingDirectory = "NO"
7672
ignoresPersistentStateOnLaunch = "NO"
@@ -87,8 +83,6 @@
8783
ReferencedContainer = "container:ORCarousel.xcodeproj">
8884
</BuildableReference>
8985
</BuildableProductRunnable>
90-
<AdditionalOptions>
91-
</AdditionalOptions>
9286
</LaunchAction>
9387
<ProfileAction
9488
buildConfiguration = "Release"

‎Example/ORCarousel/AppDelegate.swift‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
1414
var window: UIWindow?
1515

1616

17-
func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplicationLaunchOptionsKey: Any]?) -> Bool {
17+
func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?) -> Bool {
1818
// Override point for customization after application launch.
1919
return true
2020
}

‎Example/Podfile‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
use_frameworks!
22

3-
platform :ios, '9.0'
3+
platform :ios, '10.0'
44

55
target 'ORCarousel_Example' do
66
pod 'ORCarousel', :path => '../'

‎Example/Podfile.lock‎

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,9 @@ PODS:
44
- FBSnapshotTestCase/Core (2.1.4)
55
- FBSnapshotTestCase/SwiftSupport (2.1.4):
66
- FBSnapshotTestCase/Core
7-
- ORCarousel (0.1.0)
7+
- ORCarousel (1.0.0):
8+
- PureLayout
9+
- PureLayout (3.1.6)
810

911
DEPENDENCIES:
1012
- FBSnapshotTestCase (~> 2.1.4)
@@ -13,15 +15,17 @@ DEPENDENCIES:
1315
SPEC REPOS:
1416
trunk:
1517
- FBSnapshotTestCase
18+
- PureLayout
1619

1720
EXTERNAL SOURCES:
1821
ORCarousel:
1922
:path: "../"
2023

2124
SPEC CHECKSUMS:
2225
FBSnapshotTestCase: 094f9f314decbabe373b87cc339bea235a63e07a
23-
ORCarousel: 9f472bf04e639d39fbb64fb37657f0bab3010481
26+
ORCarousel: 52fbffabffc6e80b03f99eb8ada20c9bc3c35266
27+
PureLayout: bd3c4ec3a3819ad387c99ebb72c6b129c3ed4d2d
2428

25-
PODFILE CHECKSUM: f38f704b444c58bf6b08d405685896a87851600d
29+
PODFILE CHECKSUM: 785c96dd158566785cb1b5e66e716fc138ebe7ae
2630

2731
COCOAPODS: 1.8.3

‎Example/Pods/Local Podspecs/ORCarousel.podspec.json‎

Lines changed: 13 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎Example/Pods/Manifest.lock‎

Lines changed: 7 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)