Skip to content

Commit 0778f43

Browse files
authored
Remove default store_id filter from orderIds endpoint. (#36)
1 parent d7a2419 commit 0778f43

File tree

5 files changed

+5
-19
lines changed

5 files changed

+5
-19
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
<?xml version="1.0"?>
22
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
3-
<module name="Ometria_AbandonedCarts" setup_version="2.3.1"/>
3+
<module name="Ometria_AbandonedCarts" setup_version="2.3.2"/>
44
</config>

app/code/Ometria/Api/Controller/V1/OrderIds.php

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ private function getFilters()
133133
)
134134
],
135135
OrderInterface::STORE_ID => [
136-
self::EQUAL_CONDITION => $this->getStoreFilterId()
136+
self::EQUAL_CONDITION => $this->getRequestParam(self::STORE_ID)
137137
]
138138
];
139139
}
@@ -147,20 +147,6 @@ private function getRequestParam($key)
147147
return $this->getRequest()->getParam($key, null);
148148
}
149149

150-
/**
151-
* @return int
152-
*/
153-
private function getStoreFilterId()
154-
{
155-
if ($this->getRequestParam(self::STORE_ID) !== null) {
156-
$storeId = (int) $this->getRequestParam(self::STORE_ID);
157-
} else {
158-
$storeId = $this->storeManager->getStore()->getId();
159-
}
160-
161-
return $storeId;
162-
}
163-
164150
/**
165151
* @param $date
166152
* @return false|string
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
<?xml version="1.0"?>
22
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
3-
<module name="Ometria_Api" setup_version="2.3.1"/>
3+
<module name="Ometria_Api" setup_version="2.3.2"/>
44
</config>
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
<?xml version="1.0"?>
22
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
3-
<module name="Ometria_Core" setup_version="2.3.1"/>
3+
<module name="Ometria_Core" setup_version="2.3.2"/>
44
</config>

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "ometria/magento2",
33
"type": "magento2-module",
4-
"version": "2.3.1",
4+
"version": "2.3.2",
55
"description": "Dev composer package for Ometria Extension",
66
"authors": [
77
{

0 commit comments

Comments
 (0)