Bug Fix: Catch exceptions in Helper/Ping.php (#19)

LRotherfield · chris-pook · web-flow · commit 238aec5a64ea · 2020-10-29T10:15:46.000Z
* Bug Fix: Catch exceptions in Helper/Ping.php

Exceptions are not caught in the Ping helper because the catch clause only catches instances of `Ometria\Core\Helper\Exception` due to a missing `\`

* Update composer.json

Co-authored-by: Chris Pook &lt;chris.pook@absolutecommerce.co.uk&gt;
diff --git a/app/code/Ometria/Core/Helper/Ping.php b/app/code/Ometria/Core/Helper/Ping.php
@@ -104,7 +104,7 @@ protected function _ping($parameters = array()) {
                 $ometriaConfigHelper->log("Ping failed: Error $errorNum - $errorStr", Zend_Log::ERR);
                 return false;
             }
-        } catch (Exception $e) {
+        } catch (\Exception $e) {
             $ometriaConfigHelper->log($e->getMessage());
             return false;
         }
diff --git a/composer.json b/composer.json
@@ -1,7 +1,7 @@
 {
     "name": "ometria/magento2",
     "type": "magento2-module",
-    "version": "2.0.3",
+    "version": "2.0.4",
     "description": "Dev composer package for Ometria Extension",
     "authors": [
         {

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ protected function _ping($parameters = array()) {`
`104`	`104`	`$ometriaConfigHelper->log("Ping failed: Error $errorNum - $errorStr", Zend_Log::ERR);`
`105`	`105`	`return false;`
`106`	`106`	`}`
`107`		`- } catch (Exception $e) {`
	`107`	`+ } catch (\Exception $e) {`
`108`	`108`	`$ometriaConfigHelper->log($e->getMessage());`
`109`	`109`	`return false;`
`110`	`110`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "ometria/magento2",`
`3`	`3`	`"type": "magento2-module",`
`4`		`- "version": "2.0.3",`
	`4`	`+ "version": "2.0.4",`
`5`	`5`	`"description": "Dev composer package for Ometria Extension",`
`6`	`6`	`"authors": [`
`7`	`7`	`{`