fix(warn): Fix C4100, unused function parameters.

Author: OmniBlade

.github/workflows/openw3d.yml

@@ -23,7 +23,7 @@ jobs:
             cmake-args: -GNinja -DCMAKE_BUILD_TYPE=Release
             shell: pwsh
             arch: x86
-            options: "/W4;/WX;/wd4840;/wd4456;/wd4702;/wd4100"
+            options: "/W4;/WX;/wd4840;/wd4456;/wd4702"
           - name: MSVC x64
             os: windows-latest
             cmake-args: -GNinja -DCMAKE_BUILD_TYPE=Release

Code/BinkMovie/NullMoviePlayer.h

@@ -24,7 +24,7 @@ class FontCharsClass;
 class NullMovieClass : public MovieClass
 {
 	public:
-		NullMovieClass(const char* filename, const char* subtitlename, FontCharsClass* font) {}
+		NullMovieClass(const char* /* filename */, const char* /* subtitlename */, FontCharsClass* /* font */) {}
 		~NullMovieClass() override {}
 
 		void Update() override {}

Code/Combat/WeatherMgr.cpp

@@ -1272,7 +1272,7 @@ void WeatherSystemClass::Get_Obj_Space_Bounding_Box (AABoxClass &box) const
  * HISTORY:                                                                                    *
  *   03/06/01    IML : Created.                                                                *
  *=============================================================================================*/
-RainSystemClass::RainSystemClass (PhysicsSceneClass *scene, float particledensity, WindClass *wind, SoundEnvironmentClass *soundenvironment, bool prime)
+RainSystemClass::RainSystemClass (PhysicsSceneClass *scene, float particledensity, WindClass * /* wind */, SoundEnvironmentClass *soundenvironment, bool prime)
 	: WeatherSystemClass (scene, 20.0f, 20.0f, particledensity, 0.2f, 0.15f, 0.45f, 15.0f, Vector2 (0.0f, 0.0f), Vector2 (1.0f, 0.5f), PAGE_COUNT, true, 0.1f, 0.2f, WeatherSystemClass::RENDER_MODE_AXIS_ALIGNED, false, prime),
 	  SoundEnvironment (soundenvironment)
 {
@@ -1355,7 +1355,7 @@ bool RainSystemClass::Update (WindClass *wind, const Vector3 &cameraposition)
  * HISTORY:                                                                                    *
  *   03/06/01    IML : Created.                                                                *
  *=============================================================================================*/
-SnowSystemClass::SnowSystemClass (PhysicsSceneClass *scene, float particledensity, WindClass *wind, bool prime)
+SnowSystemClass::SnowSystemClass (PhysicsSceneClass *scene, float particledensity, WindClass * /* wind */, bool prime)
 	: WeatherSystemClass (scene, 40.0f, 20.0f, particledensity, 0.1f, 0.32f, 0.32f, 3.5f, Vector2 (0.0f, 0.5f), Vector2 (1.0f, 0.25f), PAGE_COUNT, false, 1.0f, 2.0f, WeatherSystemClass::RENDER_MODE_CAMERA_ALIGNED, true, prime)
 {
 }
@@ -1392,7 +1392,7 @@ bool SnowSystemClass::Update (WindClass *wind, const Vector3 &cameraposition)
  * HISTORY:                                                                                    *
  *   03/06/01    IML : Created.                                                                *
  *=============================================================================================*/
-AshSystemClass::AshSystemClass (PhysicsSceneClass *scene, float particledensity, WindClass *wind, bool prime)
+AshSystemClass::AshSystemClass (PhysicsSceneClass *scene, float particledensity, WindClass * /* wind */, bool prime)
 	: WeatherSystemClass (scene, 40.0f, 20.0f, particledensity, 0.1f, 0.32f, 0.32f, 3.0f, Vector2 (0.0f, 0.75f), Vector2 (1.0f, 0.25f), PAGE_COUNT, false, 1.0f, 2.0f, WeatherSystemClass::RENDER_MODE_CAMERA_ALIGNED, true, prime)
 {
 }

Code/Combat/action.cpp

@@ -156,7 +156,7 @@ class	ActionCodeClass : public PersistClass {
 		}
 	}
 
-	virtual	void	Modify_Parameters( const SafeActionParamsStruct & parameters, bool modify_move, bool modify_attack ) {}
+	virtual	void	Modify_Parameters( const SafeActionParamsStruct & /* parameters */, bool /* modify_move */, bool /* modify_attack */ ) {}
 
 	virtual	void	Set_Action( ActionClass * action )	{ WWASSERT( action ); WWASSERT( Action == NULL ); Action = action; }
 	virtual	void	Shutdown( void )						{ Action = NULL; }

Code/Combat/animcontrol.h

@@ -71,8 +71,8 @@ struct AnimationDataRecord {
 	float			Frame;
 	float			Weight;
 
-	bool operator == (AnimationDataRecord const & rec) const	{ return false; }
-	bool operator != (AnimationDataRecord const & rec) const	{ return true; }
+	bool operator == (AnimationDataRecord const & ) const	{ return false; }
+	bool operator != (AnimationDataRecord const & ) const	{ return true; }
 };
 
 typedef	DynamicVectorClass<AnimationDataRecord>	AnimationDataList;

Code/Combat/armedgameobj.cpp

@@ -475,7 +475,7 @@ void	ArmedGameObj::Init_Muzzle_Bones( void )
 	}
 }
 
-bool	ArmedGameObj::Set_Targeting( const Vector3 & pos, bool do_tilt )
+bool	ArmedGameObj::Set_Targeting( const Vector3 & pos, bool /* do_tilt */ )
 {
 	TargetingPos = pos;
 	// Move the turret to match the target

Code/Combat/backgroundmgr.cpp

@@ -363,7 +363,7 @@ void HazeClass::Render()
  * HISTORY:                                                                                    *
  *   10/18/00    IML : Created.                                                                *
  *=============================================================================================*/
-StarfieldClass::StarfieldClass (float extent, unsigned starcount)
+StarfieldClass::StarfieldClass (float /* extent */, unsigned starcount)
 {
 	const Vector3 white (1.0f, 1.0f, 1.0f);
 
@@ -2158,7 +2158,7 @@ bool WarBlitzClass::Update (Matrix3D &t, Vector3 &additivecolor)
  * HISTORY:                                                                                    *
  *   06/26/01    IML : Created.                                                                *
  *=============================================================================================*/
-void WarBlitzClass::Render (RenderInfoClass &rinfo)
+void WarBlitzClass::Render (RenderInfoClass &/* rinfo */)
 {
 	WarBlitzGlow->Render();
 }
@@ -3631,7 +3631,7 @@ bool BackgroundMgrClass::Set_War_Blitz (float intensity, float ramptime)
  * HISTORY:                                                                                    *
  *   09/15/00    IML : Created.                                                                *
  *=============================================================================================*/
-bool BackgroundMgrClass::Set_War_Blitz (float intensity, float startdistance, float enddistance, float heading, float distribution, float ramptime, bool override)
+bool BackgroundMgrClass::Set_War_Blitz (float intensity, float startdistance, float enddistance, float heading, float distribution, float ramptime, bool /* override */)
 {
 	if ((intensity >= 0.0f) && (intensity <= 1.0f) && (startdistance >= 0.0f) && (startdistance <= 1.0f) &&
 		 (enddistance >= 0.0f) && (enddistance <= 1.0f) && (heading >= 0.0f) && (heading <= 360.0f) &&

Code/Combat/basecontroller.cpp

@@ -300,7 +300,7 @@ BaseControllerClass::On_Vehicle_Generated (VehicleGameObj *vehicle)
 }
 
 
-void BaseControllerClass::On_Vehicle_Delivered(VehicleGameObj *vehicle)
+void BaseControllerClass::On_Vehicle_Delivered(VehicleGameObj * /* vehicle */)
 {
 	SoldierGameObj* thePlayer = COMBAT_STAR;
 	bool isAllied = (thePlayer && (thePlayer->Get_Player_Type() == PlayerType));
@@ -459,7 +459,7 @@ BaseControllerClass::Are_All_Buildings_Destroyed (void)
 //
 ////////////////////////////////////////////////////////////////
 void
-BaseControllerClass::Notify_Team (Notification event, BuildingType type)
+BaseControllerClass::Notify_Team (Notification /* event */, BuildingType /* type */)
 {	
 	return ;
 }

Code/Combat/beacongameobj.cpp

@@ -1033,7 +1033,7 @@ BeaconGameObj::Get_Enemy_Base (void)
 //
 ////////////////////////////////////////////////////////////////
 bool
-BeaconGameObj::Can_Place_Here (const Vector3 &position)
+BeaconGameObj::Can_Place_Here (const Vector3 &/* position */)
 {
 	// always return true;
 	return true;
@@ -1315,7 +1315,7 @@ BeaconGameObj::Get_Owner (void)
 //
 ////////////////////////////////////////////////////////////////
 void
-BeaconGameObj::Completely_Damaged (const OffenseObjectClass &damager)
+BeaconGameObj::Completely_Damaged (const OffenseObjectClass &/* damager */)
 {
 	if (!Is_Delete_Pending()) {
 		Set_State (STATE_DISARMED);

Code/Combat/buildingmonitor.cpp

@@ -45,7 +45,7 @@
 //
 ////////////////////////////////////////////////////////////////
 void
-BuildingMonitorClass::Killed (GameObject *game_obj, GameObject *killer)
+BuildingMonitorClass::Killed (GameObject * /* game_obj */, GameObject * /* killer */)
 {
 	WWASSERT (Building != NULL);
 
@@ -63,7 +63,7 @@ BuildingMonitorClass::Killed (GameObject *game_obj, GameObject *killer)
 //
 ////////////////////////////////////////////////////////////////
 void
-BuildingMonitorClass::Damaged (GameObject *game_obj, GameObject *killer, float amount )
+BuildingMonitorClass::Damaged (GameObject * /* game_obj */, GameObject *killer, float amount )
 {
 	// Only report damage not heal
 	if (amount > 0.0f) {
@@ -100,7 +100,7 @@ BuildingMonitorClass::Damaged (GameObject *game_obj, GameObject *killer, float a
 //
 ////////////////////////////////////////////////////////////////
 void
-BuildingMonitorClass::Custom (GameObject *game_obj, int type, intptr_t param, GameObject *sender)
+BuildingMonitorClass::Custom (GameObject * /* game_obj */, int type, intptr_t /* param */, GameObject * /* sender */)
 {
 	WWASSERT (Building != NULL);