cleanup(warn): Fix warning C4805.

Author: OmniBlade

Code/Commando/combatgmode.cpp

@@ -1213,7 +1213,7 @@ void CombatGameModeClass::Load_Registry_Keys(void)
 
 		//TSS
 		DefaultToFirstPerson = registry->Get_Int( "DefaultToFirstPerson", DefaultToFirstPerson );
-		CombatManager::Set_First_Person_Default(DefaultToFirstPerson == true);
+		CombatManager::Set_First_Person_Default(DefaultToFirstPerson != 0);
 	}
 	delete registry;
 }

Code/Launcher/dictionary.h

@@ -88,7 +88,7 @@ class Dictionary
   uint32           size;       // size of table
   uint32           tableBits;  // table is 2^tableBits big
   uint32           log2Size;   // Junk variable
-  bit8             keepSize;   // If true don't shrink or expand
+  bool             keepSize;   // If true don't shrink or expand
 
   uint32           (* hashFunc)(K &key);   // User provided hash function
   uint32           keyHash(IN K &key);     // This will reduce to correct range

Code/Launcher/findpatch.cpp

@@ -165,7 +165,7 @@ void Delete_Patches(ConfigFile &config)
   //
   // Loop through all the application directories in the config file
   //
-  while (Get_App_Dir(dir,MAX_PATH,config,i++)==true)
+  while (Get_App_Dir(dir,MAX_PATH,config,i++)!=0)
   {
     // Make sure path is at least 3 for "c:\".  I really hope nobody's
     //   dumb enough to install a game to the root directory. (It's OK though

Code/Tools/LevelEdit/Export.cpp

@@ -693,9 +693,9 @@ ExporterClass::Delete_File (LPCTSTR filename)
 		if ((attributes != 0xFFFFFFFF) &&
 			 ((attributes & FILE_ATTRIBUTE_DIRECTORY) == FILE_ATTRIBUTE_DIRECTORY))
 		{
-			retval = (::RemoveDirectory (filename) == true);
+			retval = (::RemoveDirectory (filename) != 0);
 		} else {
-			retval = (::DeleteFile (filename) == true);
+			retval = (::DeleteFile (filename) != 0);
 		}
 	}
 

Code/Tools/LevelEdit/VisStatsDialog.cpp

@@ -281,7 +281,7 @@ VisSectorSortCompareFn (LPARAM param1, LPARAM param2, LPARAM sort_info)
 	VisSectorStatsClass *stats2 = (VisSectorStatsClass *)param2;
 
 	LONG column_id = LOWORD (sort_info);
-	BOOL ascending	= HIWORD (sort_info);
+	bool ascending	= HIWORD (sort_info) != 0;
 
 	if (stats1 != NULL && stats2 != NULL) {
 
@@ -302,7 +302,7 @@ VisSectorSortCompareFn (LPARAM param1, LPARAM param2, LPARAM sort_info)
 	//
 	//	Invert the sort if necessary
 	//
-	if (ascending != true) {
+	if (!ascending) {
 		retval = -retval;
 	}
 

Code/Tools/W3DView/GraphicView.cpp

@@ -469,14 +469,14 @@ CGraphicView::RepaintView
 
 		// Perform the object rotation if necessary
 		if ((m_objectRotation != NoRotation) &&
-			(bUpdateAnimation == true))
+			(bUpdateAnimation != 0))
 		{
 			Rotate_Object ();
 		}
 
 		// Perform the light rotation if necessary
 		if ((m_LightRotation != NoRotation) &&
-			(bUpdateAnimation == true))
+			(bUpdateAnimation != 0))
 		{
 			Rotate_Light ();
 		}
@@ -756,9 +756,9 @@ CGraphicView::OnLButtonUp
     }
 
     // Mouse button is up
-    m_bMouseDown = false;    
+    m_bMouseDown = FALSE;    
 
-    if (m_bRMouseDown == true)
+    if (m_bRMouseDown == TRUE)
     {
         ::SetCursor (::LoadCursor (::AfxGetResourceHandle (), MAKEINTRESOURCE (IDC_CURSOR_ZOOM)));
 		  ((CW3DViewDoc *)GetDocument())->Set_Cursor ("zoom.tga");

Code/Tools/W3DView/SceneLightDialog.cpp

@@ -271,7 +271,7 @@ CSceneLightDialog::OnCancel (void)
 		// Restore the intensity, attenuation, and distance settings
 		pCDoc->GetSceneLight ()->Set_Intensity (m_InitialIntensity);
 		pCDoc->GetSceneLight ()->Set_Far_Attenuation_Range (m_InitialStartAtten, m_InitialEndAtten);
-		pCDoc->GetSceneLight ()->Set_Flag (LightClass::FAR_ATTENUATION, (m_InitialAttenOn == true));
+		pCDoc->GetSceneLight ()->Set_Flag (LightClass::FAR_ATTENUATION, (m_InitialAttenOn != 0));
 		Update_Distance (m_InitialDistance);		
 	}
 

Code/Tools/W3DView/Utils.cpp

@@ -816,7 +816,7 @@ Get_File_Time
 	if (hfile != INVALID_HANDLE_VALUE) {
 
 		// Get the mod times for this file
-		retval = (::GetFileTime (hfile, pcreation_time, paccess_time, pwrite_time) == true);
+		retval = (::GetFileTime (hfile, pcreation_time, paccess_time, pwrite_time) != 0);
 
 		// Close the file
 		SAFE_CLOSE (hfile);
@@ -944,7 +944,7 @@ Copy_File
 
 	// Perform the copy operation!
 	if (allow_copy) {
-		retval = (::CopyFile (existing_filename, new_filename, false) == true);
+		retval = (::CopyFile (existing_filename, new_filename, false) != 0);
 	}
 
 	// Return the true/false result code

Code/Tools/W3DView/W3DViewDoc.cpp

@@ -104,7 +104,7 @@ CW3DViewDoc::CW3DViewDoc (void)
 		m_pCAnimCombo (NULL),
 		m_pCBackgroundBMP (NULL),		
       m_CurrentFrame (0),
-      m_bAnimBlend (true),
+      m_bAnimBlend (TRUE),
 		m_bAnimateCamera (false),
 		m_bAutoCameraReset (true),
 		m_bOneTimeReset (true),
@@ -118,8 +118,8 @@ CW3DViewDoc::CW3DViewDoc (void)
 		m_bCompress_channel_Q(false)
 {
 	// Read the camera animation settings from the registry
-	m_bAnimateCamera = ((BOOL)theApp.GetProfileInt ("Config", "AnimateCamera", 0)) == true;
-	m_bAutoCameraReset = ((BOOL)theApp.GetProfileInt ("Config", "ResetCamera", 1)) == true;
+	m_bAnimateCamera = ((BOOL)theApp.GetProfileInt ("Config", "AnimateCamera", 0)) != 0;
+	m_bAutoCameraReset = ((BOOL)theApp.GetProfileInt ("Config", "ResetCamera", 1)) != 0;
 	return ;
 }
 
@@ -3032,8 +3032,8 @@ CW3DViewDoc::Save_Camera_Settings (void)
 void
 CW3DViewDoc::Load_Camera_Settings (void)
 {
-	m_ManualFOV				= (theApp.GetProfileInt ("Config", "UseManualFOV", 0) == true);
-	m_ManualClipPlanes	= (theApp.GetProfileInt ("Config", "UseManualClipPlanes", 0) == true);
+	m_ManualFOV				= (theApp.GetProfileInt ("Config", "UseManualFOV", 0) != 0);
+	m_ManualClipPlanes	= (theApp.GetProfileInt ("Config", "UseManualClipPlanes", 0) != 0);
 
 	CGraphicView *graphic_view	= GetGraphicView ();
 	if (graphic_view != NULL) {

Code/wwlib/LaunchWeb.cpp

@@ -119,5 +119,5 @@ bool LaunchWebBrowser(const char* url)
 
 	assert(createSuccess && "Failed to launch default WebBrowser.");
 
-	return (true == createSuccess);
+	return (createSuccess != 0);
 	}