Fixes #80, ensure we check for registrations.

Author: david-driscoll

src/Protocol/Client/RegisterCapabilityExtensions.cs

@@ -11,15 +11,7 @@ public static class RegisterCapabilityExtensions
     {
         public static async Task RegisterCapability(this IResponseRouter mediator,  RegistrationParams @params)
         {
-            try
-            {
                 await mediator.SendRequest(Client.ClientNames.RegisterCapability, @params);
-            }
-            catch (Exception e)
-            {
-                // VsCode today does not implement LSP properly.
-                await mediator.SendRequest("client/registerFeature", @params);
-            }
         }
     }
 }

src/Protocol/Client/UnregisterCapabilityExtensions.cs

@@ -16,15 +16,7 @@ public static class UnregisterCapabilityExtensions
     {
         public static async Task UnregisterCapability(this IResponseRouter mediator, UnregistrationParams @params)
         {
-            try
-            {
-                await mediator.SendRequest(ClientNames.UnregisterCapability, @params);
-            }
-            catch (Exception e)
-            {
-                // VsCode today does not implement LSP properly.
-                await mediator.SendRequest("client/unregisterFeature", @params);
-            }
+            await mediator.SendRequest(ClientNames.UnregisterCapability, @params);
         }
     }
 }

src/Server/LanguageServer.cs

@@ -107,9 +107,8 @@ public IDisposable AddHandler(string method, IJsonRpcHandler handler)
                 {
                     var foundItems = _collection
                         .Where(x => handler == x.Handler)
-                        .Where(x => x.AllowsDynamicRegistration)
+                        .Where(x => x.AllowsDynamicRegistration && x.HasRegistration)
                         .Select(x => x.Registration)
-                        .Where(x => x != null)
                         .ToArray();
 
                     Task.Run(() => this.UnregisterCapability(new UnregistrationParams()
@@ -140,9 +139,8 @@ public IDisposable AddHandlers(params IJsonRpcHandler[] handlers)
                     var foundItems = handlers
                     .SelectMany(handler => _collection
                         .Where(x => handler == x.Handler)
-                        .Where(x => x.AllowsDynamicRegistration)
-                        .Select(x => x.Registration)
-                        .Where(x => x != null))
+                        .Where(x => x.AllowsDynamicRegistration && x.HasRegistration)
+                        .Select(x => x.Registration))
                     .ToArray();
 
                     Task.Run(() => this.UnregisterCapability(new UnregistrationParams()
@@ -324,7 +322,7 @@ private void ProcessCapabilties(object instance)
         private async Task DynamicallyRegisterHandlers()
         {
             var registrations = _collection
-                .Where(x => x.AllowsDynamicRegistration)
+                .Where(x => x.AllowsDynamicRegistration && x.HasRegistration)
                 .Select(handler => handler.Registration)
                 .ToList();