Rename EmptyNotificationHandler to NotificationHandler where practical (#43).

Author: tintoy

src/Client/Dispatcher/LspDispatcherExtensions.cs

@@ -18,12 +18,12 @@ public static class LspDispatcherExtensions
         ///     The name of the notification method to handle.
         /// </param>
         /// <param name="handler">
-        ///     A <see cref="EmptyNotificationHandler"/> delegate that implements the handler.
+        ///     A <see cref="NotificationHandler"/> delegate that implements the handler.
         /// </param>
         /// <returns>
         ///     An <see cref="IDisposable"/> representing the registration.
         /// </returns>
-        public static IDisposable HandleEmptyNotification(this LspDispatcher clientDispatcher, string method, EmptyNotificationHandler handler)
+        public static IDisposable HandleEmptyNotification(this LspDispatcher clientDispatcher, string method, NotificationHandler handler)
         {
             if (clientDispatcher == null)
                 throw new ArgumentNullException(nameof(clientDispatcher));

src/Client/HandlerDelegates.cs

@@ -12,7 +12,7 @@ namespace OmniSharp.Extensions.LanguageServerProtocol.Client
     /// <returns>
     ///     A <see cref="Task"/> representing the operation.
     /// </returns>
-    public delegate void EmptyNotificationHandler();
+    public delegate void NotificationHandler();
 
     /// <summary>
     ///     A handler for notifications.

src/Client/Handlers/DelegateEmptyNotificationHandler.cs

@@ -16,9 +16,9 @@ public class DelegateEmptyNotificationHandler
         ///     The name of the method handled by the handler.
         /// </param>
         /// <param name="handler">
-        ///     The <see cref="EmptyNotificationHandler"/> delegate that implements the handler.
+        ///     The <see cref="NotificationHandler"/> delegate that implements the handler.
         /// </param>
-        public DelegateEmptyNotificationHandler(string method, EmptyNotificationHandler handler)
+        public DelegateEmptyNotificationHandler(string method, NotificationHandler handler)
             : base(method)
         {
             if (handler == null)
@@ -28,9 +28,9 @@ public DelegateEmptyNotificationHandler(string method, EmptyNotificationHandler
         }
 
         /// <summary>
-        ///     The <see cref="EmptyNotificationHandler"/> delegate that implements the handler.
+        ///     The <see cref="NotificationHandler"/> delegate that implements the handler.
         /// </summary>
-        public EmptyNotificationHandler Handler { get; }
+        public NotificationHandler Handler { get; }
 
         /// <summary>
         ///     The kind of handler.

src/Client/LanguageClient.cs

@@ -254,7 +254,7 @@ public Task HasShutdown
 
                 Log.Verbose("Sending 'initialized' notification to language server...");
 
-                SendEmptyNotification("initialized");
+                SendNotification("initialized");
 
                 Log.Verbose("Sent 'initialized' notification to language server.");
 
@@ -319,7 +319,7 @@ public async Task Shutdown()
         /// <param name="method">
         ///     The notification method name.
         /// </param>
-        public void SendEmptyNotification(string method)
+        public void SendNotification(string method)
         {
             LspConnection connection = _connection;
             if (connection == null || !connection.IsOpen)

src/Client/LanguageClientRegistration.cs

@@ -19,12 +19,12 @@ public static class LanguageRegistration
         ///     The name of the notification method to handle.
         /// </param>
         /// <param name="handler">
-        ///     A <see cref="EmptyNotificationHandler"/> delegate that implements the handler.
+        ///     A <see cref="NotificationHandler"/> delegate that implements the handler.
         /// </param>
         /// <returns>
         ///     An <see cref="IDisposable"/> representing the registration.
         /// </returns>
-        public static IDisposable HandleEmptyNotification(this LanguageClient languageClient, string method, EmptyNotificationHandler handler)
+        public static IDisposable HandleNotification(this LanguageClient languageClient, string method, NotificationHandler handler)
         {
             if (languageClient == null)
                 throw new ArgumentNullException(nameof(languageClient));
@@ -55,7 +55,7 @@ public static IDisposable HandleEmptyNotification(this LanguageClient languageCl
         /// <returns>
         ///     An <see cref="IDisposable"/> representing the registration.
         /// </returns>
-        public static IDisposable HandleEmptyNotification(this LanguageClient languageClient, string method, INotificationHandler handler)
+        public static IDisposable HandleNotification(this LanguageClient languageClient, string method, INotificationHandler handler)
         {
             if (languageClient == null)
                 throw new ArgumentNullException(nameof(languageClient));

src/Client/Protocol/LspConnectionExtensions.cs

@@ -18,12 +18,12 @@ public static class LspConnectionExtensions
         ///     The name of the notification method to handle.
         /// </param>
         /// <param name="handler">
-        ///     A <see cref="EmptyNotificationHandler"/> delegate that implements the handler.
+        ///     A <see cref="NotificationHandler"/> delegate that implements the handler.
         /// </param>
         /// <returns>
         ///     An <see cref="IDisposable"/> representing the registration.
         /// </returns>
-        public static IDisposable HandleEmptyNotification(this LspConnection clientConnection, string method, EmptyNotificationHandler handler)
+        public static IDisposable HandleEmptyNotification(this LspConnection clientConnection, string method, NotificationHandler handler)
         {
             if (clientConnection == null)
                 throw new ArgumentNullException(nameof(clientConnection));