Skip to content

LSP server ignores client capabilities resolveSupport and dataSupport #2693

@dvaembit

Description

@dvaembit

My LSP client is sending codeAction.dataSupport: false and codeAction.resolveSupport: { properties: [] } in it's client capabilities. However the code actions offered by OmniSharp still include incomplete code actions that require resolution. For example:

{
  "jsonrpc": "2.0",
  "id": 4,
  "result": [
    {
      "title": "Remove unnecessary usings",
      "kind": "quickfix",
      "diagnostics": [],
      "data": {
        "Uri": "...",
        "Identifier": "Remove unnecessary usings",
        "Name": "Remove unnecessary usings",
        "Range": {
          "Start": {
            "Line": 13,
            "Character": 0
          },
          "End": {
            "Line": 13,
            "Character": 16
          }
        },
        "$$__handler_id__$$": "634ad2b9-ebc1-4f2c-8c33-42ff2434f8aa"
      }
    }
  ]
}

I would expect this code action to either be omitted from the code action list or to include the edit or command fields.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions