Skip to content
This repository was archived by the owner on Mar 1, 2025. It is now read-only.

Commit 7083362

Browse files
authored
Merge pull request FreeCAD#18737 from Roy-043/Draft-Remove-unnecessary-CamelCase-names
Draft: Remove unnecessary CamelCase names
2 parents 6bb424b + 9b8b962 commit 7083362

File tree

5 files changed

+11
-61
lines changed

5 files changed

+11
-61
lines changed

src/Mod/Draft/Draft.py

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -79,9 +79,7 @@
7979
compareObjects,
8080
shapify,
8181
filter_objects_for_modifiers,
82-
filterObjectsForModifiers,
83-
is_closed_edge,
84-
isClosedEdge)
82+
is_closed_edge)
8583

8684
from draftutils.utils import (string_encode_coin,
8785
stringencodecoin,
@@ -155,27 +153,21 @@
155153

156154
from draftfunctions.move import (move,
157155
move_vertex,
158-
moveVertex,
159156
move_edge,
160-
moveEdge,
161-
copy_moved_edges,
162-
copyMovedEdges)
157+
copy_moved_edge,
158+
copy_moved_edges)
163159

164160
from draftfunctions.rotate import (rotate,
165161
rotate_vertex,
166-
rotateVertex,
167162
rotate_edge,
168-
rotateEdge,
169-
copy_rotated_edges,
170-
copyRotatedEdges)
163+
copy_rotated_edge,
164+
copy_rotated_edges)
171165

172166
from draftfunctions.scale import (scale,
173167
scale_vertex,
174-
scaleVertex,
175168
scale_edge,
176-
scaleEdge,
177-
copy_scaled_edges,
178-
copyScaledEdges)
169+
copy_scaled_edge,
170+
copy_scaled_edges)
179171

180172
from draftfunctions.join import (join_wires,
181173
joinWires,

src/Mod/Draft/draftfunctions/move.py

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -176,24 +176,18 @@ def move_vertex(object, vertex_index, vector):
176176
object.Points = points
177177

178178

179-
moveVertex = move_vertex
180-
181-
182179
def move_edge(object, edge_index, vector):
183180
"""
184181
Needed for SubObjects modifiers.
185182
Implemented by Dion Moult during 0.19 dev cycle (works only with Draft Wire).
186183
"""
187184
move_vertex(object, edge_index, vector)
188-
if utils.isClosedEdge(edge_index, object):
185+
if utils.is_closed_edge(edge_index, object):
189186
move_vertex(object, 0, vector)
190187
else:
191188
move_vertex(object, edge_index+1, vector)
192189

193190

194-
moveEdge = move_edge
195-
196-
197191
def copy_moved_edges(arguments):
198192
"""
199193
Needed for SubObjects modifiers.
@@ -205,16 +199,13 @@ def copy_moved_edges(arguments):
205199
join.join_wires(copied_edges)
206200

207201

208-
copyMovedEdges = copy_moved_edges
209-
210-
211202
def copy_moved_edge(object, edge_index, vector):
212203
"""
213204
Needed for SubObjects modifiers.
214205
Implemented by Dion Moult during 0.19 dev cycle (works only with Draft Wire).
215206
"""
216207
vertex1 = object.getGlobalPlacement().multVec(object.Points[edge_index]).add(vector)
217-
if utils.isClosedEdge(edge_index, object):
208+
if utils.is_closed_edge(edge_index, object):
218209
vertex2 = object.getGlobalPlacement().multVec(object.Points[0]).add(vector)
219210
else:
220211
vertex2 = object.getGlobalPlacement().multVec(object.Points[edge_index+1]).add(vector)

src/Mod/Draft/draftfunctions/rotate.py

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -182,9 +182,6 @@ def rotate_vertex(object, vertex_index, angle, center, axis):
182182
object.Points = points
183183

184184

185-
rotateVertex = rotate_vertex
186-
187-
188185
def rotate_vector_from_center(vector, angle, axis, center):
189186
"""
190187
Needed for SubObjects modifiers.
@@ -195,24 +192,18 @@ def rotate_vector_from_center(vector, angle, axis, center):
195192
return center.add(rv)
196193

197194

198-
rotateVectorFromCenter = rotate_vector_from_center
199-
200-
201195
def rotate_edge(object, edge_index, angle, center, axis):
202196
"""
203197
Needed for SubObjects modifiers.
204198
Implemented by Dion Moult during 0.19 dev cycle (works only with Draft Wire).
205199
"""
206200
rotate_vertex(object, edge_index, angle, center, axis)
207-
if utils.isClosedEdge(edge_index, object):
201+
if utils.is_closed_edge(edge_index, object):
208202
rotate_vertex(object, 0, angle, center, axis)
209203
else:
210204
rotate_vertex(object, edge_index+1, angle, center, axis)
211205

212206

213-
rotateEdge = rotate_edge
214-
215-
216207
def copy_rotated_edges(arguments):
217208
"""
218209
Needed for SubObjects modifiers.
@@ -225,9 +216,6 @@ def copy_rotated_edges(arguments):
225216
join.join_wires(copied_edges)
226217

227218

228-
copyRotatedEdges = copy_rotated_edges
229-
230-
231219
def copy_rotated_edge(object, edge_index, angle, center, axis):
232220
"""
233221
Needed for SubObjects modifiers.
@@ -236,7 +224,7 @@ def copy_rotated_edge(object, edge_index, angle, center, axis):
236224
vertex1 = rotate_vector_from_center(
237225
object.getGlobalPlacement().multVec(object.Points[edge_index]),
238226
angle, axis, center)
239-
if utils.isClosedEdge(edge_index, object):
227+
if utils.is_closed_edge(edge_index, object):
240228
vertex2 = rotate_vector_from_center(
241229
object.getGlobalPlacement().multVec(object.Points[0]),
242230
angle, axis, center)

src/Mod/Draft/draftfunctions/scale.py

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -155,9 +155,6 @@ def scale_vertex(obj, vertex_index, scale, center):
155155
obj.Points = points
156156

157157

158-
scaleVertex = scale_vertex
159-
160-
161158
def scale_vector_from_center(vector, scale, center):
162159
"""
163160
Needed for SubObjects modifiers.
@@ -166,9 +163,6 @@ def scale_vector_from_center(vector, scale, center):
166163
return vector.sub(center).scale(scale.x, scale.y, scale.z).add(center)
167164

168165

169-
scaleVectorFromCenter = scale_vector_from_center
170-
171-
172166
def scale_edge(obj, edge_index, scale, center):
173167
"""
174168
Needed for SubObjects modifiers.
@@ -181,9 +175,6 @@ def scale_edge(obj, edge_index, scale, center):
181175
scale_vertex(obj, edge_index+1, scale, center)
182176

183177

184-
scaleEdge = scale_edge
185-
186-
187178
def copy_scaled_edge(obj, edge_index, scale, center):
188179
"""
189180
Needed for SubObjects modifiers.
@@ -203,9 +194,6 @@ def copy_scaled_edge(obj, edge_index, scale, center):
203194
return make_line.make_line(vertex1, vertex2)
204195

205196

206-
copyScaledEdge = copy_scaled_edge
207-
208-
209197
def copy_scaled_edges(arguments):
210198
"""
211199
Needed for SubObjects modifiers.
@@ -217,7 +205,4 @@ def copy_scaled_edges(arguments):
217205
argument[2], argument[3]))
218206
join.join_wires(copied_edges)
219207

220-
221-
copyScaledEdges = copy_scaled_edges
222-
223208
## @}

src/Mod/Draft/draftutils/utils.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -906,16 +906,10 @@ def filter_objects_for_modifiers(objects, isCopied=False):
906906
return filteredObjects
907907

908908

909-
filterObjectsForModifiers = filter_objects_for_modifiers
910-
911-
912909
def is_closed_edge(edge_index, object):
913910
return edge_index + 1 >= len(object.Points)
914911

915912

916-
isClosedEdge = is_closed_edge
917-
918-
919913
def utf8_decode(text):
920914
r"""Decode the input string and return a unicode string.
921915

0 commit comments

Comments
 (0)