ci: entry crit dependency

Author: parisb

.github/copilot-instructions.md

@@ -11,12 +11,16 @@ When testing unexported methods or functions, these tests should be created in a
 
 Wherever the tested method or function uses the afero package, always use a memmap fs as the filesystem in tests (i.e. don't write to disk where this can be avoided.).
 
-When writing assertions in tests, do not abstract assertion/verification logic into functions stores in test cases, explicitly define the assertion or verification logic in the "Assert" portion of the test; use conditional logic if needed here. Use testify require (not testify assert) when checking for the presence or absence of errors.
+When writing assertions in tests, do not abstract assertion/verification logic into functions stores in test cases, explicitly define the assertion or verification logic in the "Assert" portion of the test; use conditional logic if needed here. Use testify require (not testify assert) when checking for the presence or absence of errors. Use assert.Len when asserting the length of objects.
 
 When creating a test file, the package name should always be the package name with "\_test" appended.
 
-When creating or satisfying a slog logger on services, always use the DiscardHandler
+When creating or satisfying a slog logger on services, always use the DiscardHandler.
 
 <!-- Style -->
 
 Any comments you include above functions or types should end with a period.
+
+<!-- Code Quality -->
+
+When generating go code, avoid variable name shadowing.

.github/workflows/pr.yaml

@@ -6,6 +6,7 @@ name: PR
 on:
   push:
     branches: ["main"]
+
   pull_request:
     branches: ["main"]
 
@@ -15,11 +16,9 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - uses: wagoid/commitlint-github-action@v6
-      - uses: actions/checkout@v3
-      - uses: actions/setup-python@v3
-      - uses: pre-commit/[email protected]
 
   build:
+    needs: entry
     runs-on: ubuntu-latest
     steps:
       - name: Install Task

cmd/features/project.feature

@@ -9,9 +9,3 @@ Scenario Outline: using SourceSets (defined in a local .sources.yaml) using diff
     Examples:
         | sourceSet          | authType | flagString | valuesFile  |
         | terraformChildSet  | ssh      | --token    | values.yaml |
-
-
-Scenario Outline: title
-    Given context
-    When event
-    Then outcome

cmd/features/get_values.feature cmd/features/values.featurecmd/features/get_values.feature renamed to cmd/features/values.feature

@@ -0,0 +1,39 @@
+//go:build integration
+
+package cmd_test
+
+import (
+	"io"
+	"testing"
+
+	"github.com/cucumber/godog"
+	"github.com/spf13/cobra"
+)
+
+func TestValues(t *testing.T) {
+	suite := godog.TestSuite{
+		ScenarioInitializer: InitializeScenario,
+		// TestSuiteInitializer: IntializeTestSuite,
+		Options: &godog.Options{
+			Format:   "pretty",
+			Paths:    []string{"features/values.feature"},
+			TestingT: t, // Testing instance that will run subtests.
+		},
+	}
+
+	if suite.Run() != 0 {
+		t.Fatal("non-zero status returned, failed to run feature tests")
+	}
+}
+
+type valuesScenarioContainer struct {
+	ProjectCommand        *cobra.Command
+	TmpltrConfigPathFlag  string
+	SourcesConfigPathFlag string
+	ValuesPathFlag        string
+	OutputPathFlag        string
+	OutputPath            string
+	CommandArgs           []string
+	OutPutWriter          io.Writer
+	Context               *godog.ScenarioContext
+}