Skip to content

Commit b963eab

Browse files
committed
fix view comments link with basename
1 parent f977375 commit b963eab

File tree

3 files changed

+13
-4
lines changed

3 files changed

+13
-4
lines changed

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
"react-markdown": "^4.1.0",
2727
"react-relay": "^5.0.0",
2828
"react-router-dom": "^5.0.1",
29+
"react-router-hash-link": "^1.2.2",
2930
"react-router-scroll-memory": "^2.0.3",
3031
"react-syntax-highlighter": "^11.0.2",
3132
"serialize-javascript": "^1.7.0",

src/Post.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,11 @@ import AddIcon from './addIcon';
1515
import Tippy, {TippyGroup} from '@tippy.js/react';
1616
import 'tippy.js/themes/light-border.css';
1717
import {Link} from 'react-router-dom';
18+
import {HashLink} from 'react-router-hash-link';
1819
import {postRootQuery} from './App';
1920
import GitHubLoginButton from './GitHubLoginButton';
2021
import {NotificationContext} from './Notifications';
21-
import {Box, Heading, Text, Anchor} from 'grommet';
22+
import {Box, Heading, Text} from 'grommet';
2223
import UserContext from './UserContext';
2324
import {lowerCase, sentenceCase} from 'change-case';
2425

@@ -370,9 +371,9 @@ const Post = ({relay, post}: Props) => {
370371
{formatDate(new Date(post.createdAt), 'MMM eo, yyyy')}
371372
</Text>
372373
<Text size="xsmall">
373-
<Anchor href={`/post/${post.number}#comments`}>
374+
<HashLink to={`/post/${post.number}#comments`}>
374375
view comments
375-
</Anchor>
376+
</HashLink>
376377
</Text>
377378
</Box>
378379
<Text size="small">

yarn.lock

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11179,7 +11179,7 @@ prompts@^0.1.9:
1117911179
kleur "^2.0.1"
1118011180
sisteransi "^0.1.1"
1118111181

11182-
prop-types@^15.5.4, prop-types@^15.6.2, prop-types@^15.7.2:
11182+
prop-types@^15.5.4, prop-types@^15.6.0, prop-types@^15.6.2, prop-types@^15.7.2:
1118311183
version "15.7.2"
1118411184
resolved "https://registry.yarnpkg.com/prop-types/-/prop-types-15.7.2.tgz#52c41e75b8c87e72b9d9360e0206b99dcbffa6c5"
1118511185
integrity sha512-8QQikdH7//R2vurIJSutZ1smHYTcLpRWEOlHnzcWHmBYrOGUysKwSsrC89BCiFj3CbrfJ/nXFdJepOVrY1GCHQ==
@@ -11563,6 +11563,13 @@ react-router-dom@^5.0.1:
1156311563
tiny-invariant "^1.0.2"
1156411564
tiny-warning "^1.0.0"
1156511565

11566+
react-router-hash-link@^1.2.2:
11567+
version "1.2.2"
11568+
resolved "https://registry.yarnpkg.com/react-router-hash-link/-/react-router-hash-link-1.2.2.tgz#7a0ad5e925d49596d19554de8bc6c554ce4f8099"
11569+
integrity sha512-LBthLVHdqPeKDVt3+cFRhy15Z7veikOvdKRZRfyBR2vjqIE7rxn+tKLjb6DOmLm6JpoQVemVDnxQ35RVnEHdQA==
11570+
dependencies:
11571+
prop-types "^15.6.0"
11572+
1156611573
react-router-scroll-memory@^2.0.3:
1156711574
version "2.0.3"
1156811575
resolved "https://registry.yarnpkg.com/react-router-scroll-memory/-/react-router-scroll-memory-2.0.3.tgz#b3ad3e2d147688e05242abb68002378e674396da"

0 commit comments

Comments
 (0)