Skip to content

Commit 70fdcd7

Browse files
fix(security): autofix Template Injection in GitHub Workflows Action
1 parent ad686bd commit 70fdcd7

File tree

1 file changed

+12
-10
lines changed

1 file changed

+12
-10
lines changed

.github/workflows/release.yml

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,13 @@ jobs:
5252
- name: Determine tag
5353
id: vars
5454
shell: bash
55+
env:
56+
INPUT_TAG: ${{ inputs.tag }}
5557
run: |
5658
if [[ "${GITHUB_REF}" == refs/tags/* ]]; then
5759
TAG="${GITHUB_REF#refs/tags/}"
5860
else
59-
TAG="${{ inputs.tag }}"
61+
TAG="$INPUT_TAG"
6062
fi
6163
echo "tag=$TAG" >> $GITHUB_OUTPUT
6264
echo "release_name=zgw-token-introspection $TAG" >> $GITHUB_OUTPUT
@@ -71,17 +73,17 @@ jobs:
7173
if: ${{ steps.vars.outputs.tag != '' }}
7274
env:
7375
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
76+
TAG: ${{ steps.vars.outputs.tag }}
77+
TITLE: ${{ steps.vars.outputs.release_name }}
78+
TARGET_SHA: ${{ github.sha }}
7479
run: |
75-
tag="${{ steps.vars.outputs.tag }}"
76-
title="${{ steps.vars.outputs.release_name }}"
77-
78-
if gh release view "$tag" >/dev/null 2>&1; then
79-
gh release upload "$tag" "dist/zgw-token-introspection.jar" --clobber
80+
if gh release view "$TAG" >/dev/null 2>&1; then
81+
gh release upload "$TAG" "dist/zgw-token-introspection.jar" --clobber
8082
else
81-
gh release create "$tag" "dist/zgw-token-introspection.jar" \
82-
--title "$title" \
83-
--notes "Automated release $tag" \
84-
--target "$GITHUB_SHA"
83+
gh release create "$TAG" "dist/zgw-token-introspection.jar" \
84+
--title "$TITLE" \
85+
--notes "Automated release $TAG" \
86+
--target "$TARGET_SHA"
8587
fi
8688
8789

0 commit comments

Comments
 (0)